[Bug 25440] New: Remove undef and CGI warnings and fix defaults in circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Bug ID: 25440 Summary: Remove undef and CGI warnings and fix defaults in circulation rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: nugged@gmail.com Reporter: nugged@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I am proposing a set of fixes, which I found when doing another mine complicated circulation rules task: I will post separate patches one-by-one with explanations here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #1 from Andrew Nugged <nugged@gmail.com> --- Created attachment 104635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104635&action=edit Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl This warning emitted: Use of uninitialized value $maxsuspensiondays in string eq at /admin/smart-rules.pl line 257. But that not just undef-warning, there is broken logic, these two lines are mutually contradictory and goes one-by-one: $maxsuspensiondays = undef if $maxsuspensiondays eq q||; $maxsuspensiondays = '' if $maxsuspensiondays eq q||; Fix is simple: both removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #2 from Andrew Nugged <nugged@gmail.com> --- Created attachment 104636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104636&action=edit Bug 25440: Extra duplicated call to CGI->param method removed In code CGI param 'no_auto_renewal_after_hard_limit' assigned to "$no_auto_renewal_after_hard_limit" var, and then just in the next line again variable "$no_auto_renewal_after_hard_limit" reassigned with call to same "$input->param('no_auto_renewal_after_hard_limit')". Fixed. No logic or results should be changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #3 from Andrew Nugged <nugged@gmail.com> --- Created attachment 104637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104637&action=edit Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl This warning emitted: Use of uninitialized value in string eq at /admin/smart-rules.pl line 289. It is solved by one line added to exclude comparison with 'on' string when variable is 'undef'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #4 from Andrew Nugged <nugged@gmail.com> --- Created attachment 104638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104638&action=edit Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl This warning emitted: CGI::param called in list context from /admin/smart-rules.pl line 262, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at CGI.pm line 412. Explained here: https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-... And because all these params are not multi-params, so simple "scalar .." forcing for CGI->param is the fix. Changes are transparent and same values should be assigned as before, just no more warnings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #5 from Andrew Nugged <nugged@gmail.com> --- Created attachment 104639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104639&action=edit Bug 25440: Fix for "uninitialized value in hash" warning in smart-rules.pl This warning emitted: Use of uninitialized value in hash element at /admin/smart-rules.pl line 569. that happened because we have NULLs in SQL results for 'categorycode' and 'itemtype' which later used as 'any' kind of category/item in the template, so for the template it passed this way: $rules->{ $r->{categorycode} }->{ $r->{itemtype} }->... but undef will stringify as "" to become a hash key ("Hashes are unordered collections of scalar values indexed by their associated string key" https://perldoc.perl.org/perldata.html), that's why "undef warning". To prevent warning here is the simple fix: $rules->{ $r->{categorycode} // '' }->{ $r->{itemtype} // '' }->... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #6 from Andrew Nugged <nugged@gmail.com> --- Created attachment 104640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104640&action=edit Bug 25440: Fixed list of 'show_rule' forming variables in the template In smart-rules.tt we have `SET show_rule = ...` section which filled with 'all used in the loop' variables. Because if historical reasons it seems that there are some missing, few old, and even doubled ones. This list is fixed now by: - variable names 'article_requests' and 'renewalsallowed' repeated so duplicates are removed; - 'hardduedatebefore' and 'hardduedateexact' not present in the whole site code anywhere anymore; IMPORTANT NOTE: these 'hardduedatebefore/hardduedateexact' also exists as remnants in .po-translation files, a lot. - 'note', 'hardduedatecompare', 'renewalperiod', 'rentaldiscount' template variables were missing from this 'show_rule =' checking code so they are added. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove undef and CGI |Remove undef and CGI |warnings and fix defaults |warnings and fix template |in circulation rules |variables list in | |circulation rules -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 104637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104637 Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl Review of attachment 104637: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25440&attachment=104637) ----------------------------------------------------------------- ::: admin/smart-rules.pl @@ +284,5 @@
my $opacitemholds = $input->param('opacitemholds') || 0; my $article_requests = $input->param('article_requests') || 'no'; my $overduefinescap = $input->param('overduefinescap') || ''; + my $cap_fine_to_replacement_price = $input->param('cap_fine_to_replacement_price'); + $cap_fine_to_replacement_price = $cap_fine_to_replacement_price && $cap_fine_to_replacement_price eq 'on';
What about cap_fine_to_replacement_price = ($cap_fine_to_replacement_price || '') eq 'on'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 104635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104635 Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl Review of attachment 104635: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=25440&attachment=104635) ----------------------------------------------------------------- ::: admin/smart-rules.pl @@ -253,5 @@
my $fine = $input->param('fine'); my $finedays = $input->param('finedays'); my $maxsuspensiondays = $input->param('maxsuspensiondays'); - $maxsuspensiondays = undef if $maxsuspensiondays eq q||; - $maxsuspensiondays = '' if $maxsuspensiondays eq q||;
Maybe a bit radical :) This is coming from a bad merge resolution conflict, I think it should be: my $maxsuspensiondays = $input->param('maxsuspensiondays') || q||; Just a feeling, it should be tested. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #9 from Andrew Nugged <nugged@gmail.com> --- (In reply to Jonathan Druart from comment #7)
+ my $cap_fine_to_replacement_price = $input->param('cap_fine_to_replacement_price'); + $cap_fine_to_replacement_price = $cap_fine_to_replacement_price && $cap_fine_to_replacement_price eq 'on';
What about
cap_fine_to_replacement_price = ($cap_fine_to_replacement_price || '') eq 'on';
I just mimicked code style in this same block, but of course (and I also like that in Perl) we can undef-protect inline if you want. Should I recreate the patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes please :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #11 from Andrew Nugged <nugged@gmail.com> --- (In reply to Jonathan Druart from comment #8)
- $maxsuspensiondays = undef if $maxsuspensiondays eq q||; - $maxsuspensiondays = '' if $maxsuspensiondays eq q||;
Maybe a bit radical :)
This is coming from a bad merge resolution conflict, I think it should be: my $maxsuspensiondays = $input->param('maxsuspensiondays') || q||;
Just a feeling, it should be tested.
In old db before circulation_rules table, it was "NULL-possible" value, so I was confused too. $input->param('maxsuspensiondays') here always comes as '' from posted form but if parameter absent so default might be When I removed these both lines I found in code only one place where this key is used: File: /opt/n/koha/git/KohaCommunity/C4/Circulation.pm 2326: my $max_sd = $issuing_rule->{maxsuspensiondays}; 2327: if ( defined $max_sd && $max_sd ne '' ) { 2328: $max_sd = DateTime::Duration->new( days => $max_sd ); 2329: $suspension_days = $max_sd 2330: if DateTime::Duration->compare( $max_sd, $suspension_days ) < 0; 2331: } and there both '' and undef is possible, so no matter which one we will have in db. But because current circulation_rules not allow "NULLS" for key/val pairs but pair absence is assumed as null so it might be the consequences, that why we had few other fixes and slightly mess with default states for parameters after conversion from issuinrules to circulation_rules, but yes, I agree, let's stick with one value, let it be ''. Recreating the patch now and will follow your proposal: and it works as on me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104637|0 |1 is obsolete| | --- Comment #12 from Andrew Nugged <nugged@gmail.com> --- Created attachment 105059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105059&action=edit Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl This warning emitted: Use of uninitialized value in string eq at /admin/smart-rules.pl line 289. It is solved by adding ".. || ''" to exclude comparison with 'on' string when variable is 'undef'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104635|0 |1 is obsolete| | --- Comment #13 from Andrew Nugged <nugged@gmail.com> --- Created attachment 105063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105063&action=edit Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl This warning emitted: Use of uninitialized value $maxsuspensiondays in string eq at /admin/smart-rules.pl line 257. But that not just undef-warning, there is broken logic, these two lines are mutually contradictory and goes one-by-one: $maxsuspensiondays = undef if $maxsuspensiondays eq q||; $maxsuspensiondays = '' if $maxsuspensiondays eq q||; Fix is simple: to make it '' if it comes undef. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This last patch makes sense to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Nugged from comment #6)
Created attachment 104640 [details] [review] Bug 25440: Fixed list of 'show_rule' forming variables in the template
Can you rewrite this patch keeping the exact same order of the variable list before? note, maxissueqty, maxonsiteissueqty, issuelength, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #16 from Andrew Nugged <nugged@gmail.com> --- Order in "SET show_rule = ..."? It is as before, but changes are: 1. "hardduedatebefore || hardduedateexact" obsolete and removed, 2. "renewalsallowed" duplicate removed, 3. "article_requests" duplicate removed, 4. and new missed list "note || hardduedatecompare || renewalperiod || rentaldiscount || " added on the beginning of the line, ... no order changed. Can it be that was those p4 changes to the line start made you think that order changed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #17 from Andrew Nugged <nugged@gmail.com> --- (or you want this " || " set to be the exact match with lines 129-157 separate one-by-one sets list?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #18 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- You added: note || hardduedatecompare || renewalperiod || rentaldiscount before maxissueqty. I'd like the order of the variables in the "SET show_rule" statement to be the same as the order of the variables defined previously (l.129-157 yes) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104640|0 |1 is obsolete| | --- Comment #19 from Andrew Nugged <nugged@gmail.com> --- Created attachment 105985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105985&action=edit Bug 25440: Fixed list of 'show_rule' forming variables in the template In smart-rules.tt we have `SET show_rule = ...` section which filled with 'all used in the loop' variables. Because if historical reasons it seems that there are some missing, few old, and even doubled ones. This list is fixed now by: - variable names 'article_requests' and 'renewalsallowed' repeated so duplicates are removed; - 'hardduedatebefore' and 'hardduedateexact' not present in the whole site code anywhere anymore; IMPORTANT NOTE: these 'hardduedatebefore/hardduedateexact' also exists as remnants in .po-translation files, a lot. - 'note', 'hardduedatecompare', 'renewalperiod', 'rentaldiscount' template variables were missing from this 'show_rule =' checking code so they are added. Order of fields updated to match with above "SET field = ..." pack. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104636|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106300&action=edit Bug 25440: Extra duplicated call to CGI->param method removed In code CGI param 'no_auto_renewal_after_hard_limit' assigned to "$no_auto_renewal_after_hard_limit" var, and then just in the next line again variable "$no_auto_renewal_after_hard_limit" reassigned with call to same "$input->param('no_auto_renewal_after_hard_limit')". Fixed. No logic or results should be changed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104638|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106301&action=edit Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl This warning emitted: CGI::param called in list context from /admin/smart-rules.pl line 262, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at CGI.pm line 412. Explained here: https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-... And because all these params are not multi-params, so simple "scalar .." forcing for CGI->param is the fix. Changes are transparent and same values should be assigned as before, just no more warnings. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104639|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106302&action=edit Bug 25440: Fix for "uninitialized value in hash" warning in smart-rules.pl This warning emitted: Use of uninitialized value in hash element at /admin/smart-rules.pl line 569. that happened because we have NULLs in SQL results for 'categorycode' and 'itemtype' which later used as 'any' kind of category/item in the template, so for the template it passed this way: $rules->{ $r->{categorycode} }->{ $r->{itemtype} }->... but undef will stringify as "" to become a hash key ("Hashes are unordered collections of scalar values indexed by their associated string key" https://perldoc.perl.org/perldata.html), that's why "undef warning". To prevent warning here is the simple fix: $rules->{ $r->{categorycode} // '' }->{ $r->{itemtype} // '' }->... Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105059|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106303&action=edit Bug 25440: Fix for "uninitialized value in string eq" in smart-rules.pl This warning emitted: Use of uninitialized value in string eq at /admin/smart-rules.pl line 289. It is solved by one line added to exclude comparison with 'on' string when variable is 'undef'. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105063|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106304&action=edit Bug 25440: Fix for "uninitialized $maxsuspensiondays" in smart-rules.pl This warning emitted: Use of uninitialized value $maxsuspensiondays in string eq at /admin/smart-rules.pl line 257. But that not just undef-warning, there is broken logic, these two lines are mutually contradictory and goes one-by-one: $maxsuspensiondays = undef if $maxsuspensiondays eq q||; $maxsuspensiondays = '' if $maxsuspensiondays eq q||; Fix is simple: to make it '' if it comes undef. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105985|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106305&action=edit Bug 25440: Fixed list of 'show_rule' forming variables in the template In smart-rules.tt we have `SET show_rule = ...` section which filled with 'all used in the loop' variables. Because if historical reasons it seems that there are some missing, few old, and even doubled ones. This list is fixed now by: - variable names 'article_requests' and 'renewalsallowed' repeated so duplicates are removed; - 'hardduedatebefore' and 'hardduedateexact' not present in the whole site code anywhere anymore; IMPORTANT NOTE: these 'hardduedatebefore/hardduedateexact' also exists as remnants in .po-translation files, a lot. - 'note', 'hardduedatecompare', 'renewalperiod', 'rentaldiscount' template variables were missing from this 'show_rule =' checking code so they are added. Order of fields updated to match with above "SET field = ..." pack. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fixes, clear code. All works as expected and qa scripts pass. Going straight for a QA here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106388&action=edit Bug 25440: (QA follow-up) Correction for typo 'engthunit -> lengthunit Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #28 from Andrew Nugged <nugged@gmail.com> --- <3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #30 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #31 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hi all, this does not apply cleanly on 19.11.x, please rebase if you'd like me to backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25790 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25440 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 [Bug 25790] [OMNIBUS] warnings removal -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org