[Bug 22919] New: Authorities MARC Structure
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Bug ID: 22919 Summary: Authorities MARC Structure Change sponsored?: --- Product: Koha Version: 18.11 Hardware: PC OS: Linux Status: NEW Keywords: additional_work_needed Severity: trivial Priority: P3 Component: MARC Authority data support Assignee: koha-bugs@lists.koha-community.org Reporter: lovenabila@gmail.com QA Contact: testopia@bugs.koha-community.org CC: lovenabila@gmail.com Target Milestone: 18.11 Created attachment 89813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89813&action=edit Screen shown when Adding new Authority I am logged in as SuperLibrarian with all rights. When I Select Home - Authorities - New Authority - MARC Structure : It does not load the MARC form at all and the screen is blank but will show Save, Z39.50 Search, Cancel button. I tried the following: 1) Tried selecting different MARC Template (Chronological Term, Default, Personal Name, etc.) 2) If I click Save button (even the form is not showing) then it will save the record as blank (not showing any field at this point also; only blank screen saying Authority #1 - Koha will also allow me to Download Record as MARCXML - When I open MARCXML it will show me the default tags ---------------- MARCXML File <record xsi:schemaLocation="http://www.loc.gov/MARC21/slim http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd"><leader>00190 a2200097 4500</leader><controlfield tag="001">1</controlfield><controlfield tag="003">OSt</controlfield><controlfield tag="005">20190516105224.0</controlfield><controlfield tag="008">190516|| aca||aabn | a|a d</controlfield><datafield tag="040" ind1=" " ind2=" "><subfield code="a">OSt</subfield><subfield code="c">OSt</subfield></datafield><datafield tag="942" ind1=" " ind2=" "><subfield code="a">PERSO_NAME</subfield></datafield></record> ---------------------- 3) From created report If I run report listing all authorities, then it will show me records but without any main_heading. 4) I can edit the MARC Structure from Koha Administration - Authority Type 5) I tried by creating new Authority Template 6) I have multiple instances created and it works fine in all of it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Keywords|additional_work_needed | --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- I don't recreate this in 18.11 - can you check for any errors in the logs or the JS console? It may be a framework issue or something else -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #2 from Nabila <lovenabila@gmail.com> --- I created new instance with different port to run and see if there is any error while installing Web Setup. The following error was found while doing web setup under mandatory defaults: authorities_normal_marc21.sql [Tue May 28 09:52:16 2019] install.pl: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'linkid' at row 148 at /usr/share/perl5/DBIx/RunSQL.pm line 273 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Nabila from comment #2)
I created new instance with different port to run and see if there is any error while installing Web Setup.
The following error was found while doing web setup under mandatory defaults:
authorities_normal_marc21.sql
[Tue May 28 09:52:16 2019] install.pl: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'linkid' at row 148 at /usr/share/perl5/DBIx/RunSQL.pm line 273
Hi Nabila, thank you, this is very helpful. Did you pick English or another language? It might be related to your DBMS having a strict configuration: https://wiki.koha-community.org/wiki/DBMS_configuration Updating severity - if this blocks installation, it's at least normal. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #4 from Nabila <lovenabila@gmail.com> --- (In reply to Katrin Fischer from comment #3)
(In reply to Nabila from comment #2)
I created new instance with different port to run and see if there is any error while installing Web Setup.
The following error was found while doing web setup under mandatory defaults:
authorities_normal_marc21.sql
[Tue May 28 09:52:16 2019] install.pl: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'linkid' at row 148 at /usr/share/perl5/DBIx/RunSQL.pm line 273
Hi Nabila, thank you, this is very helpful. Did you pick English or another language? It might be related to your DBMS having a strict configuration: https://wiki.koha-community.org/wiki/DBMS_configuration
Updating severity - if this blocks installation, it's at least normal.
Selected Language is English. Weird thing is, that I have till now 4 separate port running 4 separate Koha setup. 1st one that I created is working properly for Authorities. Problem started with the rest. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Did you set strict_sql_modes in your koha-conf.xml file? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What is the exact version of Koha and MySQL/MariaDB are you using? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #7 from Nabila <lovenabila@gmail.com> --- (In reply to Jonathan Druart from comment #6)
What is the exact version of Koha and MySQL/MariaDB are you using?
Koha = 18.11.05.000 Perl = 5.022001 MySQL = 5.7.26 I added the STRICT_TRANS_TABLES mode in /etc/mysql/my.cnf file and /etc/mysql/mysql.conf.d/mysqld.conf -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #8 from Nabila <lovenabila@gmail.com> --- UPDATE: after setting strict_trans_table(In reply to Jonathan Druart from comment #5)
Did you set strict_sql_modes in your koha-conf.xml file?
How exactly should I do it? in <config> section? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #9 from Nabila <lovenabila@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Did you set strict_sql_modes in your koha-conf.xml file?
How should I do it? in <config> section? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #10 from Nabila <lovenabila@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Did you set strict_sql_modes in your koha-conf.xml file?
How should I do it? in <config> section? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #11 from Nabila <lovenabila@gmail.com> --- UPDATE: i changed the sql_mode as required in my.cnf files but the problem persists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90203&action=edit Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Version|18.11 |master Summary|Authorities MARC Structure |Authorities MARC Structure | |not inserted with SQL | |strict modes --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Nabila, you should *not* have the SQL strict modes turned on in production, so you should not have the strict_sql_modes config entry in your koha-conf.xml Koha code is not ready yet for that, and we are forcing the non-strict modes when we established the connnection to the DB. I do not know how you face this issue if you did not explicitly set it. However it is a bug we must fix, here is a patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nabila <lovenabila@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #14 from Nabila <lovenabila@gmail.com> --- (In reply to Jonathan Druart from comment #13)
Nabila, you should *not* have the SQL strict modes turned on in production, so you should not have the strict_sql_modes config entry in your koha-conf.xml
Koha code is not ready yet for that, and we are forcing the non-strict modes when we established the connnection to the DB. I do not know how you face this issue if you did not explicitly set it.
However it is a bug we must fix, here is a patch.
Thank you @Jonathan. It worked! I did think that it was a problem in sql file but I did not know that sql files are not in our system and also I was not able to find the authorities_normal_marc21.sql file online to find the ROW 148. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #15 from Nabila <lovenabila@gmail.com> --- I am sorry if I did something wrong while submitted last comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #16 from Nabila <lovenabila@gmail.com> --- The patch works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nabila from comment #16)
The patch works.
You should not need this patch to have Koha working correctly. You will certainly face other problems. By any chances, could you sign the patch off? https://wiki.koha-community.org/wiki/Sign_off_on_patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #18 from Nabila <lovenabila@gmail.com> --- (In reply to Jonathan Druart from comment #17)
(In reply to Nabila from comment #16)
The patch works.
You should not need this patch to have Koha working correctly. You will certainly face other problems.
By any chances, could you sign the patch off? https://wiki.koha-community.org/wiki/Sign_off_on_patches
If this patch is not supposed to run - then how do I sign it off? (Sorry, first time). I had 4 instances of Koha created on my system. The first one did not throw this error, only rest of the 3 did. If everytime MySQL and Koha setup is same. This error should not have been encountered in the first place. Yet, when error started to come for authority, the change mentioned in authorities_normal_marc21.sql file worked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #19 from Nabila <lovenabila@gmail.com> --- (In reply to Jonathan Druart from comment #17)
(In reply to Nabila from comment #16)
The patch works.
You should not need this patch to have Koha working correctly. You will certainly face other problems.
By any chances, could you sign the patch off? https://wiki.koha-community.org/wiki/Sign_off_on_patches
If I have to test the patch in Sandbox then I will have to run the Web Installer. Which Username/password should I use? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What are the differences between the 4 Koha you have installed? To sign it off you could just add your signed-off-by line at the bottom of the git commit, if you have a Koha git repo. Otherwise I will add it for you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #21 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by nabila <lovenabila@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #22 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 90346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90346&action=edit Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' Signed-off-by: nabila <lovenabila@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90346|0 |1 is obsolete| | --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90351&action=edit Bug 22919: Fix insert of authorities_normal_marc21.sql with strict SQL modes If strict SQL modes are set, the insert of authorities_normal_marc21.sql will fail. Test plan: DELETE FROM auth_subfield_structure; DELETE FROM auth_tag_structure; DELETE FROM auth_types; SET sql_mode = 'ONLY_FULL_GROUP_BY,STRICT_TRANS_TABLES,NO_ZERO_IN_DATE,NO_ZERO_DATE,ERROR_FOR_DIVISION_BY_ZERO,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION'; source /home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql You should not see any errors. Without this patch you see: ERROR 1366 (22007) at line 280 in file: '/home/vagrant/kohaclone/installer/data/mysql/en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql': Incorrect integer value: ' for column 'linkid' at row 148 ' Signed-off-by: nabila <lovenabila@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 6993 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ashwinloyal@gmail.com --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 23239 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org