[Bug 37856] New: Some SUSHI providers require the platform parameter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Bug ID: 37856 Summary: Some SUSHI providers require the platform parameter Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, michaela.sieber@kit.edu, pedro.amorim@ptfs-europe.com The harvest_sushi method produces the following URL when harvesting SUSHI data: <provider_url>/reports/<report_type>?customer_id=<customer_id>&requestor_id=<requestor_id>&api_key=<api_key>&begin_date=<begin_date>&end_date=<end_date> Some providers require the 'platform' parameter. Docs here: https://app.swaggerhub.com/apis/COUNTER/counter-sushi_5_0_api/5.0.2#/default... We need to look for a way to identify when/if a provider requires this parameter, and add it to the URL if so. The provider in question is ScienceDirect: https://registry.countermetrics.org/platform/ab4d3560-1165-491d-a67e-9359d02... The 'platform parameter required' entry is unchecked even though this provider requires it. We should consider using this to identify if the parameter is required or not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |belal.ahmadi@uwl.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171680&action=edit Bug 37856: [DONT PUSH] dbic changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171681&action=edit Bug 37856: Append platform parameter to SUSHI url if defined -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171682&action=edit Bug 37856: atomicupdate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171683&action=edit Bug 37856: Add service_platform field The change from this patch itself should be self-explanatory. Testing for this requires credentials to a specific provider. But the parameter is only added to the URL if defined. Test plan, ktd, apply patch, run: $ yarn js:build $ yarn api:bundle $ koha-plack --restart kohadev 1) Enable ERMModule 2) Create a new provider, visit: <staff_url>/cgi-bin/koha/erm/eusage/usage_data_providers/add 3) Ensure 'Service platform' now shows. Create the provider and put something in this field. 4) View the provider, ensure the field is shown, visit: <staff_url>/cgi-bin/koha/erm/eusage/usage_data_providers/1 Ensure all tests are still passing: $ cypress run --spec t/cypress/integration/ERM/DataProviders_spec.ts $ prove t/db_dependent/api/v1/erm_usage_* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37963 [Bug 37963] Improve error handling and testing of ERM eUsage SUSHI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171773&action=edit Bug 37856: Consider 'Exceptions' not being part of 'Report_Header' When fixing the issue around the missing platform parameter, we noticed this particular provider also returns 'Exceptions' as its own thing, not part of 'Report_Header', despite documentation: https://countermetrics.stoplight.io/docs/counter-sushi-api/7cp0h7n1hm2en-tr-...
From the link above, search for 'Exceptions'. Notice it should be under 'Report_Header'. Either way, this patch accounts for this possibility.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171774&action=edit Bug 37856: Consider absence of 'Report_Items' The SUSHI provider in question for this patchset also does not return any Report_Items entry. This patch accounts for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171775&action=edit Bug 37856: Add tests This is using the groundwork from bug 37963. This is testing the specific error this bug is addressing: Required parameter Platform is missing It is also testing that the error message is correctly shown as a background job report message to the user Test plan: prove t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37526 [Bug 37526] Handle redirects in SUSHI requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171680|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 171893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171893&action=edit Bug 37856: [DONT PUSH] dbic changes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171681|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 171894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171894&action=edit Bug 37856: Append platform parameter to SUSHI url if defined Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171682|0 |1 is obsolete| | --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 171895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171895&action=edit Bug 37856: atomicupdate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171683|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 171896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171896&action=edit Bug 37856: Add service_platform field The change from this patch itself should be self-explanatory. Testing for this requires credentials to a specific provider. But the parameter is only added to the URL if defined. Test plan, ktd, apply patch, run: $ yarn js:build $ yarn api:bundle $ koha-plack --restart kohadev 1) Enable ERMModule 2) Create a new provider, visit: <staff_url>/cgi-bin/koha/erm/eusage/usage_data_providers/add 3) Ensure 'Service platform' now shows. Create the provider and put something in this field. 4) View the provider, ensure the field is shown, visit: <staff_url>/cgi-bin/koha/erm/eusage/usage_data_providers/1 Ensure all tests are still passing: $ cypress run --spec t/cypress/integration/ERM/DataProviders_spec.ts $ prove t/db_dependent/api/v1/erm_usage_* Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171773|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 171897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171897&action=edit Bug 37856: Consider 'Exceptions' not being part of 'Report_Header' When fixing the issue around the missing platform parameter, we noticed this particular provider also returns 'Exceptions' as its own thing, not part of 'Report_Header', despite documentation: https://countermetrics.stoplight.io/docs/counter-sushi-api/7cp0h7n1hm2en-tr-...
From the link above, search for 'Exceptions'. Notice it should be under 'Report_Header'. Either way, this patch accounts for this possibility.
Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171774|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 171898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171898&action=edit Bug 37856: Consider absence of 'Report_Items' The SUSHI provider in question for this patchset also does not return any Report_Items entry. This patch accounts for that. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171775|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 171899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171899&action=edit Bug 37856: Add tests This is using the groundwork from bug 37963. This is testing the specific error this bug is addressing: Required parameter Platform is missing It is also testing that the error message is correctly shown as a background job report message to the user Test plan: prove t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- I've signed off, but wasn't really able to test steps 3 and 4 for the 'Add service_platform' patch, and the 'Consider 'Exceptions' not being part of 'Report_Header'' patch. The tests all pass, and as I understand it the tests mock these. Testing notes (using KTD): 1. Run databaseupdate and restart_all, after applying the patches and running yarn js:build and yarn api:bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171893|0 |1 is obsolete| | --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172040&action=edit Bug 37856: [DONT PUSH] dbic changes Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171894|0 |1 is obsolete| | --- Comment #17 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172042&action=edit Bug 37856: Append platform parameter to SUSHI url if defined Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171895|0 |1 is obsolete| | --- Comment #18 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172043&action=edit Bug 37856: atomicupdate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171896|0 |1 is obsolete| | --- Comment #19 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172044&action=edit Bug 37856: Add service_platform field The change from this patch itself should be self-explanatory. Testing for this requires credentials to a specific provider. But the parameter is only added to the URL if defined. Test plan, ktd, apply patch, run: $ yarn js:build $ yarn api:bundle $ koha-plack --restart kohadev 1) Enable ERMModule 2) Create a new provider, visit: <staff_url>/cgi-bin/koha/erm/eusage/usage_data_providers/add 3) Ensure 'Service platform' now shows. Create the provider and put something in this field. 4) View the provider, ensure the field is shown, visit: <staff_url>/cgi-bin/koha/erm/eusage/usage_data_providers/1 Ensure all tests are still passing: $ cypress run --spec t/cypress/integration/ERM/DataProviders_spec.ts $ prove t/db_dependent/api/v1/erm_usage_* Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171897|0 |1 is obsolete| | --- Comment #20 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172045&action=edit Bug 37856: Consider 'Exceptions' not being part of 'Report_Header' When fixing the issue around the missing platform parameter, we noticed this particular provider also returns 'Exceptions' as its own thing, not part of 'Report_Header', despite documentation: https://countermetrics.stoplight.io/docs/counter-sushi-api/7cp0h7n1hm2en-tr-...
From the link above, search for 'Exceptions'. Notice it should be under 'Report_Header'. Either way, this patch accounts for this possibility.
Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171898|0 |1 is obsolete| | --- Comment #21 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172046&action=edit Bug 37856: Consider absence of 'Report_Items' The SUSHI provider in question for this patchset also does not return any Report_Items entry. This patch accounts for that. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171899|0 |1 is obsolete| | --- Comment #22 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172047&action=edit Bug 37856: Add tests This is using the groundwork from bug 37963. This is testing the specific error this bug is addressing: Required parameter Platform is missing It is also testing that the error message is correctly shown as a background job report message to the user Test plan: prove t/db_dependent/Koha/BackgroundJob/ErmSushiHarvester.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #23 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172048&action=edit Bug 37856: (QA follow-up) Tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate, | |rel_24_05_candidate --- Comment #24 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Thanks for QA, Nick. Adding 24.05 and 23.11 release candidate keywords as this improves how the SUSHI response is handled widening the pool of providers Koha is able to work with. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The way the database update outputs messages is a bit non-standard. I fixed the messages (we are not mentioning the bug number every time for example), but I didn't change the structure. I think what it should have done was printing different messages in case of the column already existing or not, but the "Done" seems not quite right. Not terribly important overall, just noting for future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #27 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172155&action=edit Bug 37856: Fix existing test A service_platform value was being randomly to 'service_platform' as is a new attribute. Assign undef to that to fix existing test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #28 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172156&action=edit Bug 37856: Add new test to test platform is correctly added to build_url prove t/db\_dependent/Koha/ERM/EUsage/UsageDataProvider.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #29 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Added 2 follow-up test patches to fix existing tests and add a new one. Adding additional_work_needed keyword to notify Katrin of these 2 follow-ups. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #30 from Jonathan Druart <jonathan.druart@gmail.com> --- 19 say_success( $out, "Done" ); Is this expected? "Done"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #31 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172215&action=edit Bug 37856: Update atomicupdate messages (In reply to Katrin Fischer from comment #25)
The way the database update outputs messages is a bit non-standard. I fixed the messages (we are not mentioning the bug number every time for example), but I didn't change the structure. I think what it should have done was printing different messages in case of the column already existing or not, but the "Done" seems not quite right. Not terribly important overall, just noting for future.
(In reply to Jonathan Druart from comment #30)
19 say_success( $out, "Done" );
Is this expected? "Done"?
The original patch: https://github.com/Koha-Community/Koha/commit/2e4b1ca42f7a940e8329ed860dda10... Had: say_success( $out, "Bug 37856 - Done" ); I wanted to provide indication that the update of that particular bug was done, regardless if a change on the database happened or not. This is clearly causing confusion, this is now showing messages more in line with standard I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kamalesh.jp@gmail.com --- Comment #32 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- *** Bug 37058 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Too many merge conflicts in ErmSushiHarvester.t for me to solve, not knowing how this code works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #34 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass (lukeg) from comment #33)
Too many merge conflicts in ErmSushiHarvester.t for me to solve, not knowing how this code works.
Looking here to provide patches for 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 --- Comment #35 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Lucas Gass (lukeg) from comment #33)
Too many merge conflicts in ErmSushiHarvester.t for me to solve, not knowing how this code works.
Last follow-up patch here wasn't applying (and wasn't pushed to main) so I made it obsolete. The reason you're getting the conflicts is because bug 37963 needs to be applied before this one, I believe. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds a new release notes| |"platform" field to ERM's | |usage data providers, | |allowing the harvest of | |SUSHI usage data from | |providers that require this | |parameter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #36 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | --- Comment #37 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 Note that in 24.05.x the commit message has wrong bug id : 5eed8269b2 Bug 37526: DBIC Schema updates This may need to be fixed in release notes ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to oldoldstable |RESOLVED --- Comment #38 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Bug 37856 depends on bug 37963, which changed state. Bug 37963 Summary: Improve error handling and testing of ERM eUsage SUSHI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37963 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting --- Comment #39 from David Nind <david@davidnind.com> --- Changed status to "Needs documenting" - the new field needs documenting in the ERM sectuon of the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37856 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jvinke@austinseminary.edu --- Comment #40 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- *** Bug 41196 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org