https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Summary|Something wrong with |Something wrong with |KOHA_HOME |KOHA_HOME (?) --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- debian/templates/koha-conf-site.xml.in: <intranetdir>/usr/share/koha/intranet/cgi-bin</intranetdir> debian/koha-common.default:KOHA_HOME="/usr/share/koha" debian/scripts/koha-functions.sh: KOHA_HOME=$(run_safe_xmlstarlet $instancename intranetdir) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- KOHA_HOME can be: * /usr/share/koha # pkg install * /kohadevbox/koha # dev install (or another path ofc, the one in the intranetdir config) Weird thing: * debian/scripts/koha-plack 392 adjust_paths_dev_install $name 393 export DEV_INSTALL 394 export KOHA_HOME 395 PERL5LIB=$PERL5LIB:$KOHA_HOME/installer:$KOHA_HOME/lib/installer On a pkg install we don't have /usr/share/koha/installer or /usr/share/koha/lib/installer On a dev instal we don't have /kohadevbox/koha/lib -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- I was wondering what KOHA_HOME was about yesterday... Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is unset. Then in kohadevbox and koha-testing-docker, an environmental variable can be set to a dev install location? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to David Cook from comment #4)

I was wondering what KOHA_HOME was about yesterday...

Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is unset.

Then in kohadevbox and koha-testing-docker, an environmental variable can be set to a dev install location?

We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think adding more variables will help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #7 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- KOHA_HOME is the place where intranetdir code is placed, I got this with grep:

koha-functions.sh: KOHA_HOME=$(run_safe_xmlstarlet $instancename intranetdir)

So using KOHA_HOME is favourable in my opinion to be able to support installations with different installation paths. The user should be able to change only the paths in koha-conf.xml and stuff should work, now without this variable things don't work so the original patch should be extended to include also koha-plack and maybe other scripts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25586 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #8)

(In reply to Jonathan Druart from comment #6)

...

(In reply to David Cook from comment #4)

...

I was wondering what KOHA_HOME was about yesterday...

Maybe KOHA_HOME should be set to "/usr/share/koha" only if KOHA_HOME is unset.

Then in kohadevbox and koha-testing-docker, an environmental variable can be set to a dev install location?

We already have 'dev_install' and 'intranetdir' in koha-conf. I don't think adding more variables will help.

This is not a new variable.

KOHA_HOME is not (hence this bug report). David's suggestion was to add a new one. At least it's what I understood. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.