[Bug 9993] New: On editing basket group delivery place resets to logged in branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Bug ID: 9993 Summary: On editing basket group delivery place resets to logged in branch Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de When editing a basket group the selected options for delivery address don't match what's saved in the database. To reproduce: 1) Create a new basket group, set delivery place to "-" 2) Add a delivery address in the text box. 3) Save. 4) Edit basket group - delivery place is set to my current branch instead of "-" Comment from Fridolyn on this behaviour (bug 7996): Creating a new basketgroup and editing one uses the same page and operation : acqui/basketgroup.pl?op=add&booksellerid=x&basketgroupid=x So when you edit an existing basketgroup, selected branches are librarian branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7449 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- There should definitly be a syspref for choosing if we want to take the branch of the user, or the branch of the basket! Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I see the current behaviour as a bug. If I select a specific value and save that, Koha should respect that and on edit show what has been selected before and saved to the database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Marjorie Barry-Vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Actually the code confirms it's a feature: # determine default billing and delivery places depending on librarian homebranch and existing basketgroup data The following code could do the trick, but not sure if it's needed % git diff diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl index 9c57f69..b3fa964 100755 --- a/acqui/basketgroup.pl +++ b/acqui/basketgroup.pl @@ -254,12 +254,12 @@ if ( $op eq "add" ) { $freedeliveryplace = $basketgroup->{freedeliveryplace}; $template->param( closedbg => ($basketgroup ->{'closed'}) ? 1 : 0); } else { + # determine default billing and delivery places depending on librarian homebranch + my $borrower = GetMember( ( 'borrowernumber' => $loggedinuser ) ); + $billingplace = $borrower->{'branchcode'}; + $deliveryplace = $borrower->{'branchcode'}; $template->param( closedbg => 0); } - # determine default billing and delivery places depending on librarian homebranch and existing basketgroup data - my $borrower = GetMember( ( 'borrowernumber' => $loggedinuser ) ); - $billingplace = $billingplace || $borrower->{'branchcode'}; - $deliveryplace = $deliveryplace || $borrower->{'branchcode'}; my $branches = C4::Branch::GetBranchesLoop( $billingplace ); $template->param( billingplaceloop => $branches ); On the other hand I agree the behavior is odd :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I'd agree to 'feature' if it only preselected before saving it the first time - but it should display what is saved in the database when you open it again later - even if I have left the field empty on purpose. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Otherwise... we should not offer the empty option in the first place! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org