[Bug 34845] New: GetBasketGroupAsCSV.t is failing if the DB has been upgraded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 Bug ID: 34845 Summary: GetBasketGroupAsCSV.t is failing if the DB has been upgraded Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: fridolin.somers@biblibre.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 28327 Blocks: 34841 The syspref needs to be mocked, or the tests are failing. To recreate: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-upgrade-only kohadev-koha@kohadevbox:koha$ prove t/db_dependent/Acquisition/GetBasketGroupAsCSV.t t/db_dependent/Acquisition/GetBasketGroupAsCSV.t .. 1/2 # Failed test 'CSV should be generated' # at t/db_dependent/Acquisition/GetBasketGroupAsCSV.t line 62. # got: '"Account number";"Basket name";"Order number";"Author";"Title";"Publisher";"Publication year";"Collection title";"ISBN";"Quantity";"RRP tax included";"RRP tax excluded";"Discount";"Estimated cost tax included";"Estimated cost tax excluded";"Note for vendor";"Entry date";"Bookseller name";"Bookseller physical address";"Bookseller postal address";"Contract number";"Contract name";"Basket group delivery place";"Basket group billing place";"Basket delivery place";"Basket billing place"# ;"";1;"King, Stephen";"Test Record";"";;"";;3;0.00;0.00;;0.00;0.00;"";2016-01-02;"my vendor";"vendor address";"";;"";"";"";"";""# ' # expected: '"Account number","Basket name","Order number","Author","Title","Publisher","Publication year","Collection title","ISBN","Quantity","RRP tax included","RRP tax excluded","Discount","Estimated cost tax included","Estimated cost tax excluded","Note for vendor","Entry date","Bookseller name","Bookseller physical address","Bookseller postal address","Contract number","Contract name","Basket group delivery place","Basket group billing place","Basket delivery place","Basket billing place"# ,"",1,"King, Stephen","Test Record","",,"",,3,0.00,0.00,,0.00,0.00,"",2016-01-02,"my vendor","vendor address","",,"","","","",""# ' # Failed test 'CSV should not fail if biblio does not exist' # at t/db_dependent/Acquisition/GetBasketGroupAsCSV.t line 73. # got: '"Account number";"Basket name";"Order number";"Author";"Title";"Publisher";"Publication year";"Collection title";"ISBN";"Quantity";"RRP tax included";"RRP tax excluded";"Discount";"Estimated cost tax included";"Estimated cost tax excluded";"Note for vendor";"Entry date";"Bookseller name";"Bookseller physical address";"Bookseller postal address";"Contract number";"Contract name";"Basket group delivery place";"Basket group billing place";"Basket delivery place";"Basket billing place" # ;"";1;"";"";"";;"";;3;0.00;0.00;;0.00;0.00;"";2016-01-02;"my vendor";"vendor address";"";;"";"";"";"";"" # ' # expected: '"Account number","Basket name","Order number","Author","Title","Publisher","Publication year","Collection title","ISBN","Quantity","RRP tax included","RRP tax excluded","Discount","Estimated cost tax included","Estimated cost tax excluded","Note for vendor","Entry date","Bookseller name","Bookseller physical address","Bookseller postal address","Contract number","Contract name","Basket group delivery place","Basket group billing place","Basket delivery place","Basket billing place" # ,"",1,"","","",,"",,3,0.00,0.00,,0.00,0.00,"",2016-01-02,"my vendor","vendor address","",,"","","","","" # ' # Looks like you failed 2 tests of 2. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28327 [Bug 28327] System preference CSVdelimiter special case for tabulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34841 [Bug 34841] The test suite is failing is the DB has been upgraded -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156084&action=edit Bug 34845: Fix GetBasketGroupAsCSV.t is CSVDelimiter is not ',' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA Assignee|fridolin.somers@biblibre.co |jonathan.druart+koha@gmail. |m |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34043 CC| |fridolin.somers@biblibre.co | |m Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34043 [Bug 34043] Improve translation of CSV header templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34845 --- Comment #3 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 34043 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org