[Bug 41079] New: Checkboxes visible on the batch patron modification results view
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Bug ID: 41079 Summary: Checkboxes visible on the batch patron modification results view Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org The table is not built correctly and the DT's saveState behaviour cannot work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188305&action=edit Bug 41079: Turn on bKohaColumnsUseNames for the batch patron modification results table A table cannot use the table settings if columns are displayed depending on sysprefs. Additionally DT's saveState does not work correctly if some columns are shown/hidden from one screen to another. We must add data-colname and turn bKohaColumnsUseNames on for this table. Also note that there were several discrepancies between the table structure and the number of columns in the yaml file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188306&action=edit Bug 41079: Force visibility for columns depending on sysprefs If two sysprefs are disabled we must hide the two related columns. We should also force the visibility of the checkboxes: on the first screen (op=show/edition) they must be displayed, on the result screen (op=show_results) the must be hidden. Test plan: 1. Create a report to see some patrons: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%2' 2. Run report and select 'Batch operations ...' 3. Batch patron modification => Notice that the table has the checkboxes in the first column => The table is sorted by cardnumber 4. Perform the modification => Notice that the result table does not have the checkboxes in the first column => The table is still sorted by cardnumber Additional tests: 1. If the logged in user is superlibrarian then the columns "Password expiration date" and "Protected" are displayed 2. Play with the table's settings and columns visibility to confirm that they are working correctly (they were not before this patch set) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41065 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41065 [Bug 41065] Batch patron modification results are no longer displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188305|0 |1 is obsolete| | Attachment #188306|0 |1 is obsolete| | --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188329&action=edit Bug 41079: Turn on bKohaColumnsUseNames for the batch patron modification results table A table cannot use the table settings if columns are displayed depending on sysprefs. Additionally DT's saveState does not work correctly if some columns are shown/hidden from one screen to another. We must add data-colname and turn bKohaColumnsUseNames on for this table. Also note that there were several discrepancies between the table structure and the number of columns in the yaml file. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188330&action=edit Bug 41079: Force visibility for columns depending on sysprefs If two sysprefs are disabled we must hide the two related columns. We should also force the visibility of the checkboxes: on the first screen (op=show/edition) they must be displayed, on the result screen (op=show_results) the must be hidden. Test plan: 1. Create a report to see some patrons: SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%2' 2. Run report and select 'Batch operations ...' 3. Batch patron modification => Notice that the table has the checkboxes in the first column => The table is sorted by cardnumber 4. Perform the modification => Notice that the result table does not have the checkboxes in the first column => The table is still sorted by cardnumber Additional tests: 1. If the logged in user is superlibrarian then the columns "Password expiration date" and "Protected" are displayed 2. Play with the table's settings and columns visibility to confirm that they are working correctly (they were not before this patch set) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Straightforward, moving to PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41079 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 41065 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org