[Bug 7394] New: Broken detail page for last link from result page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Bug #: 7394 Summary: Broken detail page for last link from result page Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: ian.walls@bywatersolutions.com Created attachment 7013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7013 wrong display on opac detail page Found a weird bug, where the detail page wrongly uses the result page XSLT. The title shows formatted as link and availability information is displayed. (see screenshot) To reproduce: 1) OPACXSLTDetailsDisplay = ON 2) OPACXSLTResultDisplay = ON 3) Search for anything with more than 20 results. 4) Open the last record (normally 20th) of your the result page. 5) Go to the second reult page, same happens here for the last link (40th) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_4 |master Severity|major |critical -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-03 06:47:44 UTC --- Its the browse results thing that is causing this. Which reminds me, that whole thing should be wrapped in a system preference, as well as fixed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-03 06:58:57 UTC --- Created attachment 7021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7021 Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2012-01-03 07:00:15 UTC --- Fix for problem, will do 2 follow ups 1 to add a syspref, 1 to shift all the code to a module instead of in the opac-detail.pl But please signoff and push the fix without waiting on the follow ups -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr, | |salva@masmedios.com --- Comment #4 from Frédéric Demians <frederic@tamil.fr> 2012-01-03 07:09:34 UTC --- Related to bug 6483. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6483 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7021|0 |1 is obsolete| | --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2012-01-03 07:16:44 UTC --- Created attachment 7022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7022 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7022|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-03 07:16:58 UTC --- Created attachment 7023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7023 [SIGNED-OFF] Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Detail page for last record on result page now shows up correctly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7023|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-03 07:20:07 UTC --- Created attachment 7024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7024 [SIGNED-OFF] Bug 7394 : Fixing scoping issue with XSLT processing. Also bailing out early for 404 inestead of doing unnessecary processing Signed-off-by: Frédéric Demians <f.demians@tamil.fr> I can confirm the bug and the solution. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Second sign-off from me, patch fixes display of detail page for last record on a result page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #8 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-03 18:31:57 UTC --- Moves code to different area of script to avoid scoping issues. Fixes issue without introducing any new complexities. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed AssignedTo|oleonard@myacpl.org |chris@bigballofwax.co.nz --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-06 11:34:38 UTC --- patch pushed, pleast test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED CC| |cnighswonger@foundations.ed | |u Version|rel_3_6 |rel_3_4 --- Comment #10 from Chris Nighswonger <cnighswonger@foundations.edu> 2012-01-21 04:37:28 UTC --- This patch does not apply cleanly to 3.4.x. Please rebase and attach a new patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-21 07:47:18 UTC --- The 'browse results' was a new feature in 3.6 and is not in 3.4 (afaik). The problem should not appear there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Version|rel_3_4 |rel_3_6 Resolution| |FIXED --- Comment #12 from Chris Nighswonger <cnighswonger@foundations.edu> 2012-01-21 12:42:24 UTC --- TNX! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7394 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arslanone@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org