[Bug 14584] New: Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Bug ID: 14584 Summary: Encoding broken with system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: philippe.blouin@inlibro.com QA Contact: testopia@bugs.koha-community.org This bug is related to #12411 and #11944, since then pushed to master. Whatever we enter with accents in NoLoginInstructions is displayed as gibberish because it ends up being encoded TWICE. It was not doing that before. My solution is to modify Koha::Template::Plugin::Koha::Preference. It might be naive and missing all the changes done in aforementionned bugs, but this does fix my immediate issue in 3.20 and master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Created attachment 41113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41113&action=edit Bug 14584 - Encoding broken with system preferences This prevents double-encoding the strings from the database's systempreferences. STEP 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "Hélo médames é mècieüx" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |francois.charbonnier@inlibr | |o.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12411 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |philippe.blouin@inlibro.com Patch complexity|--- |Trivial patch Severity|enhancement |minor See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11944 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Actually I would say that the line could only be replaced with a call to C4::Context->preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Well, I'm fine with that, but isn't it just making this function useless? I think what you're suggesting is what it was before the latest change. I just presumed there had been a need for that "encode('UTF-8'" call... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Blou from comment #3)
Well, I'm fine with that, but isn't it just making this function useless? I think what you're suggesting is what it was before the latest change. I just presumed there had been a need for that "encode('UTF-8'" call...
Not useless, it can be called from the templates. Back 1 year ago, from bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944." So bug 12411 should not have been pushed to master or 11944 should have reverted the changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Assignee|philippe.blouin@inlibro.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41113|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 41632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41632&action=edit Bug 14584: Encoding broken with system preferences The pref are double encoded.
From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944."
They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "Hélo médames é mècieüx" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Should be backported to 3.20, not 3.18! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41632|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 41641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41641&action=edit [SIGNED OFF] Bug 14584: Encoding broken with system preferences The pref are double encoded.
From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944."
They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "Hélo médames é mècieüx" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41641|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42183&action=edit [PASSED QA] Bug 14584: Encoding broken with system preferences The pref are double encoded.
From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944."
They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "Hélo médames é mècieüx" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Works as expected. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #11 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- (In reply to Jonathan Druart from comment #6)
Should be backported to 3.20, not 3.18!
Seems to have been pushed in 3.18.11 despite Jonathan's comment -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org