http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 28754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28754&action=edit Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I still have concerns about overloading the tables with information - see my comment on bug 11865. I think only very few libraries are using the granularity of permissions, owners and creators that acq offers right now. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- By the way, this has nothing to do with permissions of the acq module. Our customer only wants to see "who has created this order line", which is not possible actually in current master. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #2)

I still have concerns about overloading the tables with information - see my comment on bug 11865.

I am not sure this is relevant. I submitted a patch for that (bug 10212). Everyone will be able to display, for each page, the columns they want - and this only with a small piece of code. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Hi Paola, have you created the order line being logged in with a real user (not the mysql user) ? Does this user have a firstname and a surname ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28754|0 |1 is obsolete| | --- Comment #10 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28943&action=edit Bug 12395: Save order line's creator -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28943|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 30128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30128&action=edit [PASSED QA] Bug 12395: Save order line's creator New MySQL column: aqorders.createdby Creator's name is displayed on order's receive pages (acqui/orderreceive.pl and acqui/parcel.pl) On acqui/orderreceive.pl it replace the name of basket's creator On acqui/parcel.pl, to avoid adding more data in the table of pending orders, it is shown in a popup like MARC and Card views Test plan: 1/ Run updatedatabase.pl 2/ Create a new order and go to the receipt page (acqui/parcel.pl) 3/ Click on "Order" link in column "More" (previously "View record") 4/ A javascript popup should appear with your name in it. Close the popup. 5/ Click on "Receive" link 6/ Your name should appear in front of "Created by" label, to the right of the page. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31410&action=edit Bug 12395 [QA Followup] * Rename createdby to created_by * Fix GPL versioning -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- I was going to push this patch set to the MM acq branch. But since I added a follow-up, I prefer that RM push them. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is the change to NewOder, that has since been rewriten and moved to Koha::Orders: + if (not defined $orderinfo->{createdby}) { + my $userenv = C4::Context->userenv; + if ($userenv) { + $orderinfo->{createdby} = $userenv->{number}; + } + } + -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31410|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33838&action=edit Bug 12395 [QA Followup] * Rename createdby to created_by * Fix GPL versioning -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #22 from Jonathan Druart <jonathan.druart@biblibre.com> --- Julian, Could you please take a look: I tried to rebase it but it does not seem to work. It would be great to have a couple of tests in t/db_dependent/Acquisition/NewOrder.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33838|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35770&action=edit Bug 12395 [QA Followup] Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35772&action=edit Bug 12395: Add unit test to check created_by is correctly set -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #28 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patch against master 3.19.00.010 head 13675 Applying: Bug 12395: Save order line's creator Using index info to reconstruct a base tree... <stdin>:234: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql Failed to merge in the changes. Patch failed at 0001 Bug 12395: Save order line's creator So I pass the patch to "Patch doesn't apply" status. NB. All the first 3 patches relate to updatedatabase. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35770|0 |1 is obsolete| | --- Comment #30 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35780&action=edit Bug 12395 [QA Followup] Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35772|0 |1 is obsolete| | --- Comment #32 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 35782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35782&action=edit Bug 12395: Add unit test to check created_by is correctly set Rebased on master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Julian. I've applied the patches against master 3.19.00.010 head 13240. After having run updatedatabase, the new "created_by" field of the already existing aqorders was set to the basket's creator code, as expected. On acqui/parcel.pl, in "More" column, for each already existing aqorder, on "Order" link this Creator's name appeared, as required. On acqui/orderreceive.pl, receiving an already existing order, I saw this Creator's name in front of "Created by:" label, as required. For new orders, in DB the "created_by" field of aqorder record was set to NULL (ERROR). On acqui/parcel.pl, in "More" column, on "Order" link I saw none "Creator" (ERROR). On acqui/orderreceive.pl, I saw "No name" in front of "Created by:" label, to the right of the page (ERROR). So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #35 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Julian Maurice from comment #34)

Are you logged in with a real user (not the database user) ? The user was not a database user [it was the same user OK on already-existing-order].

Did you run misc/devel/update_dbix_class_files.pl ? Thanks, Julian, I run the command but the problem was not solved. So I keep the status "Failed QA".

[NB. If the above command be required, the test plan could be updated about it.] Now the already-existing-order had not the Creator's name on receiving (ERROR). [The already-existing-order' More was still OK.] See also: prove t/db_dependent/Acquisition/NewOrder.t t/db_dependent/Acquisition/NewOrder.t .. 1/8 # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 91. # got: undef # expected: '42' # Looks like you failed 1 test of 8. t/db_dependent/Acquisition/NewOrder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests Test Summary Report ------------------- t/db_dependent/Acquisition/NewOrder.t (Wstat: 256 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=8, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.83 cusr 0.08 csys = 0.92 CPU) Result: FAIL I hope this error can help. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #37 from Julian Maurice <julian.maurice@biblibre.com> --- This patch should fix the test. I don't understand why it doesn't work for you... :/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #39 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Julian Maurice from comment #36)

Created attachment 35864 [details] [review] Bug 12395: Fix call to set_userenv in unit tests

Sorry, the 5-th patch doesn't fix: prove t/db_dependent/Acquisition/NewOrder.t t/db_dependent/Acquisition/NewOrder.t .. 1/8 # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 91. # got: undef # expected: '42' # Looks like you failed 1 test of 8. t/db_dependent/Acquisition/NewOrder.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests Test Summary Report ------------------- t/db_dependent/Acquisition/NewOrder.t (Wstat: 256 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=1, Tests=8, 1 wallclock secs ( 0.00 usr 0.01 sys + 0.83 cusr 0.07 csys = 0.91 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #41 from Paola Rossi <paola.rossi@cineca.it> --- Thank you very much, Julian! [in the meanwhile I've installed some not-required perl modules.] (In reply to Julian Maurice from comment #40):

could you check that Koha/Schema/Result/Aqorder.pm contains an entry about created_by ? yes, it does! The file Koha/Schema/Result/Aqorder.pm in my branch has been updated:

cat -n Koha/Schema/Result/Aqorder.pm | grep 'created_by' 97 =head2 created_by 273 "created_by",

could you check that you have the aqorders.created_by field in your database ? yes, I have; and now the "created_by" field is OK, either for existing orders or for new orders!

Now the "More" option is OK either for existing orders or for new orders! Whilst the orderreceive.pl still shows "Created by: No name" in both the cases of orders (ERROR). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #43 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patches against master 3.19.00.010 head 13189. I've upgraded the DB. I've run misc/devel/update_dbix_class_files.pl : it was OK. The DB was OK for existing and new orders. On parcel.pl the "More" Order was OK for existing and new orders. (In reply to Julian Maurice from comment #42)

So you have the correct borrowernumber in aqorders.created_by, yes,

but "No name" is displayed on orderreceive.pl ?

yes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Paola, I think I have found your problem. If the firstname (or surname) was not filled, "no name" was display on this screen. The last patch should fix that. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #47 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #44)

Created attachment 36063 [details] [review] Bug 12395: Display created_by even if surname is missing on receiving

On receiving orders, "no name" was displayed if the surname of creator was not filled. The firstname should be displayed.

The surname is mandatory ("Required") for a patron/borrower/creator. So I've changed the patch's subject to: Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35779|0 |1 is obsolete| | --- Comment #48 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 36075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36075&action=edit Bug 12395: Save order line's creator Thanks, Julian and Jonathan. I've applied the patches against master 3.19.00.011 head 13728. I've upgraded the DB. Then I've run misc/devel/update_dbix_class_files.pl on my branch. Everything was OK as required by the test plan (see comment #1). So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35781|0 |1 is obsolete| | --- Comment #50 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 36077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36077&action=edit Bug 12395: Update aqorders.created_by with aqbasket.authorisedby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35864|0 |1 is obsolete| | --- Comment #52 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 36079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36079&action=edit Bug 12395: Fix call to set_userenv in unit tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting on this... - QA script OK - Code review OK ------------------- 1) New test is failing for me: not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if not given # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 91. # got: undef # expected: '42' # Looks like you failed 1 test of 8. 2) Why only display the order line creator during the receive process, but not on the order pages? We can only see the basket creator there. 3) On the order receive page: Maybe we should write "Ordered by" instead of "Created by"? 4) On the parcel page: You change the display for the unreceived order lines table, but the received orders miss the link to the order. I think it would be better to be consistent and also to keep the | for separating the links from each other. 5) The popup window appers 'unstyled' - for example it appears in a much bigger than the rest serif font for me. Maybe something for a follow up? Could you please take a look? Especially at the failing test and 4) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36078|0 |1 is obsolete| | --- Comment #56 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40133&action=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36080|0 |1 is obsolete| | --- Comment #58 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40135&action=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40133|0 |1 is obsolete| | --- Comment #60 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40137&action=edit Bug 12395: Add unit test to check created_by is correctly set Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40135|0 |1 is obsolete| | --- Comment #62 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40139&action=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I think it would have to be basket.pl currently - but we already got a lot of information there. I think it's not a blocker. What I could think of as enh: - create a "view" page for an order line that is still accessible after the basket has been closed (similar to suggestions) and show it there. - add colvis to the basket page, so the library can decide if it wants to display it or not. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #66 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 40161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40161&action=edit [Follow-up] Bug 12395 - Make received orders table consistent with pending orders table (links of More column), - Change "Created by" with "Ordered by" in receive page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #67 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the last new patch is ok as a QA follow-up - shifting back to signed off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #69 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) xt/tt_valid.t was failing, I fixed it in my follo-up, please check. 1..3 ok 1 - TT syntax: not using TT directive within HTML tag not ok 2 - <body> tag with id and class attributes # Failed test '<body> tag with id and class attributes' # at xt/tt_valid.t line 91. # Files list: # intranet-tmpl/prog/en/modules/acqui/showorder.tt: 12 ok 3 - Token received same as original put on stack # Looks like you failed 1 test of 3. 2) Some of the title="MARC" should be title="Card" - fixed in my follow-up, please check. 3) t/db_dependent/Acquisition/NewOrder.t fails, please fix (blocker) :( I think it's not only the test - in my testing the creator is not saved for newly created orders. Only the 'migrated' orders have created_by set in the database. 1..8 ok 1 - Inserting an order with no params returns undef and croaks ok 2 - Inserting an order with no budget_id returns undef and croaks with expected error message ok 3 - Inserting an order with no biblionumber returns undef and croaks with expected error message ok 4 - Inserting an order with no basketno returns undef and croaks with expected error message ok 5 - Inserting an order with no quantity returns undef and croaks with expected error message ok 6 - Koha::Acquisition::Order->insert set quantityreceivedto 0 if undef is given ok 7 - Koha::Acquisition::Order->insert set entrydate to today not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if not given # Failed test 'Koha::Acquisition::Order->insert set created_by to logged in user if not given' # at t/db_dependent/Acquisition/NewOrder.t line 93. # got: undef # expected: '42' # Looks like you failed 1 test of 8. 4) The 'look' of the new modal for order information is slightly off, especially font and font-size are unusual. Would be nice to be more consistent with Koha's look and feel here. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 4) I think using the standard font and font-size would already help - it looked very different than the page in the background to me. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.