[Bug 27465] New: Add column visibility to the admin/cities.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Bug ID: 27465 Summary: Add column visibility to the admin/cities.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org We want admin/cities.pl to be using as much DT features as possible to be used as an example. We must add the column visibility. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2746 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2746 [Bug 2746] Modify a patron, and set an empty expiry date create an error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|2746 |27402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2746 [Bug 2746] Modify a patron, and set an empty expiry date create an error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27402 [Bug 27402] Add column filtering to the Datatables REST API wrapper -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115250&action=edit Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27467 [Bug 27467] Provide a static URL for tables -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Pascale Nalon <pascale.nalon@ensmp.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon@ensmp.fr --- Comment #2 from Pascale Nalon <pascale.nalon@ensmp.fr> --- Test on PTFS sandbox : First step is OK : Columns can be hide or show, by clicking in the popup "columns" in admin/cities.pl page Second step works partially : - some default settings can be set from the admin/columns_settings.pl#cities page. - Not toggled functionality works on the admin/cities.pl page, the choosen columns doesn't shown anymore in the popup - BUT hidding columns by default doesn't work in the admin/cities.pl page : the chosen columns are ever shown, even after refreshing or reloading the page, or cleaning cookies and cache of the internet browser. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Pascale Nalon <pascale.nalon@ensmp.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pascale.nalon@mines-pariste | |ch.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- I have the same problem as Pascale, the TableSettings do not hide the columns. Also to be consistent the 'Actions' column should include: cannot_be_toggled: 1 cannot_be_modified: 1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115250|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 119233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119233&action=edit Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28096 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Lucas Gass from comment #3)
I have the same problem as Pascale, the TableSettings do not hide the columns.
Will be fixed by bug 28096.
Also to be consistent the 'Actions' column should include:
cannot_be_toggled: 1 cannot_be_modified: 1
Done. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28096 [Bug 28096] API datatables wrapper does not deal correctly with hidden columns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119233|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 119238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119238&action=edit Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119238|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119799&action=edit Bug 27465: Add column visibility to admin/cities.pl We want admin/cities.pl to be using as much DT features as possible to be used as an example. Test plan: Add some cities, go to admin/cities.pl confirm that you can show/hide column. Go to the tables settings admin page and confirm that you can set some default settings from there. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27465 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 27402 and Bug 28096 both not in 20.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org