[Bug 10265] New: 830 needs spaces in opac display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Bug ID: 10265 Summary: 830 needs spaces in opac display Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com Created attachment 18179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18179&action=edit series display The subfields of the 830 are showing up without spaces in the series tag on the opac. See attached -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18180&action=edit marc for 830 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support Version|3.10 |master Assignee|oleonard@myacpl.org |gmcharlt@gmail.com Summary|830 needs spaces in opac |830 needs spaces in XSLT |display |display --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- I can reproduce this in master in both the OPAC and staff client but where this is happening in the xsl file I do not know. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18239&action=edit Bug 10265: Add missing spaces between label and content in XSLT view (780/785) To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- This patch doesn't solve the problem of the 830. Applied and both the staff and the OPAC have the spaces still missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nicole, I attached the patch to the wrong bug - still working on this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18239|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 18239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18239 Bug 10265: Add missing spaces between label and content in XSLT view (780/785)
From 0a9055d0c36ef12d19da91b970f725dba2f6a6b5 Mon Sep 17 00:00:00 2001 From: Katrin Fischer <Katrin.Fischer.83@web.de> Date: Sun, 19 May 2013 12:16:16 +0200 Subject: [PATCH] Bug 10265: Add missing spaces between label and content in XSLT view (780/785)
To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now. --- .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 3 ++- .../prog/en/xslt/MARC21slim2OPACDetail.xsl | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl index aeaa797..98d5742 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl @@ -741,6 +741,7 @@ <span class="label">Separated from:</span> </xsl:when> </xsl:choose> + <xsl:text> </xsl:text> <xsl:variable name="f780"> <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">at</xsl:with-param> @@ -800,8 +801,8 @@ <xsl:when test="@ind2=8"> <span class="label">Changed back to:</span> </xsl:when> - </xsl:choose> + <xsl:text> </xsl:text> <xsl:variable name="f785"> <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">at</xsl:with-param> diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl index 5130e8b..e1e6546 100644 --- a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl @@ -847,6 +847,7 @@ <span class="label">Separated from:</span> </xsl:when> </xsl:choose> + <xsl:text> </xsl:text> <xsl:variable name="f780"> <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">a_t</xsl:with-param> @@ -907,8 +908,8 @@ <xsl:when test="@ind2=8"> <span class="label">Changed back to:</span> </xsl:when> - </xsl:choose> + <xsl:text> </xsl:text> <xsl:variable name="f785"> <xsl:call-template name="subfieldSelect"> <xsl:with-param name="codes">a_t</xsl:with-param> -- 1.7.9.5
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some notes for reproducing this: - you need to make p and n visible in the MARC editor, to make it possible to catalog the attached example. - You also have to make sure you have a matching 490 field with the first indicator = 1, else the information is pulled from the 490 field. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem is somewhere in the part template that deals with the n and p subfields. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Do we only want spaces? Or is there some other punctuation needed between those fields? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> --- Spaces should be sufficient, the cataloger should have entered the other punctuation: http://www.loc.gov/marc/bibliographic/bd830.html -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The function chops off the other punctuation as far as I can see... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I will do some testing, it's a pretty old part of the XSLT code, maybe we can just do it completely different now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer@bsz-bw.de |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't have time to work on this right now - maybe someone else wants to take it on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org