[Bug 16787] New: 'Too many holds' message appears inappropriately and is missing data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Bug ID: 16787 Summary: 'Too many holds' message appears inappropriately and is missing data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com bug 11250 changed the holds message to be and if,elsif loop, falling through to catch the first appropriate message bug 13116 changed the reporting from CanItemBeReserved causing tooManyHolds to trigger when no holds are allowed A side effect is that 'maxreserves' is only passed to the template when there are too many reserves, but the too many reserves message is called when no holds are available To recreate: Set maxreserves to 50 Set some item type to allow 0 holds Attempt to place a hold on a record with that itemtype Message will be "Too many holds: [Firstname Surname] can only place a maximum of total holds." Message should be "[Firstname Surname] cannot place any holds on these items." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 52652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52652&action=edit Bug 16787 - 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds To test: 1 - Set an item type to allow no holds 2 - Attempt to place a hold for a patron 3 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 4 - Try placing a multihold with the record above and a holdable record, message should end "...cannot place holds on some of these titles' items" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- needs unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #3 from George Williams (NEKLS) <george@nekls.org> --- Tried to test in the sandbox but I kept getting an error message saying "CONFLICT (content): Merge conflict in C4/Reserves.pm" George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11160 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Hugh Rundle <hughr@brimbank.vic.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hughr@brimbank.vic.gov.au --- Comment #4 from Hugh Rundle <hughr@brimbank.vic.gov.au> --- Nick have you made any further progress on this? This bug is definitely confusing and we'd love it resolved at my library. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19540 CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52652|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68894&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds To test: 1 - Set an item type to allow no holds 2 - Attempt to place a hold for a patron 3 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 4 - Try placing a multihold with the record above and a holdable record, message should end "...cannot place holds on some of these titles' items" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 68895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68895&action=edit Bug 16787: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david.bourgault@inlibro.com --- Comment #7 from David Bourgault <david.bourgault@inlibro.com> --- Is there a step missing form the test plan? I applied the patch, change my Circulation rules to set no holds for All/All (I have no other rules for my test patron's category) and tried to place a hold but got the message "No available items.", but I can see it as available on the OPAC detail page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Bourgault from comment #7)
Is there a step missing form the test plan? I applied the patch, change my Circulation rules to set no holds for All/All (I have no other rules for my test patron's category) and tried to place a hold but got the message "No available items.", but I can see it as available on the OPAC detail page.
Sorry, I did miss a detail, this patch only affects the staff side, not the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |axelle.clarisse@univ-amu.fr -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #9 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- conflicts: ~/d/koha ❯❯❯ git bz apply 16787 Bug 16787 - 'Too many holds' message appears inappropriately and is missing data 68894 - Bug 16787: 'Too many holds' message appears inappropriately and is missing data 68895 - Bug 16787: Add tests Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 16787: 'Too many holds' message appears inappropriately and is missing data Using index info to reconstruct a base tree... M C4/Reserves.pm M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt M reserve/request.pl Falling back to patching base and 3-way merge... Auto-merging reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 16787: 'Too many holds' message appears inappropriately and is missing data The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16787-Too-many-holds-message-appears-inappropr-CKsj5R.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68894|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72827&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds To test: 1 - Set an item type to allow no holds 2 - Attempt to place a hold for a patron 3 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 4 - Try placing a multihold with the record above and a holdable record, message should end "...cannot place holds on some of these titles' items" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68895|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72828&action=edit Bug 16787: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72889&action=edit Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record To test: 1 - Set 'Holds per record' to 0 for some itemtype/patorn combination 2 - Attempt to plac a hold 3 - Will see 'Too many..' 4 - Apply patch 5 - Try again 6 - Should now see 'No holds..' 7 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> --- tested on biblibre sandbox 11 : - Set maxreserves to 50 - Set 'Holds per record' to 0 for some itemtype/patron combination - Attempt to place a hold No message in any case appears -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #14 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- i've tried to install it on a sandbox : CONFLICT (content): Merge conflict in reserve/request.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt The previous status was "failed QA" so there's also to review the patch as it doesn't seem to function correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72827|0 |1 is obsolete| | Attachment #72828|0 |1 is obsolete| | Attachment #72889|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91146&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds To test: 1 - Set an item type to allow no holds 2 - Attempt to place a hold for a patron 3 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 4 - Try placing a multihold with the record above and a holdable record, message should end "...cannot place holds on some of these titles' items" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91147&action=edit Bug 16787: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91148&action=edit Bug 16787: (follow-up) Return noReservesAllowed if 0 holds per record To test: 1 - Set 'Holds per record' to 0 for some itemtype/patorn combination 2 - Attempt to plac a hold 3 - Will see 'Too many..' 4 - Apply patch 5 - Try again 6 - Should now see 'No holds..' 7 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 91149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91149&action=edit Bug 16787: Rebase fixes and updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Status|Needs Signoff |Patch doesn't apply --- Comment #19 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Patch doesn't apply: Applying: Bug 16787: 'Too many holds' message appears inappropriately and is missing data Applying: Bug 16787: Add tests Using index info to reconstruct a base tree... M t/db_dependent/Holds.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds.t CONFLICT (content): Merge conflict in t/db_dependent/Holds.t error: Failed to merge in the changes. Patch failed at 0001 Bug 16787: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 benjamin.r.philbrook@lmco.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.r.philbrook@lmco.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Benjamin Daeuber <bdaeuber@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91146|0 |1 is obsolete| | Attachment #91147|0 |1 is obsolete| | Attachment #91148|0 |1 is obsolete| | Attachment #91149|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 96152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96152&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96152|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 97403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97403&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in t/db_dependent/Holds.t CONFLICT (content): Merge conflict in C4/Reserves.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks like you will need to add the new statuses to the enum of club_holds_to_patron_holds.error_code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97403|0 |1 is obsolete| | --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99949&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #25 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 99950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99950&action=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Missing signoff here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100951&action=edit Bug 16787: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Adding the DBIC changes to help testing in a sandbox. AM123, Lyon3, are you still interested in this bugfix? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99949|0 |1 is obsolete| | Attachment #99950|0 |1 is obsolete| | Attachment #100951|0 |1 is obsolete| | --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101473&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101474&action=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #31 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101475&action=edit Bug 16787: DO NOT PUSH - Shcema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #32 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101475|0 |1 is obsolete| | --- Comment #33 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 101895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101895&action=edit Bug 16787: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23404 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #34 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 23404 also fixed a itemtype issue in holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #35 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
This patch also fixes a FIXME about using effective_itemtype to fetch item rules
Looks like there are several places where GetBranchItemRule() is called with $item->itype instead of $item->effective_itemtype. Maybe we should create a new Bug for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
4 - The message will be 'Too many holds'
Is that valid if my messages are the following?
Too many holds: $EXAMPLE $USER can only place a maximum of 0 total holds.
It's for the «itemtype to allow no holds» it's a book went to circ rules and added a rule: all branches, all categories, type books: Holds allowed (total): 0 The other record I get
Too many holds for this record: $EXAMPLE $USER can only place a maximum of 0 hold(s) on this record.
It's for the «Holds per record' to 0 for another itemtype/patron combination» it for "music" and I added a rule; all branches, all categories, type music: Holds per record (count): 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #37 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101473|0 |1 is obsolete| | Attachment #101474|0 |1 is obsolete| | Attachment #101895|0 |1 is obsolete| | --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107793&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "No holds allowed: [Firstname Surname] cannot place holds on any of these items" 7 - Try placing a multihold with either record above and a holdable record, message should end "...cannot place holds on some of these titles' items" 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107794&action=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107795&action=edit Bug 16787: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #41 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm getting errors when trying to place club holds. - create rule that says 0 holds allowed for a specific category and item - create a club - add 2 patrons to club -- one of the category from your rule, one of a category that can hold that item type - attempt to place club hold for an item of the item type covered by your rule - get error "Something went wrong, check Koha logs for details." When placing individual holds, I'm not seeing a message of "No holds allowed: [Firstname Surname] cannot place holds on any of these items." Instead, I get "Cannot place hold: No items are available to be placed on hold." I'm happy enough with that message, but it's not what the test plan indicated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107793|0 |1 is obsolete| | Attachment #107794|0 |1 is obsolete| | Attachment #107795|0 |1 is obsolete| | --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114675&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114676&action=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 114677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114677&action=edit Bug 16787: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #45 from Séverine Queune <severine.queune@bulac.fr> --- Needs rebase once more... CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Auto-merging C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 16787: 'Too many holds' message appears inappropriately and is missing data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114675|0 |1 is obsolete| | Attachment #114676|0 |1 is obsolete| | Attachment #114677|0 |1 is obsolete| | --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119279&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119280&action=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119281&action=edit Bug 16787: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119279|0 |1 is obsolete| | Attachment #119280|0 |1 is obsolete| | Attachment #119281|0 |1 is obsolete| | --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119335&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t Rebase - Fix test expectation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #50 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119336&action=edit Bug 16787: Add noReservesAllowed to club holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #51 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119337&action=edit Bug 16787: DO NOT PUSH - Schema updates -- You are receiving this mail because: You are watching all bug changes.
From that page, select a patron and submit. The following page will warn you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #52 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119616&action=edit Screenshot showing the behavior before the patch I see a difference in how the holds process behaves before and after this patch and I'm not sure it's intentional. It seems to be a regression. It happens when I try to access the multi-hold process by linking directly to the hold page. The search results page will prevent me from submitting multiple titles for holds if one of them can't be placed on hold, but I can use a URL: /cgi-bin/koha/reserve/request.pl?biblionumbers=2329/2596/4796/4439/4896/2655/2740/ ...where one of those biblionumbers is a title with all non-holdable items. that one of the titles you submitted has no items which can be placed on hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119617&action=edit Screenshot showing the behavior after the patch After the patch, there is no warning. I know that I'm describing a workflow that isn't one which will be followed under regular circumstances (accessing the page via a handmade URL), but I think the page should still be performing this check. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #54 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #52)
I see a difference in how the holds process behaves before and after this patch and I'm not sure it's intentional.
This is not a problem after all because I had my item-level_itypes preference switched and I didn't realize it. After testing with item-level_itypes ON and OFF, the behavior is correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119335|0 |1 is obsolete| | Attachment #119336|0 |1 is obsolete| | Attachment #119337|0 |1 is obsolete| | --- Comment #55 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119619&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t Rebase - Fix test expectation Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119620&action=edit Bug 16787: Add noReservesAllowed to club holds Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #57 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119621&action=edit Bug 16787: DO NOT PUSH - Schema updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #58 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119622&action=edit Bug 16787: (follow-up) Fix check to ensure reasons are passed to template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119622|0 |1 is obsolete| | --- Comment #59 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119623&action=edit Bug 16787: (follow-up) Fix check to ensure reasons are passed to template Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119619|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119738&action=edit Bug 16787: 'Too many holds' message appears inappropriately and is missing data This patch alters C4/Reserves.pm to pass back 'noReservesAllowed' when allowedreserves=0. This allows passing to the user an appropriate message about the availability of items for holds This patch also fixes a FIXME about using effective_itemtype to fetch item rules To test: 1 - Set one itemtype to allow no holds 2 - Set 'Holds per record' to 0 for another itemtype/patron combination 3 - Create or find 2 records, each with items only of the itemtypes above 3 - Attempt to place a hold for a patron on each record above 4 - The message will be 'Too many holds' 5 - Apply patch and repeat 6 - Message should be "Cannot place hold: no item are available to be placed on hold" 7 - Try placing a multihold with either record above and a holdable record, message should end "Cannot place hold on some items' 8 - prove -v t/db_dependent/Holds.t Rebase - Fix test expectation Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119620|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119739&action=edit Bug 16787: Add noReservesAllowed to club holds Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119621|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119740&action=edit Bug 16787: DO NOT PUSH - Schema updates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119623|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 119741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119741&action=edit Bug 16787: (follow-up) Fix check to ensure reasons are passed to template Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Tests pass, QA script is happy.. functionality is improved. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #65 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- At first glance I'd say noReservesAllowed is missing from ERROR_MAP, could you confirm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #66 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 119942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119942&action=edit Bug 16787: (follow-up) Add noReservesAllowed to ERROR_MAP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #67 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #67)
Pushed to master for 21.05, thanks to everybody involved!
Delayed for a bit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We have a test failing, please fix. # Failed test 'Too many reserves' # at t/db_dependent/ILSDI_Services.t line 372. # got: 'noReservesAllowed' # expected: 'tooManyReserves' # Looks like you failed 1 test of 8. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 120009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120009&action=edit Bug 16787: (follow-up) Add and adjust ILSDI tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Follow-up pushed to master, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 --- Comment #72 from Fridolin Somers <fridolin.somers@biblibre.com> --- Should we backported to 20.11.x ? Or is it to much behavior change for a stable version ? My opinion is more on no backport, reserves is really sensitive. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org