[Bug 20075] New: Change authority hidden attribute in sql installer files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Bug ID: 20075 Summary: Change authority hidden attribute in sql installer files Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com See bug 18811 and 20074. We should not expect 0, 1 and 8. But only 0 and -5. (Note that it is just used as a boolean, so not a big deal.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |RM_priority --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This needs to be pushed along with bug 20074 otherwise the new installs will contain wrong values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1)
This needs to be pushed along with bug 20074 otherwise the new installs will contain wrong values.
These 'wrong' values will be interpreted correctly. Not really a problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20074 [Bug 20074] Auth_subfield_structure changes hidden attribute -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72198&action=edit Bug 20075: Adjust installer files for de-DE up to pl-PL We are replacing the values -5 or 8 here by 1 for the hidden field in auth_subfield_structure. Note that 1 is mainly used in MARC21 and -5 in UNIMARC. Since it is a boolean, I choose here for keeping 0 and 1. The value 8 was only used for field 942 in MARC21 files. The value -5 was replaced in en/marcflavour/unimarc/mandatory/authorities_normal_unimarc.sql it-IT/marcflavour/unimarc/necessari/authority_framework.sql pl-PL/marcflavour/unimarc/mandatory/authorities_normal_unimarc.sql NOTE: The french unimarc files fr-FR/marcflavour/unimarc_complet/Obligatoire/autorite_default.sql fr-FR/marcflavour/unimarc_complet/Obligatoire/autorites_norme_unimarc.sql fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/autorites_norme_unimarc.sql seem to display all fields, since hidden is 0 everywhere. Test plan: Test a new install in one of the languages. Or run the sql script on an empty database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72199&action=edit Bug 20075: Update installer files for ru-RU Instead of the very laborious task of going thru all these files line by line, I am adding a statement at the very end to correct hidden values. Test plan: Run a new Russian install or run a few files on an empty database. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72200&action=edit Bug 20075: Update installer files for uk-UA Instead of the very laborious task of going thru all these files line by line, I am adding a statement at the very end to correct hidden values. Test plan: Run a new Ukrainian install or run a few files on an empty database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72201&action=edit Bug 20075: Replace hidden -5 by 1 in data and interface In the preceding patches we chose for 1 instead of -5. The interface should move that direction too obviously. Test plan: Test toggling between Show all and Hide all in the auth frameworks. Run the db rev. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|major |minor Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72201|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 72201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72201 Bug 20075: Replace hidden -5 by 1 in data and interface Moved to 20074 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05 to have it along with bug 20074. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org