[Bug 14272] New: Allow OPAC to show a single news item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Bug ID: 14272 Summary: Allow OPAC to show a single news item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: xarragon@gmail.com QA Contact: testopia@bugs.koha-community.org Bugs 14246, 14247 and 14248 adds functionality to make the news module mimic simple blog functionality. As a first step, we need to be able to let users select a single news entry and display it on a page. Later patches will allow comments and listing all news posts by a specific user. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |xarragon@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Component|Tools |Staff Client -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #1 from Martin Persson <xarragon@gmail.com> --- Created attachment 45721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45721&action=edit Bug 14272: OPAC show single news This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nes item heading should be clickable. * When clicked only that item should be shown. * The URL should contain a new parameter named 'id'. * When 'id' is present, only a single news item should show. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15385 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 [Bug 15385] News archive -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #2 from Martin Persson <xarragon@gmail.com> --- There is a security issue in this version; the ID supplied from the URL parameter is not checked for expiry. This means people can watch old, expired news by changing the ID. This is known as 'object reference bug'. Whether it is a problem or not is another matter. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45721|0 |1 is obsolete| | --- Comment #3 from Martin Persson <xarragon@gmail.com> --- Created attachment 45740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45740&action=edit Bug 14272: OPAC show single news This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nes item heading should be clickable. * When clicked only that item should be shown. * The URL should contain a new parameter named 'news_id'. * When 'news_id' is present, only a single news item should show. Updates: * Renamed URL parameter and local variables with 'news_' prefix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45740|0 |1 is obsolete| | --- Comment #4 from Martin Persson <xarragon@gmail.com> --- Created attachment 45741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45741&action=edit Bug 14272: OPAC show single news This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nes item heading should be clickable. * When clicked only that item should be shown. * The URL should contain a new parameter named 'news_id'. * When 'news_id' is present, only a single news item should show. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #5 from Martin Persson <xarragon@gmail.com> --- Created attachment 45818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45818&action=edit Bug 14272: Show single news item (backend) Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45741|0 |1 is obsolete| | --- Comment #6 from Martin Persson <xarragon@gmail.com> --- Created attachment 45820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45820&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45818|0 |1 is obsolete| | --- Comment #7 from Martin Persson <xarragon@gmail.com> --- Created attachment 45845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45845&action=edit Bug 14272: Show single news item (backend) Updates: Date formatting added to get_opac_new() Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #8 from Martin Persson <xarragon@gmail.com> --- Created attachment 45846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45846&action=edit Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Martin Persson <xarragon@gmail.com> --- I just realized that the ability show arbitrary news items by ID poses a vulnerability; you can view stuff with visbility other than the OPAC. This would leak internal news to whomever has access to the OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45845|0 |1 is obsolete| | --- Comment #10 from Martin Persson <xarragon@gmail.com> --- Created attachment 45935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45935&action=edit Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45820|0 |1 is obsolete| | --- Comment #11 from Martin Persson <xarragon@gmail.com> --- Created attachment 45936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45936&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Persson <xarragon@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45936|0 |1 is obsolete| | --- Comment #12 from Martin Persson <xarragon@gmail.com> --- Created attachment 45937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45937&action=edit Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #13 from Marc Véron <veron@veron.ch> --- Hi Martin, I like this feature. Questions: - When I display the single item, the news header has still the same link (on itself). Could this be changed to a link back to where I came from? - The single display shows the html from syspref OpacMainUserBlock. Is that necessary or could the single view display the contents of the news item only? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org