[Bug 23825] New: Object.t is failing - Exception not caught
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Bug ID: 23825 Summary: Object.t is failing - Exception not caught Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Something weird here: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/Object.t t/db_dependent/Koha/Object.t .. 3/11 # Failed test 'Exception thrown correctly' # at t/db_dependent/Koha/Object.t line 359. # expecting: Koha::Exceptions::Object::BadValue # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'wrong_value' for column `koha_kohadev`.`borrowers`.`lastseen` at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 156 # ) # Looks like you failed 1 test of 1. # Failed test 'Bad value tests' # at t/db_dependent/Koha/Object.t line 363. # Looks like you failed 1 test of 16. Not on Jenkins It's the following exception's message that is not caught correctly by the regex: DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'wrong_value' for column `koha_kohadev`.`borrowers`.`lastseen` at row 1 at /home/vagrant/kohaclone/Koha/Object.pm line 156 Note the backticks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23770 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- FWIW I get the test passed with: - elsif( $_->{msg} =~ /Incorrect (?<type>\w+) value: '(?<value>.*)' for column '(?<property>\w+)'/ ) { + elsif( $_->{msg} =~ /Incorrect (?<type>\w+) value: '(?<value>.*)' for column (?<property>`\w+)/ ) { But I guess it will make it failed for someone else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94401&action=edit Bug 23825: Koha/Object.t might fail on a backtick If the SQL error message contains a backtick instead of a regular quote, the regex for throwing an exception did not work. Example: Incorrect datetime value: 'wrong_value' for column `koha_master`.`borrowers`.`lastseen` Note the backtics where the regex contains a regular quote. This patch makes it more flexible: it allows one \W character before the column name, even optional. Test plan: Run Koha/Object.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #1)
FWIW I get the test passed with:
- elsif( $_->{msg} =~ /Incorrect (?<type>\w+) value: '(?<value>.*)' for column '(?<property>\w+)'/ ) { + elsif( $_->{msg} =~ /Incorrect (?<type>\w+) value: '(?<value>.*)' for column (?<property>`\w+)/ ) {
But I guess it will make it failed for someone else.
Yeah but we can make it a bit more flexible. See my patch. Could you QA it ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving to SO: trivial change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94654&action=edit Bug 23825: Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marcel, I do not think it is correct. I have added some tests (they should not be there, I would have expected t/Koha/Exceptions.t to test that part). However I am not sure about the property. What was it before? table.column or only column? Anyway, now it's the DB name, which is obviously wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm Will have a look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
Marcel, I do not think it is correct. I have added some tests (they should not be there, I would have expected t/Koha/Exceptions.t to test that part). However I am not sure about the property. What was it before? table.column or only column? Anyway, now it's the DB name, which is obviously wrong.
You're right about the db name. But previously it did not work either. Apart from the quote, it also picked the first word (so the database). I will parse the whole thing into the property field. Hang on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94401|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94661&action=edit Bug 23825: Koha/Object.t might fail on a backtick If the SQL error message contains a backtick instead of a regular quote, the regex for throwing an exception did not work. Example: Incorrect datetime value: 'wrong_value' for column `koha_master`.`borrowers`.`lastseen` Note the backtics where the regex contains a regular quote. This patch makes it more flexible: it allows one \W character before the column name, even optional. Test plan: Run Koha/Object.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94654|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94662&action=edit Bug 23825: Add tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Changed 'is' to 'like' with regex since we also have the db name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do we know to root of the issue? Why do we have those tests failing suddenly? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #11)
Do we know to root of the issue? Why do we have those tests failing suddenly?
Trigger for this report was the See also. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #12)
(In reply to Jonathan Druart from comment #11)
Do we know to root of the issue? Why do we have those tests failing suddenly?
Trigger for this report was the See also.
Yes, but it was not related. The issue existed before these patches were pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13)
(In reply to Marcel de Rooy from comment #12)
(In reply to Jonathan Druart from comment #11)
Do we know to root of the issue? Why do we have those tests failing suddenly?
Trigger for this report was the See also.
Yes, but it was not related. The issue existed before these patches were pushed.
OK. There are two things: [1] Your second patch here introduces using the captured names of the regex like property. Which actually had the wrong value in the first place, but it was not used yet. So undetected. [2] On the see also report I noted that the regex in sub store did not work. Probably due to a difference between MySQL and MariaDB in using regular quotes or backtics. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #14)
(In reply to Jonathan Druart from comment #13)
(In reply to Marcel de Rooy from comment #12)
(In reply to Jonathan Druart from comment #11)
Do we know to root of the issue? Why do we have those tests failing suddenly?
Trigger for this report was the See also.
Yes, but it was not related. The issue existed before these patches were pushed.
OK. There are two things:
[1] Your second patch here introduces using the captured names of the regex like property. Which actually had the wrong value in the first place, but it was not used yet. So undetected. [2] On the see also report I noted that the regex in sub store did not work. Probably due to a difference between MySQL and MariaDB in using regular quotes or backtics.
Marcel, I think we should not display the DB name in the message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94803&action=edit Bug 23825: (QA follow-up) Remove database name As requested on comment15. Test plan: Run t/db_dependent/Koha/Object.t again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94803|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 94804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94804&action=edit Bug 23825: (QA follow-up) Remove database name As requested on comment15. Test plan: Run t/db_dependent/Koha/Object.t again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm having trouble reproducing this issue. Can you elaborate on the MySQL/MariaDB versions you are testing in? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #18)
I'm having trouble reproducing this issue. Can you elaborate on the MySQL/MariaDB versions you are testing in?
Thx for trying. mysql -v Server version: 10.4.4-MariaDB-1:10.4.4+maria~bionic mariadb.org binary distribution Running in a Docker container btw. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 10.4.8-MariaDB-1:10.4.8+maria~stretch for me. Note that I upgraded using a specific repo (to get the latest), before (last week) I had the one packaged for Stretch and got the same failure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I've now updated Jenkins to test a broader range of DB servers, but I've stuck to those that ship by default with our chosen supported OS's.. and as such we still won't be catching a DB server this new.. should we do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #21)
I've now updated Jenkins to test a broader range of DB servers, but I've stuck to those that ship by default with our chosen supported OS's.. and as such we still won't be catching a DB server this new.. should we do you think?
Dont think so as to Jenkins personally. But this report actually only is about the type of quotes used in an error message, adds tests and improves the regex. So I do not really understand why this keeps hanging.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Downgrading from Major as this only affects very new DBMS versions which the majority of people will not be running. Having said that, so long as it doesn't break tests on the current stable DBMS versions then I don't have a problem with pushing it. I've not tested this yet myself, but if someone here can verify the tests continue to work with MySQL5.5, MariaDB10.1 and MariaDB10.3 then this feels OK to push at this point. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 10.4.8-MariaDB-1:10.4.8+maria~stretch master: fail with patches: ok 10.1.41-MariaDB-0+deb9u1 master: ok with patches: fail # Failed test 'Column should be the expected one' # at t/db_dependent/Koha/Object.t line 413. # 'lastseen' # doesn't match '(?^u:borrowers\.lastseen)' # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95044&action=edit Bug 23825: table name is not always displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- With this last patch I got the tests passing for both 10.4.8-MariaDB-1:10.4.8+maria~stretch and 10.1.41-MariaDB-0+deb9u1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95044|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 95053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95053&action=edit Bug 23825: table name is not always displayed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94661|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95402&action=edit Bug 23825: Koha/Object.t might fail on a backtick If the SQL error message contains a backtick instead of a regular quote, the regex for throwing an exception did not work. Example: Incorrect datetime value: 'wrong_value' for column `koha_master`.`borrowers`.`lastseen` Note the backtics where the regex contains a regular quote. This patch makes it more flexible: it allows one \W character before the column name, even optional. Test plan: Run Koha/Object.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94662|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95403&action=edit Bug 23825: Add tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Changed 'is' to 'like' with regex since we also have the db name. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94804|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95404&action=edit Bug 23825: (QA follow-up) Remove database name As requested on comment15. Test plan: Run t/db_dependent/Koha/Object.t again Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95053|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 95405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95405&action=edit Bug 23825: table name is not always displayed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for the perseverance here guys, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24507 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #34 from Victor Grousset/tuxayo <victor@tuxayo.net> --- While testing the advertised "Experimental MariaDB 10.3 support" for 19.05.x, it turns out that this patch applied and fix two failure. Will try to backport for 19.11.13 For the record the fixed failures are: kohadev-koha@665e4031f5cf:/kohadevbox/koha$ time prove -r t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Koha/Object.t t/db_dependent/Circulation/MarkIssueReturned.t .. 2/4 DBD::mysql::st execute failed: Incorrect datetime value: 'bad_date' for column `koha_kohadev`.`issues`.`returndate` at row 1 [for Statement "UPDATE `issues` SET `returndate` = ? WHERE ( `issue_id` = ? )" with ParamValues: 0='bad_date', 1=252] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. # Failed test 'An exception is thrown on bad date' # at t/db_dependent/Circulation/MarkIssueReturned.t line 181. # expecting: Koha::Exceptions::Object::BadValue # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'bad_date' for column `koha_kohadev`.`issues`.`returndate` at row 1 at /kohadevbox/koha/Koha/Object.pm line 157 # ) # Looks like you failed 1 test of 3. t/db_dependent/Circulation/MarkIssueReturned.t .. 3/4 # Failed test 'Manually pass a return date' # at t/db_dependent/Circulation/MarkIssueReturned.t line 185. t/db_dependent/Circulation/MarkIssueReturned.t .. 4/4 # Looks like you failed 1 test of 4. t/db_dependent/Circulation/MarkIssueReturned.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests t/db_dependent/Koha/Object.t .................... 7/12 # Failed test 'Exception thrown correctly' # at t/db_dependent/Koha/Object.t line 359. # expecting: Koha::Exceptions::Object::BadValue # found: DBIx::Class::Exception (DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect datetime value: 'wrong_value' for column `koha_kohadev`.`borrowers`.`lastseen` at row 1 at /kohadevbox/koha/Koha/Object.pm line 157 # ) # Looks like you failed 1 test of 1. # Failed test 'Bad value tests' # at t/db_dependent/Koha/Object.t line 363. # Looks like you failed 1 test of 16. t/db_dependent/Koha/Object.t .................... 10/12 # Failed test 'store() tests' # at t/db_dependent/Koha/Object.t line 366. # Looks like you failed 1 test of 12. t/db_dependent/Koha/Object.t .................... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests Test Summary Report ------------------- t/db_dependent/Circulation/MarkIssueReturned.t (Wstat: 256 Tests: 4 Failed: 1) Failed test: 3 Non-zero exit status: 1 t/db_dependent/Koha/Object.t (Wstat: 256 Tests: 12 Failed: 1) Failed test: 10 Non-zero exit status: 1 Files=2, Tests=16, 13 wallclock secs ( 0.05 usr 0.01 sys + 9.84 cusr 1.82 csys = 11.72 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00, 19.05.12 released in| | --- Comment #35 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Good news: Backported to 19.05.x branch for 19.05.12 Thanks Tomas for the additional analysis :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org