[Bug 29711] New: Release date not passed as ISO to about.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Bug ID: 29711 Summary: Release date not passed as ISO to about.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org When parsing the teams.yaml file, the release date is (correctly) parsed from epoch into a DateTime, but the $KohaDates filter expects 'iso' formatted dates, and stringifying the 'dt' object leads to non-comformant datetime format. To test: 1. On current master 2. Point your staff interface to the About page => FAIL: It explodes because of date formats -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 [Bug 29403] dt_from_string should fail if passed and rfc3339 formatted string when 'iso' is selected as dateformat -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128627&action=edit Bug 29711: Pass release date in ISO to about.tt This patch makes the date be converted into ISO format so it is correctly handled by the KohaDates TT filter. To test: 1. Point your browser to the about page => FAIL: It explodes: Template process failed: undef error - The given date (2022-05-22T00:00:01) does not match the date format (iso) 2. Apply this patch 3. Restart: $ koha-plack --restart kohadev 4. Repeat 1 => SUCCESS: It doesn't explode, shows the right date! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This is really ugly... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I meant, not your patch :) But what we need to do. That is plain wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29718 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- I can't replicate this on master and using KTD. Does this only apply for a specific version? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Bug 29711 depends on bug 29403, which changed state. Bug 29403 Summary: dt_from_string should fail if passed more data than expected for the format https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Nind from comment #4)
I can't replicate this on master and using KTD. Same for me. And I dont see where this date is used.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30718 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- No idea why this has been magically fixed.. If there is something to clean, it will be on bug 30718. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29711 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #6)
No idea why this has been magically fixed..
DateTime magician, I summon theeeeee -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org