[Bug 28985] New: Negative rental amounts can be saved but not enforced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Bug ID: 28985 Summary: Negative rental amounts can be saved but not enforced Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: nick@bywatersolutions.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In item types, one can enter a negative amount for a rental charge. Koha allows this, saves the value, and shows it to you in admin. However, that value gets ignored at checkout. On the one hand, I can see weird use cases for giving patrons credits for checking out items. On the other hand, it would be a lot simpler to just not allow negative values to get set in the first place. Whichever way we go, we should pursue consistency and not let users enter values that don't get used. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 124758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124758&action=edit Bug 28985: Force positive numbers for itemtype charge fields This patch adds a min attribute to the fields on this page and adds other cost related fields to validator To test: 1 - Apply patch 2 - Browse to Administration->Item types 3 - Edit or create an item type 4 - Attempt to place a negative or non numeric value in: Daily rental charge Hourly rental charge Default replacement cost Processing fee 5 - You should not be able to -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124758|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 124761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124761&action=edit Bug 28985: Force positive numbers for itemtype charge fields This patch adds a min attribute to the fields on this page and adds other cost related fields to validator To test: 1 - Apply patch 2 - Browse to Administration->Item types 3 - Edit or create an item type 4 - Attempt to place a negative or non numeric value in: Daily rental charge Hourly rental charge Default replacement cost Processing fee 5 - You should not be able to Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124761|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 124798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124798&action=edit Bug 28985: Force positive numbers for itemtype charge fields This patch adds a min attribute to the fields on this page and adds other cost related fields to validator To test: 1 - Apply patch 2 - Browse to Administration->Item types 3 - Edit or create an item type 4 - Attempt to place a negative or non numeric value in: Daily rental charge Hourly rental charge Default replacement cost Processing fee 5 - You should not be able to Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | CC| |joonas.kylmala@iki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it is in 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,21.11.11 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28985 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org