https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 153790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153790&action=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Must also apply bug 34332 - fixed a syntax error for the pos email template To test: 1. Configure your Koha to enable the point of sale system (i.e. enable syspref, set up a register, set up an item to sell). 2. Complete a transaction in the POS system. 3. Click on the “Email receipt” button next to the “Print receipt” option and enter an email address and confirm that the email is sent. 4. Check the “Tendered” field. It is showing up as 0.00 and not reflecting the actual amount that was tendered. 5. Apply patch 6. Repeat steps 2 & 3 7. The emailed receipt is now showing the correct tendered amount. 8. Sign off! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154343|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 154344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154344&action=edit Bug 34340: Changed "Tendered" to the correct input id which is "Collected" Must also apply bug 34332 - fixed a syntax error for the pos email template To test: 1. Configure your Koha to enable the point of sale system (i.e. enable syspref, set up a register, set up an item to sell). 2. Complete a transaction in the POS system. 3. Click on the “Email receipt” button next to the “Print receipt” option and enter an email address and confirm that the email is sent. 4. Check the “Tendered” field. It is showing up as 0.00 and not reflecting the actual amount that was tendered. 5. Apply patch 6. Repeat steps 2 & 3 7. The emailed receipt is now showing the correct tendered amount. 8. Sign off! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Needed to set up KTD so that email could be sent.[1] 2. For the updated notice to appear, I needed to do a reset_all then setup POS again. I'm not sure how this will affect upgrades, or if there is a way for updated notices to be applied - does this require a database update as well? 3. In additional, while this does fix the problem, all the other fields in the email notice are empty.[2] This was the case before the patch was applied. Does this need a separate bug to fix this? I have also included the notice as it is for me after the patch in KTD.[3] [1] To test sending emails using a Google account, edit /etc/koha/sites/kohadev/koha-conf.xml file and add this configuration near the end (where <user_name> = your Google email address; <password> = your APP password, not your Google account password): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>GOOGLEACCOUNTUSER</user_name> <password>GOOGLEAPPPASSWORD</password> <debug>1</debug> </smtp_server> [2] Email notice with Tendered amount fixed: Transaction ID: Operator ID: Payment type: Payment receipt Description of charges Amount Total: 0.00 Tendered: 30.00 Change given: 0.00 [3] Current email notice (HTRML) for Point of sale receipt: [% USE KohaDates %] [% USE Branches %] [% USE Price %] [% PROCESS "accounts.inc" %] <table> [% IF ( LibraryName ) %] <tr> <th colspan="2" class="centerednames"> <h3>[% LibraryName | html %]</h3> </th> </tr> [% END %] [% IF credit.library %] <tr> <th colspan="2" class="centerednames"> <h2>[% payment.library.branchname | html %]</h2> </th> </tr> [% END %] <tr> <th colspan="2" class="centerednames"> <h3>[% payment.date | $KohaDates %]</h3> </th> </tr> <tr> <td>Transaction ID: </td> <td>[% payment.accountlines_id %]</td> </tr> <tr> <td>Operator ID: </td> <td>[% payment.manager_id %]</td> </tr> <tr> <td>Payment type: </td> <td>[% payment.payment_type %]</td> </tr> <tr> <th colspan="2" class="centerednames"> <h2><u>Payment receipt</u></h2> </th> </tr> <tr> <th>Description of charges</th> <th>Amount</th> </tr> [% FOREACH offset IN payment.credit_offsets %] <tr> <td>[% PROCESS account_type_description account=debit %]</td> <td>[% debit.amount * -1 | $Price %]</td> </tr> [% END %] <tfoot> <tr class="highlight"> <td>Total:</td> <td>[% payment.amount * -1 | $Price %]</td> </tr> <tr> <td>Tendered: </td> <td>[% collected | $Price %]</td> </tr> <tr> <td>Change given:</td> <td>[% change | $Price %]</td> </tr> </tfoot> </table> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34340 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.