[Bug 9257] New: Add "groups" to normal search pulldown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Bug ID: 9257 Summary: Add "groups" to normal search pulldown Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: kyle@bywatersolutions.com It would be useful to be able to have the search groups be available from the library pull-down in addition to the advanced search. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13980&action=edit Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- It looks like this functionality depends on the user having JavaScript enabled. Generally speaking functionality which requires JavaScript should degrade gracefully: If it doesn't work without JS it should not be present for JS-disabled users. I would love to see a solution which used <optgroup> instead of a disabled <option> to organize the options. Could we perhaps prepend the group name with a specific string which could be parsed by the search script in order to be understood as a group instead of a single library? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13980|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14364&action=edit Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14365&action=edit Bug 9257 - Add "groups" to normal search pulldown - Followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Thanks for the ideas! This new followup implements them all and the feature will no longer need JavaScript. (In reply to comment #2)
It looks like this functionality depends on the user having JavaScript enabled. Generally speaking functionality which requires JavaScript should degrade gracefully: If it doesn't work without JS it should not be present for JS-disabled users.
I would love to see a solution which used <optgroup> instead of a disabled <option> to organize the options.
Could we perhaps prepend the group name with a specific string which could be parsed by the search script in order to be understood as a group instead of a single library?
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- This seems to be working, but I noticed the update message in updatedatabase.pl seems to be copy-paste from another patch. I also still see JavaScript in the template. Is that still doing something? Can it be removed? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14364|0 |1 is obsolete| | Attachment #14365|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15279&action=edit Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #6)
This seems to be working, but I noticed the update message in updatedatabase.pl seems to be copy-paste from another patch.
Fixed!
I also still see JavaScript in the template. Is that still doing something? Can it be removed?
I believe all the js was removed by the followup, I've squashed the two patches together for easier reading ( and the fact that separate patches was unnecessary ). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- *** Bug 9794 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #10 from Liz Rea <liz@catalyst.net.nz> --- I went to apply this - updatedatabase fails because of the quotes in the update description. I fixed that and if it passes my testing I'll upload that patch instead of the original. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Liz Rea <liz@catalyst.net.nz> --- Hi Kyle, I'm sorry to say I can't seem to get this to work - I can add the value for show_in_pulldown ok, but I can't seem to get the groups to show in the masthead pulldown - they simply are not there. The patch seems to apply ok otherwise (excepting the quotes around groups in updatedatabase) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15279|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16074&action=edit Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16074|0 |1 is obsolete| | --- Comment #13 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 16077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16077&action=edit Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu Signed-off-by: Liz Rea <liz@catalyst.net.nz> Yes! Now this works, and well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * small patch, good test plan * passes koha-qa.pl * work well, no side effect risk * an improvement could be to separate more clearly branches & groups in the list, because atm, you would get A BRANCH ANOTHER BRANCH BRANCH QUICK BRANCH A GROUP the "A GROUP" is not ordered alphabetically, not separated from branches. But that's not worth failing QA for that. It's just a suggestion for a follow-up -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16077|0 |1 is obsolete| | --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16745&action=edit [PASSED QA] Bug 9257 - Add "groups" to normal search pulldown This patch adds the ability to add groups to the library select pulldown on the opac, if it is enabled. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Go to Administration › Libraries and groups 4) Create a new group, or edit an existing one 5) Ensure the 'Show in search pulldown' checkbox is checked 6) Save the group 7) Enable OpacAddMastheadLibraryPulldown if it is not already enabled 8) Load the OPAC, try the group search from the libraries pulldown menu Signed-off-by: Liz Rea <liz@catalyst.net.nz> Yes! Now this works, and well. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9257 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org