https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3142 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #42)

while ( my $item = $items->next ) { - $norequests = 0 - if $norequests - && !$item->withdrawn - && !$item->itemlost - && ($item->notforloan < 0 || not $item->notforloan ) - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan - && $item->itemnumber; - $allow_onshelf_holds = Koha::CirculationRules->get_onshelfholds_policy( { item => $item, patron => $patron } ) unless $allow_onshelf_holds;

Could this loop be done smarter now?

We could certainly have get_onshelfholds_policy take a Koha::Items iterator and do things there to avoid the while.

opac/opac-ISBDdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac/opac-MARCdetail.pl - && !Koha::ItemTypes->find($item->effective_itemtype)->notforloan opac-detail.pl - && !$itemtypes->{$itm->{'itype'}}->{notforloan} Added a follow-up that looks at notforloan but effective is still another story.

Good catch. Isn't it blocker? Looks like a regression :-/ -- You are receiving this mail because: You are watching all bug changes.