[Bug 8532] New: Old/iffy data causes error checking out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Priority: P5 - low Change sponsored?: --- Bug ID: 8532 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Old/iffy data causes error checking out Severity: enhancement Classification: Unclassified OS: All Reporter: robin@catalyst.net.nz Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha In some cases (I don't really know the cause, but it doesn't matter) the issuedate in the 'old_issues' table ends up with NULL. In the case, there is an error when converting that date to the proper form during circulation (possibly happens elsewhere too, but that's where I saw it.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |robin@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 --- Comment #1 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 11216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11216&action=edit Bug 8532 - improve robustness when converting dates If undef is passed to the date format conversion function, it dies. This can happen when you have old data in the database. Better to handle it in some fashion rather than die, so now it just returns undef too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|ASSIGNED |Needs Signoff Severity|enhancement |normal --- Comment #2 from Robin Sheat <robin@catalyst.net.nz> --- This should be put into 3.8 also. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11216|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 11261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11261&action=edit Bug 8532 - improve robustness when converting dates If undef is passed to the date format conversion function, it dies. This can happen when you have old data in the database. Better to handle it in some fashion rather than die, so now it just returns undef too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> I replace "return undef" with just "return" to pass perlcritic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 8537 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Marcel if you could QA this, that would be fantastic! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Tiny patch, handling passed undefs. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8532 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- pushed to master. Already on stable, changing status accordingly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org