https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 89039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89039&action=edit Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and reply "itemAlreadyOnLoan" Veuillez saisir le message de validation pour vos modifications. Les lignes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #3 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Thanks Liz :) I'm submitting a new patch right away! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89039|0 |1 is obsolete| | --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 89724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89724&action=edit Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Arthur, Thanks for making this contribution. I notice that the $patron and $biblio that you added into the CanItemBeReserved() function were not instantiated and this caused an error. I have fixed that up in my followup patch. Liz would you be able to test both patches? Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91784|0 |1 is obsolete| | --- Comment #8 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 94388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94388&action=edit Bug 22806 : (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89724|0 |1 is obsolete| | --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 94389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94389&action=edit Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 97947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97947&action=edit Bug 22806: Unit Tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #12 from David Nind <david@davidnind.com> --- Patch no longer applies. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94388|0 |1 is obsolete| | --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 99882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99882&action=edit Bug 22806 : (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 99884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99884&action=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97947|0 |1 is obsolete| | --- Comment #17 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 99885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99885&action=edit Bug 22806: Unit Tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #19 from David Nind <david@davidnind.com> --- Sorry, I wasn't quick enough to retest. The patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22806 : CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Applying: Bug 22806 : (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Applying: Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Using index info to reconstruct a base tree... M C4/Reserves.pm Falling back to patching base and 3-way merge... Auto-merging C4/Reserves.pm CONFLICT (content): Merge conflict in C4/Reserves.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Notes: - ILS-DI request used for testing on koha-testing-docker http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=19&bib_id=11&item_id=32 - ILS-DI requests causes DataTable error o Patrons hold tab: see bug 24769 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99881|0 |1 is obsolete| | Attachment #99882|0 |1 is obsolete| | Attachment #99883|0 |1 is obsolete| | Attachment #99884|0 |1 is obsolete| | Attachment #99885|0 |1 is obsolete| | --- Comment #20 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 100091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100091&action=edit Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #22 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 100093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100093&action=edit Bug 22806: Unit Tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #24 from David Nind <david@davidnind.com> --- Notes from testing: - Step 5 of the test plan: message should be "itemAlreadyOnLoan", not "NotHoldable" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100092|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 100174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100174&action=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy@rijksmuseum.nl --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QAing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #30 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Goeie avond Marcel, inderdaat, the change also impact C4/Reserves. Although I noticed the bug while using ILSDI, operations from OPAC and Staff interface are also impacted. And I think its better to have as much coherences between all interfaces, hence my modification in C4/Reserves. I will modify the tests and the title in consequences :) Mvg, Arthur -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100175|0 |1 is obsolete| | --- Comment #31 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 106564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106564&action=edit Bug 22806: Unit Tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100174|0 |1 is obsolete| | --- Comment #34 from David Nind <david@davidnind.com> --- Created attachment 106779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106779&action=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- This works as described, I do see that we have checks for this in reserve.pl and opac-reserve.pl - can they be removed now that they are being added to the modules? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #39 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Nick Clemens from comment #37)

This works as described, I do see that we have checks for this in reserve.pl and opac-reserve.pl - can they be removed now that they are being added to the modules?

Indeed! Done in the QA patch :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #42 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Nick Clemens from comment #40)

Thanks Arthur!

you're welcome Sir!

1 - With this patchset the message to the patron changes from" This title cannot be requested because it's already in your possession. To: There are no items that can be placed on hold. We should pass the exact reason if possible

this problem has been addressed with new version of the qa patch :)

2 - On the staff side before these patches I am warned that patron has this in possession, but I can still place the hold After the patches I cannot place a hold unless AllowHoldPolicyOverride is set This is probably appropriate, but it is a behaviour change and should be noted in release notes

hummm... I can see there is a folder called "misc/release_notes" but not sure which file is to be edited in there, if any. Some clue to get out of the glue? :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #43 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Made a text proposal on the appropriate field on bugzilla (in the mean time) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #45 from Magnus Enger <magnus@libriotech.no> --- (In reply to Arthur Suzuki from comment #43)

Made a text proposal on the appropriate field on bugzilla (in the mean time)

I think that is the right thing to do. There are scripts that make sure "Text to go in the release notes" actually goes into the release notes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #47 from David Nind <david@davidnind.com> --- I tried to retest, but the patches no longer apply 8-( Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Using index info to reconstruct a base tree... M C4/Reserves.pm Falling back to patching base and 3-way merge... Auto-merging C4/Reserves.pm Applying: Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Applying: Bug 22806: Unit Tests Using index info to reconstruct a base tree... M t/db_dependent/ILSDI_Services.t M t/db_dependent/Reserves.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Reserves.t CONFLICT (content): Merge conflict in t/db_dependent/Reserves.t Auto-merging t/db_dependent/ILSDI_Services.t CONFLICT (content): Merge conflict in t/db_dependent/ILSDI_Services.t error: Failed to merge in the changes. Patch failed at 0001 Bug 22806: Unit Tests The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22806-Unit-Tests-Z7uKNQ.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #49 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 110101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110101&action=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sorry Arthur, I don't think you've accounted for the additional return status you've introduced in enough places. I think you need to: * add your new return value to the ENUM of failure reasons in club_holds_to_patron_holds * add handling for the new return value to reserve/placerequest.pl, reserve/request.pl and request.tt Failing QA for now.. good work in starting the move of these checks into a suitable level. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #53 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- yup, still, thanks martin for the helpful technical advises. And thanks to both of you (nick, martin) for reviewing. I'll do the follow-up. Arthur -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110100|0 |1 is obsolete| | Attachment #110101|0 |1 is obsolete| | Attachment #110102|0 |1 is obsolete| | --- Comment #54 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 110973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110973&action=edit Bug 22806: CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #56 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 110975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110975&action=edit Bug 22806: Unit Tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #58 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Martin Renvoize from comment #52)

Oh.. hang on.. it looks like Nick caught these issues too and there's conversation about a QA followup patch.. but I'm not seeing it?

I guess I did some mis-manipulation with git bz, it was in the obsoletes :) re-uploaded and did a rebase of the former patches on the way. hope it will be good enough this time! (yay, fingercrossed) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches apply, tests pass. But I'd feel a bit better if someone else took a look here. Martin or Nick, could you continue? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110974|0 |1 is obsolete| | --- Comment #62 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111772&action=edit Bug 22806: (follow-up) CanBookBeReserved and CanItemBeReserved must check AllowHoldsOnPatronsPossessions As CanBookBeReserved() was failing as $patron and and $biblio were not instantiated I fixed that up. Test plan : 1 - set AllowHoldsOnPatronsPossessions to "Don't Allow" 2 - Checkout an item to a borrower 3 - Try to reserve an item using ILS-DI WebService -> Will work without complaining. 4 - Cancel the hold and apply patch 5 - Repeat 3 -> Should not place hold and show error "NotHoldable" Sponsored-By: Catalyst IT Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110976|0 |1 is obsolete| | --- Comment #64 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111774&action=edit Bug 22806: (QA follow-up) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #66 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thanks for the qa :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 112824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112824&action=edit Bug 22806: Remove perlcritic errors Subroutine "new" called using indirect syntax at line 415, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 420, column 14. See page 349 of PBP. (Severity: 4) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22806 --- Comment #71 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #69)

Created attachment 112824 [details] [review] Bug 22806: Remove perlcritic errors

Subroutine "new" called using indirect syntax at line 415, column 18. See page 349 of PBP. (Severity: 4) Subroutine "new" called using indirect syntax at line 420, column 14. See page 349 of PBP. (Severity: 4)

Pushed to master. -- You are receiving this mail because: You are watching all bug changes.