[Bug 41422] New: New FilterSearchResultsByLoggedInBranch has I18N issue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Bug ID: 41422 Summary: New FilterSearchResultsByLoggedInBranch has I18N issue Initiative type: --- Sponsorship --- status: Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 37883 koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: $('#toggleitems').text() === 'Show local items only' ? $('#toggleitems').text("Show items in all libraries") : $('#toggleitems').text("Show local items only"); This is problematic for multiple reasons: * Displayed text is not translatable * The check will only work while things are not translatable... Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37883 [Bug 37883] Add a filter for staff search results to filter by library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190402&action=edit Bug 41422: Fix I18N issue with FilterSearchResultsByLoggedInBranch To test: 1. Apply patch 2. Search fof the FilterSearchResultsByLoggedInBranch system preference and set it to 'Do'. 3. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 4. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 5. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 6. Play more with the search results and ensure everything is accurate. 7. Set the FilterSearchResultsByLoggedInBranch system preference to 'Don't' and confirm that there is no button to filter by branch anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190402|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190403&action=edit Bug 41422: Fix I18N issue with FilterSearchResultsByLoggedInBranch To test: 1. Apply patch 2. Search fof the FilterSearchResultsByLoggedInBranch system preference and set it to 'Do'. 3. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 4. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 5. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 6. Play more with the search results and ensure everything is accurate. 7. Set the FilterSearchResultsByLoggedInBranch system preference to 'Don't' and confirm that there is no button to filter by branch anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190403|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190416&action=edit Bug 41422: Fix I18N issue with FilterSearchResultsByLoggedInBranch To test: 1. Apply patch 2. Search fof the FilterSearchResultsByLoggedInBranch system preference and set it to 'Do'. 3. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 4. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 5. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 6. Play more with the search results and ensure everything is accurate. 7. Set the FilterSearchResultsByLoggedInBranch system preference to 'Don't' and confirm that there is no button to filter by branch anymore. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the release notes| |translatability of the text | |shown when the | |FilterSearchResultsByLogged | |InBranch system preference | |is enabled, and also the | |check and what is shown | |only works when not | |translated. CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Everything seems to work as expected. One issue noted, but not related to this bug, as this is the case before the patch: in the search results location column there is a space before the comma in the sentence about availability, for example: 1 local item , None available. Created Bug 41426 for this. Attempted a release note, not sure I got it right. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New |New |FilterSearchResultsByLogged |FilterSearchResultsByLogged |InBranch has I18N issue |InBranch doesn't fully | |translate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks for the quick fix! Much appreciated! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Bug 41422 depends on bug 37883, which changed state. Bug 37883 Summary: Add a filter for staff search results to filter by library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37883 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190416|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 --- Comment #6 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192271&action=edit Bug 41422: Fix I18N issue with FilterSearchResultsByLoggedInBranch To test: 1. Apply patch 2. Search fof the FilterSearchResultsByLoggedInBranch system preference and set it to 'Do'. 3. Do a catalog search and notice the 'Show local items only' button above the "Location" column. 4. Click it to show information ( in that column ) that is only related to the branch you are currently logged in at. 5. In the same result set have some items that are checked out, withdrawn, lost, damaged, and notforlaon. 6. Play more with the search results and ensure everything is accurate. 7. Set the FilterSearchResultsByLoggedInBranch system preference to 'Don't' and confirm that there is no button to filter by branch anymore. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41422 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 37883 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org