[Bug 31521] New: Allow to configure behaviour when checking in a reserved item at SCO
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Bug ID: 31521 Summary: Allow to configure behaviour when checking in a reserved item at SCO Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org Some users want to display a custom message to patrons self returning items that are on hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 140212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140212&action=edit Bug 31521: Configure behaviour when checking in a reserved item at SCO This patch adds a system preference (SCOCheckinIfReservedBehaviour) which allow to control the behaviour of SCO checkin when the returned item is reserved: - allow checkin (current behaviour) - allow checkin and show a message - forbid checkin and show a message The message is configurable is another system preference (SCOCheckinIfReservedMessage) Test plan: 1. Apply patch, run updatedatabase.pl and restart koha 2. Enable WebBasedSelfCheck and SCOAllowCheckin 3. (Staff) Set SCOCheckinIfReservedBehaviour to "Forbid checkin & show message" 4. (Staff) Write some text in SCOCheckinIfReservedMessage 5. (Staff) Checkout an item I to patron A 6. (Staff) Place a hold on item I for patron B 7. (SCO) Log in to SCO with patron A 8. (SCO) Try to return item I The configured message should be displayed and item I should still be checked out 9. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin & show message" 10. (SCO) Try to return item I The configured message should be displayed and item I should have been checked in 11. (Staff) Checkout item I to patron A again 12. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin" 13. (SCO) Try to return item I The configured message should NOT be displayed and item I should have been checked in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- I like this but have a couple questions/comments: 1. Should 'SCOCheckinIfReservedMessage' allow the use of HTML? 2. If 'SCOCheckinIfReservedBehaviour' is set to forbid or alert should we also check for the existence of 'SCOCheckinIfReservedMessage' to avoid displaying an empty '<div class="alert alert-warning">'? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140212|0 |1 is obsolete| | --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 169820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169820&action=edit Bug 31521: Configure behaviour when checking in a reserved item at SCO This patch adds a system preference (SCOCheckinIfReservedBehaviour) which allow to control the behaviour of SCO checkin when the returned item is reserved: - allow checkin (current behaviour) - allow checkin and show a message - forbid checkin and show a message The message is configurable is another system preference (SCOCheckinIfReservedMessage) Test plan: 1. Apply patch, run updatedatabase.pl and restart koha 2. Enable WebBasedSelfCheck and SCOAllowCheckin 3. (Staff) Set SCOCheckinIfReservedBehaviour to "Forbid checkin & show message" 4. (Staff) Write some text in SCOCheckinIfReservedMessage 5. (Staff) Checkout an item I to patron A 6. (Staff) Place a hold on item I for patron B 7. (SCO) Log in to SCO with patron A 8. (SCO) Try to return item I The configured message should be displayed and item I should still be checked out 9. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin & show message" 10. (SCO) Try to return item I The configured message should be displayed and item I should have been checked in 11. (Staff) Checkout item I to patron A again 12. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin" 13. (SCO) Try to return item I The configured message should NOT be displayed and item I should have been checked in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Rebased on master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169820|0 |1 is obsolete| | --- Comment #6 from Sam Lau <samalau@gmail.com> --- Created attachment 170572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170572&action=edit Bug 31521: Configure behaviour when checking in a reserved item at SCO This patch adds a system preference (SCOCheckinIfReservedBehaviour) which allow to control the behaviour of SCO checkin when the returned item is reserved: - allow checkin (current behaviour) - allow checkin and show a message - forbid checkin and show a message The message is configurable is another system preference (SCOCheckinIfReservedMessage) Test plan: 1. Apply patch, run updatedatabase.pl and restart koha 2. Enable WebBasedSelfCheck and SCOAllowCheckin 3. (Staff) Set SCOCheckinIfReservedBehaviour to "Forbid checkin & show message" 4. (Staff) Write some text in SCOCheckinIfReservedMessage 5. (Staff) Checkout an item I to patron A 6. (Staff) Place a hold on item I for patron B 7. (SCO) Log in to SCO with patron A 8. (SCO) Try to return item I The configured message should be displayed and item I should still be checked out 9. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin & show message" 10. (SCO) Try to return item I The configured message should be displayed and item I should have been checked in 11. (Staff) Checkout item I to patron A again 12. (Staff) Set SCOCheckinIfReservedBehaviour to "Allow checkin" 13. (SCO) Try to return item I The configured message should NOT be displayed and item I should have been checked in Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31521 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Can we have some default text in case the system is configured with SCOCheckinIfReservedBehaviour to show the message but no message is set in SCOCheckinIfReservedMessage? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org