[Bug 20920] New: Plack timeout because of missing CGI::Compile Perl dependency
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Bug ID: 20920 Summary: Plack timeout because of missing CGI::Compile Perl dependency Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: jcharaoui@cmaisonneuve.qc.ca QA Contact: testopia@bugs.koha-community.org CC: mirko@abunchofthings.net Created attachment 76000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76000&action=edit Patch for debian/control The Debian/Ubuntu package is missing a dependency on libcgi-compile-perl. Without this package installed, when Plack is enabled/started, the webserver is unresponsive and the following errors appear in the logs: Error while loading /etc/koha/plack.psgi: Can't locate CGI/Compile.pm in @INC (you may need to install the CGI::Compile module) (@INC contains: /usr/share/koha/lib /us r/share/koha/installer /usr/share/koha/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5 /5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at /usr/share/perl5/Plack /App/WrapCGI.pm line 8. BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/WrapCGI.pm line 8. Compilation failed in require at /usr/share/perl5/Plack/App/CGIBin.pm line 6. BEGIN failed--compilation aborted at /usr/share/perl5/Plack/App/CGIBin.pm line 6. Compilation failed in require at /etc/koha/plack.psgi line 21. BEGIN failed--compilation aborted at /etc/koha/plack.psgi line 21. Attached is a patch to add this package to the debian/control file. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Jerome Charaoui <jcharaoui@cmaisonneuve.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Assignee|koha-bugs@lists.koha-commun |jcharaoui@cmaisonneuve.qc.c |ity.org |a CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |dependency -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Which versions of Debian and/or Ubuntu did you test? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #2 from Jerome Charaoui <jcharaoui@cmaisonneuve.qc.ca> --- Debian 9.4 (stretch) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- libcgi-compile-perl is 'recommended' by libplack-perl, which gets it installed on most systems. Apparently koha depends on it. Not sure why it is only recommended by libplack-perl, but that's a different story. The control file is not supposed to be patched, as stated in the file itself.
# Do not manually edit "control"
CGI::Compile needs to be added to PerlDependencies.pm. I will take care of updating the control file afterwards. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #4 from Jerome Charaoui <jcharaoui@cmaisonneuve.qc.ca> --- Created attachment 76217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76217&action=edit bug 20920: patch to PerlDependencies.pm adding CGI::Compile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Jerome Charaoui <jcharaoui@cmaisonneuve.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #5 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 76589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76589&action=edit Bug 20920: Add missing dependency on CGI::Compile Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 76590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76590&action=edit Bug 20920: Followup: generated d/control Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |nick@bywatersolutions.com --- Comment #7 from Mirko Tietgen <mirko@abunchofthings.net> --- Jerome, thanks a lot for spotting the problem and your patch! Minor QA change: first line of the commit message is supposed to be Bug xxxxx: Your bug report title I changed it and generated the new control file. Nick, please push, I will do a 18.05.01-2 and probably 17.11.07-2 package with this because it breaks fresh Koha with Plack on Stretch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #8 from Mirko Tietgen <mirko@abunchofthings.net> --- Martin: is in 18.05.01-2, please push to 18.05.02. Fridolin: is in 17.11.07-2, please push to 17.11.08. Depends on 20693 for 17.11.x, please push the other one first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate, | |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20693 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20920 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org