https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 --- Comment #1 from Kelly McElligott <kelly@bywatersolutions.com> --- This expiration date is set when the item has been changed to waiting. Steps: 1. System preference : expirereservesonholidays to DON't Allow 2. Make sure the Koha calendar is closed on the day the item will expire if triggered today. 3. Place a hold on a item and check it in to trigger the hold to Waiting. 4. See that the waiting hold date is the date the Koha calendar has indicated as being closed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 --- Comment #3 from Kelly McElligott <kelly@bywatersolutions.com> --- Yes Katrin that would be a good system preference to use for a work around, however, if the library does not want to give the patron all the days they are closed included in their reservesmaxpickupdelay Although the cron does not remove the hold, it is misleading to the staff to see that a hold "could" cancel on a day that the library is actually closed. This date is also shown in the OPAC to display the patron when their hold has expired. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 --- Comment #5 from Kelly McElligott <kelly@bywatersolutions.com> --- Yes Katrin, that is a great idea! Giving them ALL the options! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org --- Comment #7 from carthur@slolibrary.org <carthur@slolibrary.org> --- +1 on should have a "push to the next open day" option. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21713 E-P Keskitalo <esa-pekka.keskitalo@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esa-pekka.keskitalo@helsink | |i.fi --- Comment #9 from E-P Keskitalo <esa-pekka.keskitalo@helsinki.fi> --- This should need attention indeed. Our internal note below suggests a bit different solution. "...Last pickup date should never be on a day when the library is closed. In these cases it should be extended by the number of (library open) days set in ReservesMaxPickUpDelay system preference. That is: reserves.patron_expiration_date should not affect at all when counting the last pickup date. " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.