[Bug 25827] New: Update button for request.pl needs to be pinned in place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Bug ID: 25827 Summary: Update button for request.pl needs to be pinned in place Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Having the update button at the bottom of the holds page (request.pl) is a nuisance, especially on records that have hundreds of holds. This button needs to be pinned at the top of the page, similar to the save button when editing a patron record. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update button for |Add floating toolbar to the |request.pl needs to be |holds summary page in staff |pinned in place |interface Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Hold requests |Templates Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |25892 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25892 [Bug 25892] Clarify the visual hierarchy of holds by branch and itemtype -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106405&action=edit Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summar page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Tested on sandbox. Applied 25892 (which I signed off), then applied 25827. The button is moved to the top, but nothing is sticking. It updates as expected, otherwise. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Looks like it works in Firefox bug not Chrome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Owen Leonard from comment #4)
Looks like it works in Firefox bug not Chrome.
I can confirm I did my test in Chrome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106405|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106482&action=edit Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summar page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106482|0 |1 is obsolete| | CC| |emmi.takkinen@outlook.com --- Comment #7 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Created attachment 106489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106489&action=edit Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summar page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Emmi Takkinen <emmi.takkinen@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Emmi Takkinen <emmi.takkinen@outlook.com> --- Tested on Firefox and Chrome. Works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106489|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 106531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106531&action=edit Bug 25827: Add floating toolbar to the holds summary page in staff interface This patch adds a floating toolbar to the holds summary page in the staff interface. To test, apply the patch and view the holds page for a title with multiple holds on it. Test that when you scroll down past the position of the "Update hold(s)" button, the toolbar "sticks" to the top of the screen. Test that holds are updated correctly after clicking the "Update hold(s)" button. Signed-off-by: Emmi Takkinen <emmi.takkinen@outlook.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25827 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- not backporting enhancement to 20.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org