[Bug 7781] New: Enhancements to the main page (first step)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Priority: P5 - low Change sponsored?: --- Bug ID: 7781 Assignee: adrien.saurat@biblibre.com Summary: Enhancements to the main page (first step) QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat@biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha There is much to do in order to make Koha more "eye-friendly" ;) but a few modifications could quickly enhance the main page. It would be good to : - move the different search boxes (checkout, checkin, search patron, search the catalog) on top of page, the way it's done on other pages; - display the Koha logo (deep pages display it but not the front page!) - display the breadcrumb bar (even if it will contain only "Home") - display a general title like "Welcome to Koha" (module pages have titles already) - reorganise the links to modules (Cataloguing can move to the left side if the search boxes disappear) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #1 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8443&action=edit proposed patch #1 Also corrected the use of rights limitations (CAN_user_editcatalogue was mixed with CAN_user_catalogue) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #2 from Marc Véron <veron@veron.ch> --- Applied patch #1 I like your proposition. The staff client looks more consistent like this. ---- Had a warning while applying the patch: Applying: Bug 7781: enhancements on main page /usr/share/kohaclone/.git/rebase-apply/patch:48: trailing whitespace. </ul> warning: 1 line adds whitespace errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #2)
Applied patch #1
I like your proposition.
The staff client looks more consistent like this.
----
Had a warning while applying the patch:
Applying: Bug 7781: enhancements on main page /usr/share/kohaclone/.git/rebase-apply/patch:48: trailing whitespace. </ul> warning: 1 line adds whitespace errors.
Marc you might like to follow http://blog.bigballofwax.co.nz/2011/12/15/fixing-whitespace-when-apply-patch... which will allow to fix that whitespace error automagically -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8443|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 8458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8458&action=edit Bug 7781: enhancements on main page Creation of a new include and editing of the mainpage.tt to : - move the different search boxes (checkout, checkin, search patron, search catalog) on top of page, the way it's done on other pages; - display the Koha logo (deep pages display it but not the front page!) - display the breadcrumb bar (even if it will contain only "Home") - display a general title like "Welcome to Koha" (module pages have titles already) - reorganise the links to modules (Cataloguing can move to the left side if the search boxes disappear) Use of rights limitations was corrected too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- I have fixed the whitespace issue, and fixed a conflict. Still needs a sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Julien Sicot <julien.sicot@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julien.sicot@gmail.com --- Comment #6 from Julien Sicot <julien.sicot@gmail.com> --- I applied the patch and test it on several browsers (Firefox, Safari, Chrome, Opera) in different operating systems (MacOS and Ubuntu Linux). Everything seems to work well. Just one problem on Firefox (Ubuntu), the submit button is not on the same line of the search bar (this affects just "check out" tab). Suggestion : Could it be possible to fix the left links list when there are no news ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Adrien SAURAT <adrien.saurat@biblibre.com> --- I'll try to fix the Submit button issue but it appears correctly on my computer so it will be hard to test :/ And the main menu needs to stay in the center even if the news are off, indeed! I'll change this asap. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #7)
I'll try to fix the Submit button issue but it appears correctly on my computer so it will be hard to test :/
The problem only appears if CircAutocompl is turned ON. I think we need to increase the default width here: #borrowerautocomplete { text-align: left; width: 450px; } -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #9 from Marc Véron <veron@veron.ch> --- I found a difference in the html of the buttons: Check Out: <input type="submit" value="Submit" class="submit" id="ysearchsubmit"> Others: <input type="submit" class="submit" value="Submit"> However, I do not find #ysearchsubmit in the CSS Anyway, this difference could be a hint why (older?) browsers interpret the CSS differently. @Julien Sicot: Which FireFox Version on Ubuntu? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8458|0 |1 is obsolete| | --- Comment #10 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8497&action=edit proposed patch #2 Modifications : - main menu now in the center even if no news are displayed - fixes the Submit button by allowing more space to the borrowerautocomplete div as Owen suggested -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8497|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 8588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8588&action=edit [SIGNED-OFF] Bug 7781 : enhancements on main page - moves the different search boxes on top of page - displays the Koha logo - displays the breadcrumb bar - displays a general title "Welcome to Koha" - reorganises the links to modules - centers the main menu even if no news are displayed - fixes the Submit button when CircAutocompl is on Signed-off-by: mveron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8588|0 |1 is obsolete| | --- Comment #12 from Marc Véron <veron@veron.ch> --- Created attachment 8589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8589&action=edit [SIGNED-OFF] Bug 7781 : enhancements on main page - moves the different search boxes on top of page - displays the Koha logo - displays the breadcrumb bar - displays a general title "Welcome to Koha" - reorganises the links to modules - centers the main menu even if no news are displayed - fixes the Submit button when CircAutocompl is on Signed-off-by: mveron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Marc Véron <veron@veron.ch> --- Applied white space fix as recommended by Chris as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- I was hoping to add a screenshot of this to the bug report but the patch no longer applies. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8589|0 |1 is obsolete| | --- Comment #15 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8717&action=edit proposed patch with conflict resolved Resolved conflict. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8717|0 |1 is obsolete| | --- Comment #16 from Adrien SAURAT <adrien.saurat@biblibre.com> --- Created attachment 8719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8719&action=edit patch with conflict resolved and lower cases "Check Out" becomes "Check out" and so on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8720&action=edit Screenshot showing updated interface -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 I like the idea of the start page being more consistent with other module pages - having the logo and the search options on top. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I have my doubts about this patch. I agree that the main page needs design work, but I do not think that we really improved it now. (Consistency is not really an issue here; there is only one start page.) If we rearrange the first page, should we sort the options and make each translation sort them too properly? The current order (with and without patch) is somewhat funny. If there is no news, I personally think the new page looks strange. Perhaps the new Welcome to Koha should be designed differently? Shift the links more to the left then? Also the capitalization looks odd to me (e.g. Advanced search vs Advanced Search; I will submit a comment on bug 2780 too). (Note that you left Add MARC Record untouched.) This change does not make it more user friendly. On the old page I can directly type a word for catalog search (without extra click) or patron search. We loose speed here for the user. Sorry for some negative feedback from a user perspective, +1 for the idea to improve it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #19)
This change does not make it more user friendly. On the old page I can directly type a word for catalog search (without extra click) or patron search. We loose speed here for the user.
Actually the number of clicks is the same. In the current design, you click once to put the focus in the form field and then start typing. In the proposed design you click once on the tab and the focus is automatically moved to the form field. It's one click either way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #20)
Actually the number of clicks is the same. In the current design, you click once to put the focus in the form field and then start typing. In the proposed design you click once on the tab and the focus is automatically moved to the form field. It's one click either way. That is true. That probably was a psychological one ;)
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 --- Comment #22 from Ian Walls <koha.sekjal@gmail.com> --- Looking at the screenshot, it's not as shocking of a difference as I had imagined (for whatever reason). Having the consistent tabbed top bar, instead of myriad one-off search boxes, looks better to me. Obviously, there are still plenty of aesthetic changes that could be made, but as far as a graphic restructuring goes, I think it wouldn't phase users too badly (since we already have the tabbed search box paradigm in other places). Will QA shortly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #23 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: despite his size, this patch is mostly template-reorganisation. It add the search tool bar and the breadcrumb for more consistency with other pages. (This change has been discussed during the hackfest) prove xt/author/translatable-templates.t xt/author/valid-templates.t are OK passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7928 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Status|ASSIGNED |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7781 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org