[Bug 28972] New: Add missing foreign key constraints to holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Bug ID: 28972 Summary: Add missing foreign key constraints to holds queue table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The table tmp_holdsqueue is missing a couple key constraints that should be there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124651&action=edit Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28966 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124651|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 124662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124662&action=edit Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124662|0 |1 is obsolete| | --- Comment #3 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125025&action=edit Bug 28972: Add missing foreign key constraints to holds queue table The table tmp_holdsqueue is missing a couple key constraints that should be there, one for biblio and one for borrowers. Test Plan: 1) "SHOW CREATE TABLE tmp_holdsqueue;" should show no FKs for biblio or borrowers 2) Apply this patch 3) Run updatedatabase.pl 4) "SHOW CREATE TABLE tmp_holdsqueue;" should now show FKs for biblio or borrowers Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125055&action=edit Bug 28972: Make DB rev idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart+koha@gmail. | |com --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tests from t/db_dependent/HoldsQueue.t and t/db_dependent/Koha/Item.t are failing. Please fix ASAP. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125065&action=edit Bug 28972: Fix failing tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28972 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] Omnibus: Add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org