http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-08 22:50:27 UTC --- Created attachment 3105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3105 Proposed Patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-09 01:12:29 UTC --- And a follow up patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-02-17 19:10:33 UTC --- This sounds like it only works in acquisitions ... can you not batch modify bib records any other way? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-02-18 14:02:48 UTC --- what permissions are required for this to work? I was logged in as super librarian for my first tests. When I logged in with only items_batchmod permissions I got the following error: Software error: Can't use string ("batchedit") as a HASH ref while "strict refs" in use at /home/nengard/kohaclone/C4/Auth.pm line 1559. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. I don't see a batchedit permission anywhere. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-02-18 14:45:16 UTC --- IRC Log on this topic: [08:57] <nengard> i'm logged in a superlibrarian [08:58] <nengard> i'll go ahead and try with only the edit permissions [09:00] <oleonard> Hmmm, no I see the batchedit permission in my database [09:00] <nengard> i don't have that either - but the patch doesn't say it adds a new permission [09:00] <oleonard> ...and it's checked in my permissions setup [09:00] <nengard> oh [09:00] <nengard> under what? [09:01] <oleonard> At first I thought it would be under cataloging, but it's under tools [09:01] <nengard> under tools i have items_batchmod [09:01] <nengard> but not batchedit [09:02] <oleonard> I ought to trash this database and start over... I'm not good about keeping it "clean" when testing [09:03] <nengard> :) [09:03] <nengard> paul_p can you take a look at questions on bug 5725 [09:03] <huginn> Bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 enhancement, PATCH-Sent, ---, paul.poulain, ASSIGNED, Batch modifications for Biblios [09:03] <kf> only a thought: but do we need different permissions for items_batchedit and biblio_batchedit? [09:05] <nengard> i think we do [09:05] <nengard> but right now we don't have one [09:05] <nengard> i'd argue that if you're allowed to edit the catalog then you should be able to do batch edits ... but others might disagree [09:06] * oleonard does [09:06] <oleonard> A batch edit is potentially much more destructive [09:06] <oleonard> No reason not to include a separate permission and let the supervisor decide. [09:10] <oleonard> nengard: I'll bet the batchedit permission didn't make it into the patch because of the way rangi is putting together the patches [09:11] <oleonard> He probably didn't cherry-pick that part (if cherry pick is the right word here) [09:11] <nengard> so there is a permission in another patch? [09:13] <oleonard> Yes, I see it in the original Biblibre branch [09:13] <oleonard> That must be why I have it... messy database. [09:13] <oleonard> But that doesn't explain why it didn't work for me even though that permission was there [09:21] <oleonard> It seems strange that someone could have batch edit permission and not catalog edit permission [09:30] <sekjal> I'd agree that if you can edit in batch, you should be able to edit individually [09:34] <kf> so it should be grouped into the cataloging rights? [09:37] <oleonard> How deep can the permissions hierarchy go? Right now we only have two levels [09:38] <oleonard> Theoretically you'd want "batchedit" to be a sub-permission of "edit_catalogue" (not "editcatalog," the parent category) [09:39] <kf> oleonard: perhaps even the batch item delete/modify should moved to cataloging? [09:39] <kf> i think they are under tools, because we have no cataloging start page? [09:39] <paul_p> nengard, seen you msg. Could you drop me a mail pls, i'll forget... [09:39] <nengard> okey dokey [09:40] <oleonard> kf: I think so. I think that grouping reflects where to find the tool in Koha, but really the permissions should reflect roles [09:40] <kf> hm. I think we only have kind of a start page for circ and tools? [09:40] <kf> perhaps we should think about that too - tools gets crowdy [09:40] <kf> crowded? [09:40] <oleonard> Crowded. [09:40] <nengard> I don't mind where the batch edit is located - it is a tool - but the permissions should be in the logical spots -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-02-21 16:19:17 UTC --- Created attachment 3191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3191 follow-up for permission fixing -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #12 from Nicole C. Engard <nengard@gmail.com> 2011-02-21 16:37:07 UTC --- I tried to apply this patch on top of the other two and it did not apply. Either there is a problem with the patch - or with the way I applied it: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: BG5725 follow-up : permission is wrong fatal: sha1 information is lacking or useless (tools/batchedit.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 BG5725 follow-up : permission is wrong When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3105|0 |1 is obsolete| | Attachment #3108|0 |1 is obsolete| | Attachment #3191|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> 2011-02-21 19:46:23 UTC --- Created attachment 3193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3193 Unified patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-01 22:09:18 UTC --- Created attachment 3234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3234 follow-up: fixing perm problem -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #18 from Nicole C. Engard <nengard@gmail.com> 2011-03-04 00:05:06 UTC --- When I choose 'batch edit' it chooses all the items in my cart regardless of which ones I checked before I clicked 'batch edit' it should only batch edit the ones I choose for it to batch edit. also the second patch does not apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: BG5725 follow-up : permission is wrong fatal: sha1 information is lacking or useless (tools/batchedit.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 BG5725 follow-up : permission is wrong When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #20 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-17 02:10:22 UTC --- *** Bug 5435 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-21 14:50:06 UTC --- It doesn't work for me. Tested: - Add biblios to my cart, show my cart, and click on "Batch Edit" Nothing happens, except that all biblios in my cart disappear. - Go directly to tools/batchedit.pl It appears that it works (Status 'OK') but the biblios aren't modified. Moreover the title page of batchedit.pl is "Batch Deletion of Items" which is clearly not good. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3193|0 |1 is obsolete| | Attachment #3234|0 |1 is obsolete| | Attachment #3356|0 |1 is obsolete| | --- Comment #25 from Paul Poulain <paul.poulain@biblibre.com> 2011-07-25 08:50:52 UTC --- Created attachment 4734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4734 proposed patch (updated again) Patch updated for Template::Toolkit, some mistakes fixed : * HTML error fixed * missing link from cart * missing batchedit permission Tested all features, work fine. Please sign-off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4734|0 |1 is obsolete| | --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> 2011-07-25 08:53:44 UTC --- Created attachment 4735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4735 proposed patch (updated again) oups, made a mistake in the previous upload. This is the right patch, sorry. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #28 from Owen Leonard <oleonard@myacpl.org> 2011-08-03 18:18:27 UTC --- Some comments before I even test this patch's functionality: - This patch includes an explicit DB revision number and a revision to a previous section ($DBversion = "3.05.00.004";). - The patch includes a revision to kohaversion.pl which I understood should be left to the RM? - The patch appears to contain the entirety of the changes proposed in Bug 5887. If this is correct, Bug 5887 should be closed as it is redundant. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4736|0 |1 is obsolete| | --- Comment #30 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-05 13:37:25 UTC --- Created attachment 4863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4863 proposed patch (rebased aug, 6th) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #32 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-05 13:41:14 UTC --- (In reply to comment #29)

Some notes on testing:

- This patch does not add a link to the batch edit interface from the tools page.

fixed in follow-up

- The interface says you can use a file, but it does not specify what information the file should have.

Fixed some wording

- The same is true of the "enter records one by one" option. It says "Records numbers list," but it's not explicit what kind of numbers it needs.

fixed wording too

- I like that the batch item edit/delete process lets me submit my batch of items *before* specifying the changes. That gives me a chance to preview the set of records which will be modified. I think this is an essential step to prevent unwanted edits.

It was already the case when you reached this page from the cart page, so it was quite easy to do it from other origins.

- The results screen (after submission) uses a yellow "alert" style message box to display "All operations processed." This is informational, so it should use the "message" style box. It should also appear at the top of the page, not the bottom.

fixed

- The results screen listing of modified records should link to each record.

Not fixed. I propose to do an ENH for later

- The results screen has a "status" column heading but no data in the subsequent rows.

Was a HTP => TT switch glitch

- The first test I did was to select a couple of records and try to modify the 000 tag with new data, but the records remained unchanged after submission even though the interface reported no errors.

I think it's because you forgot to click "add" (on the right of the action form). You must click add even if you have just one condition. Back to needs signoff, let me know what you think -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #33 from Owen Leonard <oleonard@myacpl.org> 2011-08-08 20:02:22 UTC --- Created attachment 4897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4897 Proposed additional fixes - Correcting page title - Adding breadcrums - Adding sidebar menu (matching other batch mod pages) - Showing "loading" graphic during AJAX operations - Adding empty option to list of MARC tags so that onchange event will fire when the user is choosing 000 - Other structural markup changes I still found that trying to make changes to 000 didn't work. "All operations processed," but the status for each titles says "Nothing done." -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4898|0 |1 is obsolete| | --- Comment #35 from Owen Leonard <oleonard@myacpl.org> 2011-08-08 20:08:16 UTC --- Created attachment 4899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4899 Screenshot of my entries before submission -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #37 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-12 13:39:46 UTC --- Created attachment 5405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5405 proposed patch follow-up 2 follow-up 2, fixes leader changes that was not working (see owen comment 33) Owen, you can sign-off my 3 patches for this ENH (or add a new comment ;-) ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #39 from Owen Leonard <oleonard@myacpl.org> 2011-09-27 19:37:09 UTC --- Still having problems with modifications to 000. Here's the error I'm getting now: substr outside of string at /usr/share/perl5/MARC/Record.pm line 571. at /usr/share/perl5/MARC/Record.pm line 571 MARC::Record::set_leader_lengths('MARC::Record=HASH(0xa773568)', 651, 253) called at /usr/share/perl5/MARC/File/USMARC.pm line 313 MARC::File::USMARC::encode('MARC::Record=HASH(0xa773568)') called at /usr/share/perl5/MARC/Record.pm line 473 MARC::Record::as_usmarc('MARC::Record=HASH(0xa773568)') called at /home/oleonard/kohaclone/C4/Biblio.pm line 3511 C4::Biblio::ModBiblioMarc('MARC::Record=HASH(0xa773568)', 2, '') called at /home/oleonard/kohaclone/C4/Biblio.pm line 339 C4::Biblio::ModBiblio('MARC::Record=HASH(0xa773568)', 2, '') called at /home/oleonard/kohaclone/tools/batchedit.pl line 201 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #41 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-03 20:49:04 UTC --- Owen, i've investigated, I think the problem is due to the fact that you tried to set a value that is too short. If you try to set a leader smaller than the official size, MARC::Record will complain because he tries to set some values, that he can't. The line you've got is : substr($self->{_leader},10,2) = '22'; MARC::Record tries to set 22 in position 10 and 11, and the string you've submitted is probably less than 10, so the substr result in the message you get. We have two options : * remove the 000 * specify in the doc (Nicole, it's for you !) that updating the leader must be made carefully, with a full leader, some positions being ignored automatically and set to the default MARC values (positions 0-4 with the length of the record for example) You preference ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4864|0 |1 is obsolete| | Attachment #4899|0 |1 is obsolete| | Attachment #5404|0 |1 is obsolete| | Attachment #5405|0 |1 is obsolete| | Attachment #5684|0 |1 is obsolete| | --- Comment #43 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-04 08:33:00 UTC --- Created attachment 5685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5685 proposed (squashed) patch owen suggested to submit a squashed patch, here it is. this patch squashes the previous ones, and is the only one needing to be applied now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> 2011-10-14 17:04:37 UTC --- (In reply to comment #41)

You preference ?

Sorry to have not immediately replied to your question. I don't think it's true that I have tried to set a value that is too short--at least not by the standards of the MARC editor itself. I tested using a value that the MARC editor accepted. However, I don't think the 000 problem should prevent this from being approved. Let's hide 000 as an option if we must, in order to get this into master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #47 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-18 15:58:42 UTC --- Created attachment 5959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5959 BZ5725 follow-up This small follow up: * add a missing string resulting in an "undefined" when user choosed 'Create field and subfield' and hit Add button * synch the description after adding with the description in the list box of the 4 options available -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5959|0 |1 is obsolete| | --- Comment #49 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-18 16:11:25 UTC --- Created attachment 5960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5960 BZ5725 follow-up for comment 48 This small follow up: * removes "whole field" in subfield list except when dealing with a field <010 (that has no subfield) * add a missing string resulting in an "undefined" when user choosed 'Create field and subfield' and hit Add button * synch the description after adding with the description in the list box of the 4 options available * fixes indentation a little -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5685|0 |1 is obsolete| | --- Comment #51 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-19 13:35:12 UTC --- Created attachment 5981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5981 Bug 5725 : Batch Modifications for Biblios commit 66282fed94564969f0368e27c7231116a2d1c0fe Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Tue Feb 22 08:43:24 2011 +1300 Bug 5725 : Follow up fixing permissions thanks to Paul Poulain commit 4d0241aea5be13b00abbc6100dc98ec87f816081 Author: Paul Poulain <paul.poulain@biblibre.com> Date: Mon Jan 10 17:22:31 2011 +0100 Bug 5725 follow up Owen noticed the batchedit was not working. This was because we made a patch months ago to change the GetBiblio API (the 1st returned arg is useless) This patch is not in main trunk, resulting in the error owen has noticed. This patch goes back to official API (even if it is clumsy : the patch we did does not apply anymore) commit 19b3e0ecc57af1c2151340328bf06e26882b7863 Author: Paul Poulain <paul.poulain@biblibre.com> Date: Wed Dec 15 20:47:21 2010 +0100 Bug 5725 : MT #2991 (Feature) Batch biblio modifications This patch add a new feature of batch biblio modifications, it permit to select biblios from basket, and modify fields of them setting Rebased to fix whitespace issues. Bug 5725 follow-up Fixes adresses comments 28 and 29 (from Owen) * add a link to tools-home * display the biblios before defining rules * add some help/change some wording * fixes result "Status" column (was a H:T:P => T:T glitch) and put the message on the top I also removed an unused variable Bug 5725 follow-upd, deal with leader As Owen comment 33 notices, leader update was not working. This patch fixes the problem (and fix a few reindenting glitches as well) Additional fixes for Bug 5725 - Batch modifications for Biblios - Correcting page title - Adding breadcrums - Adding sidebar menu (matching other batch mod pages) - Showing "loading" graphic during AJAX operations - Adding empty option to list of MARC tags so that onchange event will fire when the user is choosing 000 - Other structural markup changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #53 from Owen Leonard <oleonard@myacpl.org> 2011-10-19 14:05:40 UTC --- Something I didn't notice before: It doesn't seem you can set indicators. So if I want to create a new 650 tag and add it to a batch of records the resulting addition looks like this: =650 \\$aFiddle tunes When, AFAIK, it should look like this: =650 \0$aDivorced people Also, weren't we going to hide the option to modify 000 since it wasn't working? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |Rel_3_8 --- Comment #55 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:38:18 UTC --- Updating Version : This ENH will be for Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5981|0 |1 is obsolete| | --- Comment #58 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10610&action=edit Bug 5725 : Batch Modifications for Biblios commit 66282fed94564969f0368e27c7231116a2d1c0fe Author: Chris Cormack <chrisc@catalyst.net.nz> Date: Tue Feb 22 08:43:24 2011 +1300 Bug 5725 : Follow up fixing permissions thanks to Paul Poulain commit 4d0241aea5be13b00abbc6100dc98ec87f816081 Author: Paul Poulain <paul.poulain@biblibre.com> Date: Mon Jan 10 17:22:31 2011 +0100 Bug 5725 follow up Owen noticed the batchedit was not working. This was because we made a patch months ago to change the GetBiblio API (the 1st returned arg is useless) This patch is not in main trunk, resulting in the error owen has noticed. This patch goes back to official API (even if it is clumsy : the patch we did does not apply anymore) commit 19b3e0ecc57af1c2151340328bf06e26882b7863 Author: Paul Poulain <paul.poulain@biblibre.com> Date: Wed Dec 15 20:47:21 2010 +0100 Bug 5725 : MT #2991 (Feature) Batch biblio modifications This patch add a new feature of batch biblio modifications, it permit to select biblios from basket, and modify fields of them setting Rebased to fix whitespace issues. Bug 5725 follow-up Fixes adresses comments 28 and 29 (from Owen) * add a link to tools-home * display the biblios before defining rules * add some help/change some wording * fixes result "Status" column (was a H:T:P => T:T glitch) and put the message on the top I also removed an unused variable Bug 5725 follow-upd, deal with leader As Owen comment 33 notices, leader update was not working. This patch fixes the problem (and fix a few reindenting glitches as well) Additional fixes for Bug 5725 - Batch modifications for Biblios - Correcting page title - Adding breadcrums - Adding sidebar menu (matching other batch mod pages) - Showing "loading" graphic during AJAX operations - Adding empty option to list of MARC tags so that onchange event will fire when the user is choosing 000 - Other structural markup changes http://bugs.koha-community.org/show_bug.cgi?id=5727 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5697|0 |1 is obsolete| | --- Comment #60 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 10612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10612&action=edit Suggested change to Bug 5725 - Batch modifications for Biblios This modification changes the "Batch edit" button to a link in the "Selected items: " set alongside "add to a list," "place hold," etc. Instead of always batch editing all items, the user can select individual ones to be passed to the batch edit page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #62 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Just tried to test it. Patch doesn't apply. error: patch failed: C4/Biblio.pm:3876 error: C4/Biblio.pm: patch does not apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 --- Comment #64 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #63)

At the functional level there is not a duplicate with the 8015 bz ?.....

I dont think so, that is allowing you to modify the records on import (via staging). This one is about batch modifying existing biblios. (Like the batch modify for items we have). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10611|0 |1 is obsolete| | --- Comment #66 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 11732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11732&action=edit BZ5725 follow-up for comment 48 This small follow up: * removes "whole field" in subfield list except when dealing with a field <010 (that has no subfield) * add a missing string resulting in an "undefined" when user choosed 'Create field and subfield' and hit Add button * synch the description after adding with the description in the list box of the 4 options available * fixes indentation a little -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #68 from Chris Cormack <chris@bigballofwax.co.nz> --- Conflicts fixed, patches now all apply on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Cab Vinton <spl@metrocast.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |spl@metrocast.net -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #70 from Owen Leonard <oleonard@myacpl.org> --- I tested this and found that when I clicked "batch edit" from the cart the batchedit.pl page would load with a list of entries that read "no title," linking to /cgi-bin/koha/catalogue/detail.pl?biblionumber= -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8015 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vfernandes@keep.pt --- Comment #73 from Vitor Fernandes <vfernandes@keep.pt> --- This will be a nice improvement to 3.12. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Pierre Angot <tredok.pierre@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre@gmail.com --- Comment #76 from Pierre Angot <tredok.pierre@gmail.com> --- If someone can repair it, we can test it next week. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 marjorie barry-vila <marjorie.barry-vila@ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED CC| |jonathan.druart@biblibre.co | |m Resolution|--- |MOVED --- Comment #77 from Jonathan Druart <jonathan.druart@biblibre.com> --- I am working on a new version of this, based on bug 8015. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.