http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

CREATE DATABASE koha_master_upgraded; $ git checkout v3.20.00 $ mysql koha_master_upgraded < installer/data/mysql/kohastructure.sql

CREATE DATABASE koha_master_fresh; $ mysql koha_master_fresh < installer/data/mysql/kohastructure.sql

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44266|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44315&action=edit Bug 15095: marc_modificacation_template_actions DB not consistent between fresh and updated DB A review of the 3.20.00 + upgrade DB, compared to a fresh master install highlighted an inconsistency on that table. This is mysqldbcompare's output for it: - `action` enum('delete_field','update_field','move_field','copy_field','copy_and_replace_field') COLLATE utf8_unicode_ci DEFAULT NULL, ? ------------------------- ^^^^^^ + `action` enum('delete_field','update_field','move_field','copy_field') COLLATE utf8_unicode_ci NOT NULL, So one ENUM value is missing on fresh installs, and an upgraded one yields a DEFAULT NULL configuration for the 'action' column. To test: 1) have a v3.20.00 DB: 2) upgrade it to latest master by running: $ git checkout origin/master $ perl installer/data/mysql/updatedatabase.pl 3) Create a new DB 4) Run mysqldbcompare (you need mysql-utilities installed for that) $ mysqldbcompare --difftype=differ --server1=root@localhost \ --skip-data-check --skip-table-options \ --run-all-tests koha_master_upgraded:koha_master_fresh => FAIL: You will notice the marc_modification_template_actions discrepancy - Repeat from 1), but apply this patch on 2) before the upgrade. => SUCCESS: The DB's discrepancies are now irrelevant [1] - Sign off :-D [1] Only KEY definition order is 'wrong', but it is not relevant. Signed-off-by: Frederic Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.

CREATE DATABASE koha_master_upgraded; $ git checkout v3.20.00 $ mysql koha_master_upgraded < installer/data/mysql/kohastructure.sql

CREATE DATABASE koha_master_fresh; $ mysql koha_master_fresh < installer/data/mysql/kohastructure.sql

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15095 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44315|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44416&action=edit [PASSED QA] Bug 15095: marc_modificacation_template_actions DB not consistent between fresh and updated DB A review of the 3.20.00 + upgrade DB, compared to a fresh master install highlighted an inconsistency on that table. This is mysqldbcompare's output for it: - `action` enum('delete_field','update_field','move_field','copy_field','copy_and_replace_field') COLLATE utf8_unicode_ci DEFAULT NULL, ? ------------------------- ^^^^^^ + `action` enum('delete_field','update_field','move_field','copy_field') COLLATE utf8_unicode_ci NOT NULL, So one ENUM value is missing on fresh installs, and an upgraded one yields a DEFAULT NULL configuration for the 'action' column. To test: 1) have a v3.20.00 DB: 2) upgrade it to latest master by running: $ git checkout origin/master $ perl installer/data/mysql/updatedatabase.pl 3) Create a new DB 4) Run mysqldbcompare (you need mysql-utilities installed for that) $ mysqldbcompare --difftype=differ --server1=root@localhost \ --skip-data-check --skip-table-options \ --run-all-tests koha_master_upgraded:koha_master_fresh => FAIL: You will notice the marc_modification_template_actions discrepancy - Repeat from 1), but apply this patch on 2) before the upgrade. => SUCCESS: The DB's discrepancies are now irrelevant [1] - Sign off :-D [1] Only KEY definition order is 'wrong', but it is not relevant. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.