[Bug 7262] New: No calendar present in holidays module when there are quotes in title or description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Bug #: 7262 Summary: No calendar present in holidays module when there are quotes in title or description Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Holidays AssignedTo: henridamien@koha-fr.org ReportedBy: juan.sieira@xercode.es QAContact: ian.walls@bywatersolutions.com Using the holidays module, if a user inserts quotes under title or description of a holiday, the calendar does not appear, because of javascript errors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-24 17:03:13 UTC --- I can confirm this bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |juan.sieira@xercode.es --- Comment #2 from Juan Romay Sieira <juan.sieira@xercode.es> 2011-11-24 17:04:36 UTC --- Created attachment 6394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6394 Path to solve it Apply the patch and test the holidays module. Create a new holiday and insert double quotes under title or description. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-25 06:13:56 UTC --- Hi Juan, plz remember to set Importance to 'Patch sent' and Patch Status to 'Needs Signoff' after attaching your patch :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6394|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-01 19:20:32 UTC --- Created attachment 6493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6493 Bug 7262 - No calendar present in holidays module when there are quotes in title or description Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Nice patch, making use of the Template::Toolkit filters -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-14 16:56:30 UTC --- QA comment: works fine, don't break templates: $ prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok All tests successful. prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok All tests successful. passed QA patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7262 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tested ok in master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org