https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Bug 34479 depends on bug 29971, which changed state. Bug 29971 Summary: Remember selections across patron search pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29971 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #1 from Michael Adamyk <madamyk@ckls.org> --- This is definitely problematic when trying to do several different patron merges in a row. It remembers previous searches. Thus, after doing one merge, when you search and select two new patrons to merge, it tries to add in a third patron (the previous merge) to merge with them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34733 CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #3 from Rebecca Coert <rcoert@arlingtonva.us> --- This is an issue we discovered after migrating to 22.11. I'm seeing the same behavior that Michael described. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159261&action=edit Bug 34479: Move patron selection history to a re-useable file This patch takes some of the functionality for maintaining patron selections and moves it to a new file that can be used in other template files. It also introduces a new method for determining whether to delete the history after an operation is complete, along with an .inc file containing the checkbox that manages this Test plan: 1) Navigate to Patrons and run a search 2) Use the checkboxes to select some patrons and run the three different options in the menu bar: Add to patron list, Merge selected patrons, Batch patron modification. 3) For each operation, you should see a checkbox asking if you want to "Keep patrons selected for anew operation". N.B. For adding patrons to a list, you will only see this when selecting to add them to a new list 4) When you run the operations, if you select the checkbox to keep the patrons then when you return tho the patron search, those patrons should all be still selected. 5) If you don't check the box, when you return to the search, your patron selection history should be empty and no patrons should be selected N.B. If you have run a merge operation and elected to keep the patron history, you will only keep the patron who was kept -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- The patches above now allow users to choose whether to keep the history between operations - the default behaviour is that the history will not be kept. I've tried to refactor the code to allow us to use the same code in multiple places, the only difficulty is in adding patrons to an existing list as there is no easy place to add a checkbox to keep/delete the selection history. That may need breaking out in a separate bug to allow us to address the issue with the current patches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159261|0 |1 is obsolete| | --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159275&action=edit Bug 34479: Move patron selection history to a re-useable file This patch takes some of the functionality for maintaining patron selections and moves it to a new file that can be used in other template files. It also introduces a new method for determining whether to delete the history after an operation is complete, along with an .inc file containing the checkbox that manages this Test plan: 1) Navigate to Patrons and run a search 2) Use the checkboxes to select some patrons and run the three different options in the menu bar: Add to patron list, Merge selected patrons, Batch patron modification. 3) For each operation, you should see a checkbox asking if you want to "Keep patrons selected for anew operation". N.B. For adding patrons to a list, you will only see this when selecting to add them to a new list 4) When you run the operations, if you select the checkbox to keep the patrons then when you return tho the patron search, those patrons should all be still selected. 5) If you don't check the box, when you return to the search, your patron selection history should be empty and no patrons should be selected N.B. If you have run a merge operation and elected to keep the patron history, you will only keep the patron who was kept -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Hi Sharon, Thanks for testing! I have made some code changes as per your feedback: (In reply to Sharon Dugdale from comment #7)

when merging more than 2 patrons and clicking "keep patrons selected for a new operation" does not result in keeping patrons.

The patron you selected to keep should still be selected. However, this was only working in certain scenarios so I have fixed this and it should now work.

when merging 2 patrons after clicking on "keep...." then doing a patron search for a new list the "Patrons Selected" button says 1 but none are selected and none are brought through for a new merge.

This was the same error as above, just presenting itself in a different way.

when using batch patron modification: after clicking "keep patrons selected for a new operation" and you do another patron search and decide you do not actually want to keep them, if you then click the button "clear selected" at top of the page, choose new patrons you are directed to a message "No patron card numbers or borrowernumbers given" When you then click OK you are directed to the Batch Patron Modification landing page.

This is a good spot, I've run some tests and this is also happening in our master branch, not just with this new code I've added. This might need addressing in a separate bug or there may already be one. I'll have a look and see if one exists

when adding 3 patrons to a new list and merging 2 and clicking "keep..." the next page shows the "patrons selected" button as 1 but none are selected. If you then click on 2 new patrons to merge the "patrons selected" says 3 but only the 2 new ones are shown on the next page. I cannot tell if koha is also merging the unseen one (the one kept from the merge on the list)

As per the two comments above, this all seems to be stemming from the same error and should be fixed :) Let me know if this improves things -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Great, thanks Sharon! If you change the bug status to "Signed off" it will move into the QA queue and you'll get your name in the release notes for the version that this patch is released in :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159276|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 159295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159295&action=edit Bug 34479: Add new files to templates This patch adds two newly created files to the templates to allow the patron selection history to be wiped or persisted as appropriate Test plan as per previous commit Signed-off-by: Sharon Dugdale <sharon.dugdale@cumberland.gov.uk> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #18 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- The main problem is that adding the "saved patron" functionality was a behavior change in the first place, and if staff aren't aware of it or forget to pay attention to the "patrons selected" box, it can lead to data loss. Most notably, if a staff member merges Patron A and Patron B (we'll call the resulting account Patron AB), the merged patron remains selected. If they don't remember or realize they need to clear selected patrons before trying to do a separate merge of Patron C and Patron D, then Koha will merge Patron AB, C, and D all together, and Patron AB will be lost, with no good way to undo the action. The consequences to accidentally keeping an "old" selected patron when adding to a list or doing a batch modification are less permanent, but they will still lead to data errors that are likely to go unnoticed. In our library system, staff have also reported confusion about going to the patron page and finding that there are already "mysteriously" selected patrons. (Presumably, those patrons are still saved from an earlier action.) This means that even if a staff member is conscientious about clearing selected patrons in between actions, they might still have a leftover selected patron on their "first" action when they're not expecting to have one, and therefore are less likely to notice it. I think it's pretty reasonable to ask a staff member to actively confirm whether they still want to keep their selected patrons after performing an action on them. I imagine it's more common to perform one action on a patron set and then move on, rather than perform an additional, separate batch action on the exact same set. More importantly, it's safer to assume the staff member is finished with their selected patrons after performing an action, unless specified otherwise: -> If a staff member accidentally fails to keep their selected patrons, it may cause them a bit more work re-selecting the patrons, but their attempted action will fail and they will be able to correct the issue right away. ->If a staff member accidentally keeps their selected patrons when they don't intend to, their attempted action will succeed with unintended side effects that may go unnoticed and may not be easy to correct. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #20 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Thanks Emily and Michael for the input, I think its clear we need some sort of "protection" on this feature to prevent data loss. The alternative to the proposed solution is to put the patron selections behind a syspref to determine whether it should maintain the selections or not. I'm open to either, let me know any thoughts on whether a syspref would be a better option. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Just found one tiny unexpected behaviour: 1. Select x patrons 2. Add to patron list > new list 3. Tick "keep select patrons" box 4. Add to patron list > existing list => Patron selection is kept (we didn't ask for anything). Let say it's not a bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159295|0 |1 is obsolete| | Attachment #159451|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160906&action=edit Bug 34479: Add new files to templates This patch adds two newly created files to the templates to allow the patron selection history to be wiped or persisted as appropriate Test plan as per previous commit Signed-off-by: Sharon Dugdale <sharon.dugdale@cumberland.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160907|0 |1 is obsolete| | --- Comment #25 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 160982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160982&action=edit Bug 34479: Move patron selection history to a re-useable file This patch takes some of the functionality for maintaining patron selections and moves it to a new file that can be used in other template files. It also introduces a new method for determining whether to delete the history after an operation is complete, along with an .inc file containing the checkbox that manages this Test plan: 1) Navigate to Patrons and run a search 2) Use the checkboxes to select some patrons and run the three different options in the menu bar: Add to patron list, Merge selected patrons, Batch patron modification. 3) For each operation, you should see a checkbox asking if you want to "Keep patrons selected for anew operation". N.B. For adding patrons to a list, you will only see this when selecting to add them to a new list 4) When you run the operations, if you select the checkbox to keep the patrons then when you return tho the patron search, those patrons should all be still selected. 5) If you don't check the box, when you return to the search, your patron selection history should be empty and no patrons should be selected N.B. If you have run a merge operation and elected to keep the patron history, you will only keep the patron who was kept Signed-off-by: Sharon Dugdale <sharon.dugdale@cumberland.gov.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Michael Adamyk <madamyk@ckls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes issues with release notes| |patron search, and | |remembering the patrons | |selected after performing | |an action (such as Add to | |patron list, Merge selected | |patrons, Batch patron | |modification). Remembering | |selected patrons was | |introduced in Koha 22.11, | |bug 29971. | | | |Previously, the | |patrons selected after | |running an action were | |kept, and this either | |caused confusion, or could | |result in data loss if | |other actions were taken | |with new searches. | | | |Now, | |after performing a search | |and taking one of the | |actions available, you are | |now prompted with "Keep | |patrons selected for a new | |operation". When you return | |to the patron search: | |- If | |the patrons are kept: those | |patrons should still be | |selected | |- If the patrons | |aren't kept: the patron | |selection history is empty | |and no patrons are selected Keywords| |release-notes-needed --- Comment #28 from David Nind <david@davidnind.com> --- Could someone edit the "Text to go in the release notes"? I've had a go, but I wasn't involved in testing, so I'm not sure whether I am describing this correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | --- Comment #30 from David Nind <david@davidnind.com> --- (In reply to Matt Blenkinsop from comment #29)

Thanks for adding the text - just had a look and it looks good to me!

Thanks Matt! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #32 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up pushed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34479 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |RESOLVED --- Comment #35 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.