[Bug 37701] New: Log viewer doesn't show everything when Module 'All' is checked
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Bug ID: 37701 Summary: Log viewer doesn't show everything when Module 'All' is checked Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Transaction logs Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Find a record and do 1 edit to the record. 2. Also do 1 edit to an item on that record. 3. From the navbar on the left click 'Modification log' 4. You should see both the item and record modifications in log. 5. Notice also that the 'Catalog' module checkbox is checked by default 6. Now check 'All' instead and click 'Submit' 7. Now the item modification is gone, you only see the record modification. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- In viewlog.pl there is 'object_type'. It is only passed when you come to the log viewer from the record link. I think it may be unnessesary? Without it you are not able to get item level info. related to the bib when you come to the log viewer in any other way than directly for the 'Modification log' link on the record detail page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170573&action=edit Bug 37701: Remove object_type from viewlog To test: 1. Find a record and do 1 edit to the record. 2. Also do 1 edit to an item on that record. 3. From the navbar on the left click 'Modification log' 4. You should see both the item and record modifications in log. 5. Notice also that the 'Catalog' module checkbox is checked by default 6. Now check 'All' instead and click 'Submit' 7. Now the item modification is gone, you only see the record modification. 8. APPLY PATCH and restart_all 9. Try again, you should now always see item information when viewing the log. 10. Test the log viewer from the link in on the record detail page. 11. Also test by going directly to the Log viewer tool. ( Tools > Log viewer) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170573|0 |1 is obsolete| | --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 170574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170574&action=edit Bug 37701: Remove object_type from viewlog To test: 1. Find a record and do 1 edit to the record. 2. Also do 1 edit to an item on that record. 3. From the navbar on the left click 'Modification log' 4. You should see both the item and record modifications in log. 5. Notice also that the 'Catalog' module checkbox is checked by default 6. Now check 'All' instead and click 'Submit' 7. Now the item modification is gone, you only see the record modification. 8. APPLY PATCH and restart_all 9. Try again, you should now always see item information when viewing the log. 10. Test the log viewer from the link in on the record detail page. 11. Also test by going directly to the Log viewer tool. ( Tools > Log viewer) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@ptfs-europe.co |y.org |m CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Taking a look here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This causes the following error when running a "All" report without object on the URL: Can't call method "items" on an undefined value at /kohadevbox/koha/tools/viewlog.pl line 138 To reproduce: 1) Apply patch 2) Run a normal "All" report" from: http://localhost:8081/cgi-bin/koha/tools/viewlog.pl The line may or may not need to be: if ( @modules == 1 && $modules[0] eq 'CATALOGUING' ) { From: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10352&attachment=97148 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- The initial patch on bug 10352 had that line, but then it was changed to use the object_type parameter so that there was a way to differentiate between searching for a bib record (and all attached items), and searching for a specific item, when there's overlap between the biblionumbers in the system and the itemnumbers in the system - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352#c12 Could we go the opposite direction and expose the object_type paramater in the UI instead? Maybe a checkbox next to the object field, something like, "Search for biblio object and all attached items"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Oops, sorry for the accidental status change! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lucas@bywatersolutions.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37701 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org