[Bug 37810] New: Some SUSHI providers return ServiceActive instead of Service_Active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Bug ID: 37810 Summary: Some SUSHI providers return ServiceActive instead of Service_Active Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 170947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170947&action=edit Bug 37810: Consider ServiceActive on status response Some SUSHI providers return ServiceActive instead of the documented Service_Active: https://countermetrics.stoplight.io/docs/counter-sushi-api/f0dd30f814944-ser... This ensures the test connection does not fail regardless of what is used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171717&action=edit Bug 37810: Add test Test plan: 1) Apply only tests patch, run: prove t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t 2) Verify tests fail 3) Apply fix patch 4) Run tests again, verify they pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170947|0 |1 is obsolete| | --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171718&action=edit Bug 37810: Consider ServiceActive on status response Some SUSHI providers return ServiceActive instead of the documented Service_Active: https://countermetrics.stoplight.io/docs/counter-sushi-api/f0dd30f814944-ser... This ensures the test connection does not fail regardless of what is used -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_11_candidate, | |rel_24_05_candidate --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Adding 24.05 and 23.11 release candidate keywords as this improves how the SUSHI response is handled widening the pool of providers Koha is able to work with. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- The tests fail with both patches applied: prove t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t .. # Failed test at t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t line 72. # got: 'https://service_url.com/reports/tr_j1?customer_id=ID123&requestor_id=REQID123&api_key=APIKEY&begin_date=2023-08&end_date=2023-09&platform=emPARhPJsVEGAhPhc67LuGhjn5jCFc11a8x_mK0D3tWSVz3ike8PjaPj0baZfYtyVoJEEoob5qzY2' # expected: 'https://service_url.com/reports/tr_j1?customer_id=ID123&requestor_id=REQID123&api_key=APIKEY&begin_date=2023-08&end_date=2023-09' # Looks like you failed 1 test of 1. t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t .. 1/2 # Failed test '_build_url_query' # at t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t line 77. # Looks like you failed 1 test of 2. t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=2, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.93 cusr 0.18 csys = 1.14 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Hi David, thank you. I believe you may need to pull latest main as it appears you're missing the last 2 follow-up patches from bug 37856 that fix those test errors. The test error seems to be the one fixed by those patches, are you able to confirm please? i.e. make sure main is up to date and test again. Happy to look again in case I'm mistaken. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171717|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 172198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172198&action=edit Bug 37810: Add test Test plan: 1) Apply only tests patch, run: prove t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t 2) Verify tests fail 3) Apply fix patch 4) Run tests again, verify they pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171718|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 172199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172199&action=edit Bug 37810: Consider ServiceActive on status response Some SUSHI providers return ServiceActive instead of the documented Service_Active: https://countermetrics.stoplight.io/docs/counter-sushi-api/f0dd30f814944-ser... This ensures the test connection does not fail regardless of what is used Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 --- Comment #9 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #6)
Hi David, thank you. I believe you may need to pull latest main as it appears you're missing the last 2 follow-up patches from bug 37856 that fix those test errors. The test error seems to be the one fixed by those patches, are you able to confirm please? i.e. make sure main is up to date and test again. Happy to look again in case I'm mistaken. Thanks!
Things are working now, so this must have been the case. Now signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172198|0 |1 is obsolete| | --- Comment #10 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172272&action=edit Bug 37810: Add test Test plan: 1) Apply only tests patch, run: prove t/db_dependent/Koha/ERM/EUsage/UsageDataProvider.t 2) Verify tests fail 3) Apply fix patch 4) Run tests again, verify they pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172199|0 |1 is obsolete| | --- Comment #11 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172273&action=edit Bug 37810: Consider ServiceActive on status response Some SUSHI providers return ServiceActive instead of the documented Service_Active: https://countermetrics.stoplight.io/docs/counter-sushi-api/f0dd30f814944-ser... This ensures the test connection does not fail regardless of what is used Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 172274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172274&action=edit Bug 37810: (QA follow-up) Tidy Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.07 released in| | CC| |alexbuckley@catalyst.net.nz --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Backported to 24.05.x for 24.05.07 Note: I cannot see the 'Pushed to oldstable' in the status dropdown, so I cannot set that status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You need to set Pushed to stable first, then you can set "pushed to oldstable". It's a workflow feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.07 |24.11.00,24.05.07,23.11.12 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 --- Comment #17 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #15)
You need to set Pushed to stable first, then you can set "pushed to oldstable". It's a workflow feature.
Thank you very much Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |Needs documenting --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37810 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |aude.charillon@openfifth.co | |.uk Status|Needs documenting |RESOLVED --- Comment #19 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No updates to the Koha Manual needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org