[Bug 16122] New: Item record needs to keep Local Use count
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Bug ID: 16122 Summary: Item record needs to keep Local Use count Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Like the "issues" field in the items table, there should be a field for "local_use" to keep the count of local uses. While this information is kept in the statistics table, it is a task to acquire, and if a library wants to keep bloat down on their tables, the statistics are pruned on a regular schedule, which means loss of valuable data. This counter would keep that valuable information in one field in each item record, rather than having a separate field for each instance in the statistics table. Unless it is vital to someone to know the exact moment a local use occurred, I am suggesting that this piece of information not be recorded in the statistics table any longer. This would significantly reduce the growth of the statistics table in general. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think an option would be ok, but I am against removing it - the local use information in statistics will allow to look up the timeframe (local uses in the last x months, years...) which is useful information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Perhaps a switch to turn the statistic on/off? But add the counter to the record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could work :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #4 from Andrew <andrew@bywatersolutions.com> --- I absolutely agree if would be handy to have a local use number in the record -- and then to show that number on moredetail.pl. But I also agree with Katrin that I don't see why we would remove those transactions from the statistics table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Read the second paragraph. It addresses this question. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- My feeling is that a simple counter loses meaning the longer you keep the data. What's better? 5 local uses in 10 years or 5 in one? With a simple counter, there is no way to tell. I think issues might give an indicator about 'use' of the book (when you might want to replace it), but not sure the local_use is interesting in the same way. That said, we could split the circulation log preference to not record. Is the size of the data in statistics really that much of an issue? I seem to remember that some libraries have kept their data without pruning ever and have to say we don't prune either and have some systems running for almost 10 years now. It's only used for statistics, so it doesn't slow anything down. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #7 from Christopher Brannon <cbrannon@cdalibrary.org> --- The bigger the system, the more data you have to sift through, and it can make reports very sluggish. I'd be fine if it were kept in the logs, if there were some mechanism that could prune the logs of items that are deleted, and the pruning could be fine tuned as needed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I get a feeling that opinions on the stats tables vary wildly. As I said, I would not prune them, but only anonymize them if necessary. Having an idea about when something happened seems important to me. Having jobs with different options make sense. BTW: as far as I know it won't free space with MySQL if you delete lines. So that should not be a reason? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #9 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- *** Bug 18668 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149281&action=edit Bug 16122: Add localuse column to items and deleteditems -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149282&action=edit Bug 16122: API and Schema updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149283&action=edit Bug 16122: Increment items.localuse in AddReturn -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 149284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149284&action=edit Bug 16122: Add display to holdings/otherholdings and Table settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | CC| |lucas@bywatersolutions.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- I've added some patches that will add an items.localuse column to the items table and also display this in the holdings/other holdings table. Leaving as assigned as this will still need adjusted/updated tests. Not sure how to deal with the information that is already available via statistics. I really think we should leave the statistics table as is. However we may need a script or DB update that will make the new items.localuse column congruent with what can be derived from statistics. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #15 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #14)
I've added some patches that will add an items.localuse column to the items table and also display this in the holdings/other holdings table.
Leaving as assigned as this will still need adjusted/updated tests.
Not sure how to deal with the information that is already available via statistics. I really think we should leave the statistics table as is. However we may need a script or DB update that will make the new items.localuse column congruent with what can be derived from statistics.
In my opinion, it would be good to have an option to convert those stats over to the new counters. It would also be good to have the option to clear out those stats from the statistics table once converted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #16 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #8)
I get a feeling that opinions on the stats tables vary wildly. As I said, I would not prune them, but only anonymize them if necessary. Having an idea about when something happened seems important to me. Having jobs with different options make sense.
BTW: as far as I know it won't free space with MySQL if you delete lines. So that should not be a reason?
Hmmmm...this is news to me. I've always known data to take up space. Not sure how you can remove lines of data and not free up space. That is a huge problem if that is the case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #17 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Lucas Gass from comment #14)
I've added some patches that will add an items.localuse column to the items table and also display this in the holdings/other holdings table.
Leaving as assigned as this will still need adjusted/updated tests.
Not sure how to deal with the information that is already available via statistics. I really think we should leave the statistics table as is. However we may need a script or DB update that will make the new items.localuse column congruent with what can be derived from statistics.
I should clarify, it would be good to at least capture the existing stats and convert them to the counters before those stats are eliminated through table clean up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Christopher Brannon from comment #17)
(In reply to Lucas Gass from comment #14)
I've added some patches that will add an items.localuse column to the items table and also display this in the holdings/other holdings table.
Leaving as assigned as this will still need adjusted/updated tests.
Not sure how to deal with the information that is already available via statistics. I really think we should leave the statistics table as is. However we may need a script or DB update that will make the new items.localuse column congruent with what can be derived from statistics.
I should clarify, it would be good to at least capture the existing stats and convert them to the counters before those stats are eliminated through table clean up.
https://stackoverflow.com/questions/1270944/mysql-innodb-not-releasing-disk-... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Katrin Fischer from comment #18)
(In reply to Christopher Brannon from comment #17)
(In reply to Lucas Gass from comment #14)
I've added some patches that will add an items.localuse column to the items table and also display this in the holdings/other holdings table.
Leaving as assigned as this will still need adjusted/updated tests.
Not sure how to deal with the information that is already available via statistics. I really think we should leave the statistics table as is. However we may need a script or DB update that will make the new items.localuse column congruent with what can be derived from statistics.
I should clarify, it would be good to at least capture the existing stats and convert them to the counters before those stats are eliminated through table clean up.
https://stackoverflow.com/questions/1270944/mysql-innodb-not-releasing-disk- space-after-deleting-data-rows-from-table
Well, that is just insane. REGARDLESS, I know for a fact that table queries on smaller tables run faster. Tables must be pruned on a regular basis to maintain optimal performance. This bug will ensure needed data is maintained over time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33500 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33500 [Bug 33500] Failing test for t/db_dependent/Circulation.t when RecordLocalUseOnReturn is set to record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150231&action=edit Bug 16122: Increment localuse when checking out to stats patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- TEST PLAN: To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149281|0 |1 is obsolete| | --- Comment #22 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 150232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150232&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149282|0 |1 is obsolete| | --- Comment #23 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 150233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150233&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149283|0 |1 is obsolete| | --- Comment #24 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 150234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150234&action=edit Bug 16122: Increment items.localuse in AddReturn Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149284|0 |1 is obsolete| | --- Comment #25 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 150235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150235&action=edit Bug 16122: Add display to holdings/otherholdings and Table settings Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150231|0 |1 is obsolete| | --- Comment #26 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 150236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150236&action=edit Bug 16122: Increment localuse when checking out to stats patron Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #27 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works like a charm! Cool beans! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #28 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- FYI, I filed bug 32440 suggesting cleanup_database get enhanced to allow selective deletion from statistics based on type. Right now (per bug 19008) cleanup_database can delete all statistics entries older than a specified interval, but it makes sense to me to allow an additional constraint based on statistics.type. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #29 from Lucas Gass <lucas@bywatersolutions.com> --- Christopher, Thanks for you sign-off! I do need to reset this one to ASSIGNED as it still needs some work. -Unit tests -Need to figure out what to do about the existing data in the stats table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #30 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150623&action=edit Bug 16122: Add maintenance script to update items.localuse from stats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150623|0 |1 is obsolete| | --- Comment #31 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 150693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150693&action=edit Bug 16122: Add maintenance script to update items.localuse from stats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #32 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Lucas, can you provide a test plan for that last patch? If so I'd be happy to sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #33 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Tried to test this, but the patch does not apply. Applying: Bug 16122: Add localuse column to items and deleteditems Applying: Bug 16122: API and Schema updates Applying: Bug 16122: Increment items.localuse in AddReturn Applying: Bug 16122: Add display to holdings/otherholdings and Table settings Using index info to reconstruct a base tree... M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging admin/columns_settings.yml Applying: Bug 16122: Increment localuse when checking out to stats patron error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 16122: Increment localuse when checking out to stats patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #34 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa from comment #33)
Tried to test this, but the patch does not apply.
Applying: Bug 16122: Add localuse column to items and deleteditems Applying: Bug 16122: API and Schema updates Applying: Bug 16122: Increment items.localuse in AddReturn Applying: Bug 16122: Add display to holdings/otherholdings and Table settings Using index info to reconstruct a base tree... M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging admin/columns_settings.yml Applying: Bug 16122: Increment localuse when checking out to stats patron error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 16122: Increment localuse when checking out to stats patron
This still applies cleanly for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #35 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa from comment #32)
Lucas, can you provide a test plan for that last patch? If so I'd be happy to sign off.
To test: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table Using this report can help: SELECT COUNT( IF( statistics.type = 'localuse', statistics.itemnumber, NULL ) ) AS 'local use count' FROM statistics WHERE statistics.itemnumber=<<itemnumber>> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #36 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Hmmm, I'm still getting the error when I try to apply it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, I am having the same issue as Emily on current master: Applying: Bug 16122: Add display to holdings/otherholdings and Table settings Using index info to reconstruct a base tree... M admin/columns_settings.yml M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging admin/columns_settings.yml Applying: Bug 16122: Increment localuse when checking out to stats patron error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 16122: Increment localuse when checking out to stats patron hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-16122-Increment-localuse-when-checking-out-to--o5eeizs8.patch We might be missing something that is in your repository. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150235|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #38 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 153193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153193&action=edit Bug 16122: Add display and increment localuse -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #39 from Lucas Gass <lucas@bywatersolutions.com> --- rebased for current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150232|0 |1 is obsolete| | --- Comment #40 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153196&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150233|0 |1 is obsolete| | --- Comment #41 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153197&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150234|0 |1 is obsolete| | --- Comment #42 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153198&action=edit Bug 16122: Increment items.localuse in AddReturn Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #150693|0 |1 is obsolete| | --- Comment #43 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153199&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153193|0 |1 is obsolete| | --- Comment #44 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 153200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153200&action=edit Bug 16122: Add display and increment localuse Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Steve, OSLRI, USA <sspohn@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sspohn@oslri.net --- Comment #45 from Steve, OSLRI, USA <sspohn@oslri.net> --- +1 for items.localuse counter field from Ocean State Libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #46 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #47 from Lucas Gass <lucas@bywatersolutions.com> --- This still applies cleanly, what would it take to get some QA eyes on it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #47)
This still applies cleanly, what would it take to get some QA eyes on it?
Stop commenting so it goes down in the list - I have been working on bugs first and oldest next ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #49 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #48)
(In reply to Lucas Gass from comment #47)
This still applies cleanly, what would it take to get some QA eyes on it?
Stop commenting so it goes down in the list - I have been working on bugs first and oldest next ;)
Ha. fair enough! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item record needs to keep |Item record needs to keep |Local Use count |local use count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153196|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158466&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153197|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158467&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153198|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158468&action=edit Bug 16122: Increment items.localuse in AddReturn Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153199|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158469&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153200|0 |1 is obsolete| | --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158470&action=edit Bug 16122: Add display and increment localuse Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158471&action=edit Bug 16122: (QA follow-up) Perltidy, fix spelling and db comments * COMMENT in database update and kohastructure didn't match up * Fix some localuse to local use in text/descriptions * Perltidy Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27992 Status|Signed Off |Failed QA --- Comment #56 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- **ATTENTION** We might want to push the bugfix from bug 27992 first, although it might create a small conflict in Circulation.pm here. 1) QA test script Still applies, but requires perltidy: WARN C4/Circulation.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 1104, now: 1108) WARN installer/data/mysql/atomicupdate/bug_16122_atomicupdate.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 10) WARN misc/maintenance/update_localuse_from_statistics.pl WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 8) Fixed in a follow-up. Also fixed: * COMMENT in database update and kohastructure didn't match up * some spelling 2) We need unit tests. (blocker) 3) Column configuration page for items table on detail page needs to be updated. Suggestion: I'd hide this column by default for existing and new installations to not grow the items table. 4) Maintenance script +use strict; +use warnings; Should be: use Modern::Perl; It feels like this should have a verbose option and maybe a warning/hint that existing entries in items will be overwritten? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Will still need to test some more once we have the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158466|0 |1 is obsolete| | Attachment #158467|0 |1 is obsolete| | Attachment #158468|0 |1 is obsolete| | Attachment #158469|0 |1 is obsolete| | Attachment #158470|0 |1 is obsolete| | Attachment #158471|0 |1 is obsolete| | --- Comment #58 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161001&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #59 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161002&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #60 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161003&action=edit Bug 16122: Increment items.localuse in AddReturn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #61 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161004&action=edit Bug 16122: Add display and Table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #62 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161005&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #63 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161006&action=edit Bug 16122: Perltidy and spelling To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. To test maintainence script: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161001|0 |1 is obsolete| | --- Comment #64 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161144&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161002|0 |1 is obsolete| | --- Comment #65 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161145&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161003|0 |1 is obsolete| | --- Comment #66 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161146&action=edit Bug 16122: Increment items.localuse in AddReturn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161004|0 |1 is obsolete| | --- Comment #67 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161147&action=edit Bug 16122: Add display and Table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161005|0 |1 is obsolete| | --- Comment #68 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161148&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161006|0 |1 is obsolete| | --- Comment #69 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161149&action=edit Bug 16122: Perltidy and spelling To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. To test maintainence script: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #70 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161150&action=edit Bug 16122: AddReturn unit tests and small fix in sub AddReturn -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #71 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 161151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161151&action=edit Bug 16122: CanBookBeIssued unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #72 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- When I have RecordLocalUseOnCheckin enabled and check an item out to a statistical patron, Local Use for that item goes up by 2. That seems wrong, but also doesn't appear to be new, exactly. Without this patch, if I have RecordLocalUseOnCheckin enabled and check an item out to a statistical patron I get 2 local use lines in statistics. I'm going to file a new bug for this issue, I only mention it here because I almost marked this one Failed QA thinking it was new behavior rather than old behavior made more obvious. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161144|0 |1 is obsolete| | --- Comment #73 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161153&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161145|0 |1 is obsolete| | --- Comment #74 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161154&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161146|0 |1 is obsolete| | --- Comment #75 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161155&action=edit Bug 16122: Increment items.localuse in AddReturn Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161147|0 |1 is obsolete| | --- Comment #76 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161156&action=edit Bug 16122: Add display and Table settings Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161148|0 |1 is obsolete| | --- Comment #77 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161157&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161149|0 |1 is obsolete| | --- Comment #78 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161158&action=edit Bug 16122: Perltidy and spelling To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. To test maintainence script: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161150|0 |1 is obsolete| | --- Comment #79 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161159&action=edit Bug 16122: AddReturn unit tests and small fix in sub AddReturn Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161151|0 |1 is obsolete| | --- Comment #80 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 161160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161160&action=edit Bug 16122: CanBookBeIssued unit test Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35839 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35840 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #81 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #72)
When I have RecordLocalUseOnCheckin enabled and check an item out to a statistical patron, Local Use for that item goes up by 2. That seems wrong, but also doesn't appear to be new, exactly. Without this patch, if I have RecordLocalUseOnCheckin enabled and check an item out to a statistical patron I get 2 local use lines in statistics. I'm going to file a new bug for this issue, I only mention it here because I almost marked this one Failed QA thinking it was new behavior rather than old behavior made more obvious.
Thanks Andrew! I have added a patch to Bug 35840 in an attempt to fix this issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 [Bug 35840] Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #82 from Lucas Gass <lucas@bywatersolutions.com> --- This needs to be BLOCKED until Bug 35840 moves. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35950 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 [Bug 35950] Move the handling of statistics patron logic out of CanBookBeIssued -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #83 from Lucas Gass <lucas@bywatersolutions.com> --- Needs rebased/refactored on top of Bug 35950. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161153|0 |1 is obsolete| | --- Comment #84 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163072&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161154|0 |1 is obsolete| | --- Comment #85 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163073&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #86 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163074&action=edit Bug 16122: Increment items.localuse -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161156|0 |1 is obsolete| | --- Comment #87 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163075&action=edit Bug 16122: Add display and Table settings Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161157|0 |1 is obsolete| | --- Comment #88 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163076&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #89 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 163077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163077&action=edit Bug 16122: Add unit test To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. To test maintainence script: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161155|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161159|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163072|0 |1 is obsolete| | --- Comment #90 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163243&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163073|0 |1 is obsolete| | --- Comment #91 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163244&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163074|0 |1 is obsolete| | --- Comment #92 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163245&action=edit Bug 16122: Increment items.localuse Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163075|0 |1 is obsolete| | --- Comment #93 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163246&action=edit Bug 16122: Add display and Table settings Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163076|0 |1 is obsolete| | --- Comment #94 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163247&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163077|0 |1 is obsolete| | --- Comment #95 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 163248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163248&action=edit Bug 16122: Add unit test To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. To test maintainence script: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163243|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163296&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163244|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163297&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163245|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163298&action=edit Bug 16122: Increment items.localuse Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163246|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163299&action=edit Bug 16122: Add display and Table settings Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163247|0 |1 is obsolete| | --- Comment #100 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163300&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163248|0 |1 is obsolete| | --- Comment #101 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163301&action=edit Bug 16122: Add unit test To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. To test maintainence script: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #102 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163302&action=edit Bug 16122: Tidy changed code blocks Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #103 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 163303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163303&action=edit Bug 16122: Add note to database update to point out new script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #104 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as designed, QA scripts are happy, tests are passing and new coverage is added. Passing QA, well perserverred Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Status|Passed QA |Patch doesn't apply Depends on| |33568 --- Comment #105 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, but the detail page requires some more work due to: Bug 33568 - Use the REST API to display items on the biblio detail view Please rebase and push back into my queue. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163296|0 |1 is obsolete| | --- Comment #106 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165313&action=edit Bug 16122: Add localuse column to items and deleteditems Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163297|0 |1 is obsolete| | --- Comment #107 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165314&action=edit Bug 16122: API and Schema updates Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163298|0 |1 is obsolete| | --- Comment #108 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165315&action=edit Bug 16122: Increment items.localuse Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163299|0 |1 is obsolete| | --- Comment #109 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165316&action=edit Bug 16122: Add display and Table settings Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163300|0 |1 is obsolete| | --- Comment #110 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165317&action=edit Bug 16122: Add maintenance script to update items.localuse from stats Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163301|0 |1 is obsolete| | --- Comment #111 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165318&action=edit Bug 16122: Add unit test To test: 1. Apply patch, updatedatabase & schema, restart all Services 2. Go to Administration > Table setting. Find the holdings table ( Catalog > holdings_table ) and turn the local use column on. 3. Go to an item record and notice the column 'Local uses' 4. Turn the system preference RecordLocalUseOnReturn Off. 5. Check in an item that is not checkout out. No local use should be recorded for the item. 6. Turn RecordLocalUseOnReturn on and check in an item that is not checked out. Local use on that item should increment by 1. 7. Create a statistical patron and check an item out to them. Local use should increment by 1. 8. Go to /api/v1/items?external_id={barcode} and make sure the numbers for localuse look correct. To test maintainence script: 1. Without the patch, have RecordLocalUseOnReturn on. 2. Check in some items to record localuse in the stats table. Keep note of those stats. 3. Apply the patches, updatedatabase. 4. Run the maintenance script, perl update_localuse_from_statistics.pl 5. Now check that items.localuse is congruent with what is in the stats table Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163302|0 |1 is obsolete| | --- Comment #112 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165319&action=edit Bug 16122: Tidy changed code blocks Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163303|0 |1 is obsolete| | --- Comment #113 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 165320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165320&action=edit Bug 16122: Add note to database update to point out new script Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #114 from Lucas Gass <lucas@bywatersolutions.com> --- rebased for current main and back to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate |release-notes-needed --- Comment #115 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, DBIC changes here are mixed in with other changes, so I have kept the patch. dbic comes up empty. I have been told it would be better to regenerate usually so timestamps etc. match -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #116 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a fan of scripts that update data having a --confirm switch, this one just has the -h. I know that you should always run the latter first, so leaving this more as a note and suggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #117 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #118 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #115)
Hm, DBIC changes here are mixed in with other changes, so I have kept the patch. dbic comes up empty. I have been told it would be better to regenerate usually so timestamps etc. match
I just figured out what happens when you don't run dbic again - it causes issues! - please only strictly separate patches in future! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709 [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|36709 | --- Comment #119 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #116)
I am a fan of scripts that update data having a --confirm switch, this one just has the -h. I know that you should always run the latter first, so leaving this more as a note and suggestion.
I will add a confirm flag: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709 [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 --- Comment #120 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #118)
(In reply to Katrin Fischer from comment #115)
Hm, DBIC changes here are mixed in with other changes, so I have kept the patch. dbic comes up empty. I have been told it would be better to regenerate usually so timestamps etc. match
I just figured out what happens when you don't run dbic again - it causes issues! - please only strictly separate patches in future! :)
Noted. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36709 [Bug 36709] Add --confirm flag to update_localuse_from_statistics.pl script -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #121 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This patch adds a new release notes| |separate field for | |recording local use to the | |items table. It will be | |hidden from the holdings | |table by default but can be | |made visible using the | |table configuration | |settings. | | | |This includes a | |new CLI script to update | |the | |`update_localuse_from_stati | |stics.pl` that can be used | |to set the new | |items.localuse field with | |information from the | |statistics table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37790 [Bug 37790] Prevent indexing and holds queue updates when running update_localuse_from_statistics.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Bug 16122 depends on bug 35840, which changed state. Bug 35840 Summary: Local use is double-counted when using both RecordLocalUseOnReturn and statistical patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35840 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Bug 16122 depends on bug 35950, which changed state. Bug 35950 Summary: Move the handling of statistics patron logic out of CanBookBeIssued https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35950 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16122 Bug 16122 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org