[Bug 31270] New: Terminology: Standardize on self-registration or self registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Bug ID: 31270 Summary: Terminology: Standardize on self-registration or self registration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Currently we have a bit of a mix in the templates and the notices and I think it would be nice to standardize. I found this, but happy with either as long as we are consistent: https://www.merriam-webster.com/dictionary/self-registering -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe some native speaker can help? According to coding guidelines we use AE spelling. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- On mattermost the conclusion was to use self-... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.hunstein@bsz-bw.de Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 --- Comment #3 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 177063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177063&action=edit Bug 31270: standardize on self-registration updates description "selfregistration" to "self-registration" to test: - go to installer/data/mysql/updatedatabase.pl - check there are descriptions in the form "selfregistration" - apply patch - descriptions are in the form "self-registration" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177063|0 |1 is obsolete| | --- Comment #4 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 177074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177074&action=edit Bug 31270: standardize on self-registration updates description "selfregistration" to "self-registration" to test: - go to installer/data/mysql/updatedatabase.pl - check there are descriptions in the form "selfregistration" - apply patch - descriptions are in the form "self-registration" Signed-off-by: William Lavoie <william.lavoie@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Assignee|oleonard@myacpl.org |nicolas.hunstein@bsz-bw.de CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA comment: Not sure how useful it is to change old dbrevs in updatedatabase. Note that I see various occurrences in the codebase for selfregistration and "self registration". I would expect this report to change them too. Note that updating old release notes and old dbrevs might not be needed imo. But references in active templates etc would. Please use the Assignee field to put your name in. Now I did for you:) Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 --- Comment #6 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 177115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177115&action=edit Bug 31270: update "self reg" updates string "self reg" to "self-reg" to test: - got to installer/data/mysql/mandatory/sysprt/db_dependent/Koha/Patronefs.sql, koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref, misc/cronjobs/cleanup_database.pl and t/db_dependent/Koha/Patron.t - check there are strings in the form "self reg" - apply patch - strings are in the form "self-reg" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177115|0 |1 is obsolete| | --- Comment #7 from Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> --- Created attachment 177116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177116&action=edit Bug 31270: update "self reg" updates string "self reg" to "self-reg" to test: - got to installer/data/mysql/mandatory/sysprt/db_dependent/Koha/Patronefs.sql, koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref, misc/cronjobs/cleanup_database.pl and t/db_dependent/Koha/Patron.t - check there are strings in the form "self reg" - apply patch - strings are in the form "self-reg" @ Marcel de Rooy: Thank you very much for informing me that correcions in "updatedatabase" are neither necessary nor helpful and for adding my name to the Assignee field. May you please tell me where I can still find the description "Selfregistration"? Currently I can only find it in the release notes and dbrevs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177074|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 177149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177149&action=edit Bug 31270: Terminology - use "self-registration" Standardize on the use of "self-registration" (and variations) for consistency in the OPAC and staff interface, instead of "self registration". Test plan: 1. Check the codebase for occurences of "self reg": . git grep "self reg" . git grep "selfreg" . git grep "Self reg" . git grep "Selfreg" 2. Note the occurences, excluding code comments, previous database updates, and previous release notes. 3. Search the system preferences for "self reg" and "selfreg". 4. Note the occurences in the results for the system preference descriptions (excluding system preference names) for: - PatronSelfRegistrationDefaultCategory - PatronSelfRegistrationEmailMustBeUnique - PatronSelfRegistrationLibraryList - PatronSelfRegistrationPrefillForm 5. Note the system preferences category heading for the OPAC - "Self registration and modification". 6. Apply the patch. 7. Repeat steps 1 to 5. There should now be no occurences (excluding code comments, previous database updates, and previous release notes). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 177150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177150&action=edit Bug 31270: (follow-up) Fix description for PatronSelfRegistrationLibraryList Test plan: 1. Check that the updated description for the PatronSelfRegistrationLibraryList system preference makes sense. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #177116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes any occurrences release notes| |of "self registration" (and | |variations) and changes | |these to | |"self-registration" for | |consistency in the OPAC and | |staff interface. | | | |It also | |updates the system | |preference description for | |PatronSelfRegistrationLibra | |ryList. --- Comment #10 from David Nind <david@davidnind.com> --- I've updated the commit message so that it is a bit more consistent with the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages I also added a follow-up for the PatronSelfRegistrationLibraryList system preference (as "Enable the self-registration..." is incorrect), and also fixed the rest of the description at the same time. As far as I can see, there are no other occurrences to change. (For PatronSelfRegistrationDefaultCategory, I think the values for the patron categories dropdown list (including Self registration) come from the sample data used by KTD.) I've also updated the terminology guidelines https://wiki.koha-community.org/wiki/Terminology#S -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177149|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177375&action=edit Bug 31270: Terminology - use "self-registration" Standardize on the use of "self-registration" (and variations) for consistency in the OPAC and staff interface, instead of "self registration". Test plan: 1. Check the codebase for occurences of "self reg": . git grep "self reg" . git grep "selfreg" . git grep "Self reg" . git grep "Selfreg" 2. Note the occurences, excluding code comments, previous database updates, and previous release notes. 3. Search the system preferences for "self reg" and "selfreg". 4. Note the occurences in the results for the system preference descriptions (excluding system preference names) for: - PatronSelfRegistrationDefaultCategory - PatronSelfRegistrationEmailMustBeUnique - PatronSelfRegistrationLibraryList - PatronSelfRegistrationPrefillForm 5. Note the system preferences category heading for the OPAC - "Self registration and modification". 6. Apply the patch. 7. Repeat steps 1 to 5. There should now be no occurences (excluding code comments, previous database updates, and previous release notes). Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177150|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 177376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177376&action=edit Bug 31270: (follow-up) Fix description for PatronSelfRegistrationLibraryList Test plan: 1. Check that the updated description for the PatronSelfRegistrationLibraryList system preference makes sense. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nicolas Hunstein from comment #7)
@ Marcel de Rooy: Thank you very much for informing me that correcions in "updatedatabase" are neither necessary nor helpful and for adding my name to the Assignee field. May you please tell me where I can still find the description "Selfregistration"? Currently I can only find it in the release notes and dbrevs.
Seems like we got them all now. Did some git grep -i's but could not find bad hits outside variable names etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #15 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- This has already been added to the terminology page, and I created a bug to correct the instances in the manual (Bug 39454). Whenever it has gone through all the release maintainers, there is no need to set it to Needs Documenting. You can close it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not backport to 24.11.x to avoid translation work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31270 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Keywords|Academy | Documentation| |Caroline Cyr La Rose contact| | Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1100 --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I only changed the syspref description in the manual. The rest of the changes were already OK as Marion had already gone through the manual as part of bug 39454. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org