[Bug 21976] New: koha-reset-passwd must call Koha::AuthUtils::generate_password to deal with password restrictions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Bug ID: 21976 Summary: koha-reset-passwd must call Koha::AuthUtils::generate_password to deal with password restrictions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Depends on: 18298 Like minPasswordLength and RequireStrongPassword Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 [Bug 18298] Allow enforcing password complexity -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-reset-passwd must call |koha-reset-passwd does not |Koha::AuthUtils::generate_p |deal with password |assword to deal with |restrictions |password restrictions | --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Must it call Koha::AuthUtils::generate_password? See the discussion on bug 17746. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |tomascohen@gmail.com Resolution|--- |DUPLICATE --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** This bug has been marked as a duplicate of bug 17746 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I think this one should remain open, and probably be an enhancement on top of bug 17746. Sorry for the confusion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I wrote a patch for this, but then also noticed the 12-digit password generated by pwgen 12 will probably always pass. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 84799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84799&action=edit Bug 21976: Make koha-reset-passwd respect restrictions This patch makes the set_password.pl script default to respect the restrictions, and adds a --skip_validation parameter to it. koha-reset-passwd is adapted so it also accepts this parameter. The result is the default behaviour respects the restrictions, and they can be skipped. To test: - Try with and without the option switch - Notice the randomly generated password is always strongest than what we enforce. - Sign off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17746 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Hi, This patch fails to apply with Auto-merging misc/admin/set_password.pl Auto-merging debian/scripts/koha-reset-passwd CONFLICT (content): Merge conflict in debian/scripts/koha-reset-passwd Sorry :( Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23816 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I was about to rebase and resubmit, but it turns out `set_password.pl` always passes the `skip_validation` parameter. So this is solved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org