[Bug 18548] New: running koha-create --request-db without an instance name should abort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Bug ID: 18548 Summary: running koha-create --request-db without an instance name should abort Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: eric.vantillard@evaxion.fr QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz running `koha-create --request-db` without an instance name will exit with this error message getent: invalid option -- 'k' Try `getent --help' or `getent --usage' for more information. [...] It should detect that the instance name is missing and exit with an error message explaining that the instance name is mandatory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master Assignee|gmcharlt@gmail.com |josef.moravec@gmail.com Severity|enhancement |minor CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63159&action=edit Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Eric Vantillard <eric.vantillard@evaxion.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |FIXED --- Comment #2 from Eric Vantillard <eric.vantillard@evaxion.fr> --- test done. it's fine. thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Eric Vantillard from comment #2)
test done. it's fine. thank you
Please note: "RESOLVED FIXED" status is for bugs pushed to all relevant versions, if you test it and it works for you, you should use "signed off" status. See https://wiki.koha-community.org/wiki/Development_workflow anyway thanks for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Eric Vantillard <eric.vantillard@evaxion.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Eric Vantillard <eric.vantillard@evaxion.fr> --- understood. thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Josef, Regarding `git grep -i "missing instance" debian/scripts/` I'd suggest to follow the same pattern: [ $# -ge 1 ] || ( usage ; die "Missing instance name..." ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Josef, Regarding `git grep -i "missing instance" debian/scripts/` I'd suggest to follow the same pattern: [ $# -ge 1 ] || ( usage ; die "Missing instance name..." )
thanks Jonathan, I'll make new patch... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63159|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63278&action=edit Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #8 from dilan@calyx.net.au --- Just tried it Josef. It's still giving a 'getent [...]' message instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to dilan from comment #8)
Just tried it Josef. It's still giving a 'getent [...]' message instead.
Can't help it, but it works for me... how do you try to test it? On devbox? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #10 from dilan@calyx.net.au --- Created attachment 63319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63319&action=edit Screenshot after applying patch - not working Yeah on a devbox. Have a look at the attachment. This is the message I get after applying the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to dilan from comment #10)
Created attachment 63319 [details] Screenshot after applying patch - not working
Yeah on a devbox. Have a look at the attachment. This is the message I get after applying the patch.
On devbox you should run it as debian/scripts/koha-create because that's the modified file - the koha-create in system is that one installled by package - so old version -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63278|0 |1 is obsolete| | --- Comment #12 from dilan@calyx.net.au --- Created attachment 63495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63495&action=edit Bug 18548: Print usage when missing instance name in koha-create script My apologies Josef, you are correct. It works prefectly with the right command. Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63495|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63581&action=edit Bug 18548: Print usage when missing instance name in koha-create script Test plan: 1. Run: debian/scripts/koha-create --request-db -> Without patch you see the getent error message -> With patch you see usage and "Missing instance name" message Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548 --- Comment #16 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org