[Bug 36767] New: Add a hint to the EDI account form that the SFTP/FTP port will fallback to port 22 if not defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Bug ID: 36767 Summary: Add a hint to the EDI account form that the SFTP/FTP port will fallback to port 22 if not defined Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org In bug 35724 we added the ability for users to define a non-standard port for SFTP/FTP via 'upload port' and 'download port' input boxes on the EDI account form. In the code, we fallback to port 22 if the user has not defined the upload and download ports. We should add a hint to the EDI account form that Koha will fallback to port 22 if those input fields are not set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35724 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 [Bug 35724] Define non-standard port numbers for SFTP upload/download in EDI accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #1 from David Nind <david@davidnind.com> --- I was going to add a patch for this. However, when adding a new EDI account I get an error trace if values are not entered in both the upload or download port: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_kohadev`.`vendor_edi_accounts`.`download_port` at row 1 at /kohadevbox/koha/admin/edi_accounts.pl line 100 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 So it seems that there is no "fall back" option if these fields are not defined, or something else is causing this error. In addition, maybe some of the fields should be marked as mandatory, like the remote host? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167749&action=edit Bug 36767: Default port should be set to 22 This patch sets a default value for the EDI account form for the upload and download ports Test plan: 1) Try to create an EDI account without setting the upload or download ports 2) The form will crash 3) Apply patch and restart_all 4) Try again, the form should submit 5) In your new EDI account, you should see the value of 22 for both ports -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167750&action=edit Bug 36767: Add a hint to show the new default of 22 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Spotted the same error that David mentions whilst signing off another EDI bug - this seemed the logical place to add a patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167749|0 |1 is obsolete| | --- Comment #5 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167752&action=edit Bug 36767: Default port should be set to 22 This patch sets a default value for the EDI account form for the upload and download ports Test plan: 1) Try to create an EDI account without setting the upload or download ports 2) The form will crash 3) Apply patch and restart_all 4) Try again, the form should submit 5) In your new EDI account, you should see the value of 22 for both ports Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167750|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 167753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167753&action=edit Bug 36767: Add a hint to show the new default of 22 Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked from QA queue for direkt push to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting Text to go in the| |This fixes an error when release notes| |creating an EDI account if | |you don't enter the upload | |and download ports. The | |port is supposed to default | |to port 22, but it doesn't, | |and then generates an | |error. It also adds a hint | |to the input fields to say | |that the port will default | |to 22 if not set. --- Comment #10 from David Nind <david@davidnind.com> --- I think this is needs backporting to 24.05.x. This is because it is both a bug fix and an enhancement: 1. When adding an EDIT account, it fixes a DBIx error if you don't enter a port number for the upload and download port fields (it is supposed to default to port 22, but doesn't). [1] 2. It adds some hint text for the upload and download port fields (which is an enhancement). In the meantime, I've changed the status to needs documenting, as the manual needs updating for any screenshots and other text changes required. [1] Error that needs fixing for 24.05.x (which is currently 24.05.01) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1. Enable the EDIFACT system preference. 2. Add an EDI account: Administration > Acqusition parameters > EDI accounts > + New account . Don't add any values for the fields 'Upload port' and 'Download ports' . Press 'Submit' Result==> You get an error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Incorrect integer value: '' for column `koha_kohadev`.`vendor_edi_accounts`.`download_port` at row 1 at /kohadevbox/koha/admin/edi_accounts.pl line 100 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 3. Note that this is supposed to default to port 22 if no values are entered (see bug 35724), but it doesn't and causes the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes an error when |This fixes an error when release notes|creating an EDI account if |creating an EDI account if |you don't enter the upload |you don't enter the upload |and download ports. The |and download ports. The |port is supposed to default |port numbers should have |to port 22, but it doesn't, |defaulted to port 22, but |and then generates an |didn't - this generated an |error. It also adds a hint |error when saving. It also |to the input fields to say |adds a hint for the input |that the port will default |fields to say that the port |to 22 if not set. |will default to 22 if not | |set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Bug 36767 depends on bug 35724, which changed state. Bug 35724 Summary: Define non-standard port numbers for SFTP upload/download in EDI accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Bug 36767 depends on bug 35724, which changed state. Bug 35724 Summary: Define non-standard port numbers for SFTP upload/download in EDI accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35724 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36767 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Should be documented as part of bug 35724 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org