http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8455 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10883|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 10977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10977&action=edit Bug 8455 - Check ins processed through "Check Out" tab of the Patron Record ignore Circulation System Preferences If you check-in an item through the "Check Out" tab of the Patron Record, the return/check-in ignores the "InProcessingToShelvingCart" and "ReturnToShelvingCart" circulation system preferences. Or rather, there just isn't any logic to handle them in the renewscript.pl file. I'm pretty much just bringing the code straight across from returns.pl, although some minor changes need to be made due to context. Both system preferences are important to include, since you can check-out an in processing item to a patron. While a regular check-in will clear the in processing status, a check-in through the Patron module will cause the item to have its status returned to "In Processing" rather than going to "Shelving Cart", if the preference is set, of course. To test the scenario, turn on one of (or both of) these settings and try checking books in through the Circulation module and the Patron module. Before the patch, you will see that only the Circulation module will change the shelving location. After the patch, you should see identical behaviour. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=7189 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8455 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Signed off on primary patch. I've added a followup to perltidy renewscript.pl, as this seems like a good time to do it. I doubt there are any other patches in process that touch this file. David, if you can sign off on the followup, you could then mark the status of this bug as "Signed Off". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8455 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Signed off on follow-up patch. Perltidy looks good and everything seems to work. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8455 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Another comment: on the members pages members/moremember.pl?borrowernumber=NNN, you can also check-in. This page calls reserve/renewscript.pl as well, so it fixes the behaviour here as well. ( Note that I haven't tested it works, but at least it does not break anything if you don't have InProcessingToShelvingCart or ReturnToShelvingCart set) -- You are receiving this mail because: You are watching all bug changes.