[Bug 15311] New: Let libraries set text to display when OpacMaintenance = on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Bug ID: 15311 Summary: Let libraries set text to display when OpacMaintenance = on Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org Setting OpacMaintenance = on displays a standard message in the OPAC. It would be easy to add another syspref that could take arbitrary text to be displayed as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bc@interleaf.ie --- Comment #1 from Barry Cannon <bc@interleaf.ie> --- Created attachment 45711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45711&action=edit Patch to enable OpacMaintenanceNotice systempreference -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Barry Cannon <bc@interleaf.ie> --- Added new systempreference OpacMaintenanceNotice. When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will be displayed. Enabling OpacMaintenance is all that is required to enable this preference. If OpacMaintenanceNotice is undefined, the default (original) notice will appear when OpacMaintenance is enabled. To test: - Enable OpacMaintenance systempreference - Observe the default maintenance message when OPAC is viewed - Edit OpacMaintenanceNotice systempreference, adding custom HTML - Observe the custom HTML appear on the opac - Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.) - Observe the default opac notice appears in the opac - Disable OpacMaintenance - Observce opac is back online -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 45712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45712&action=edit Bug 15311 - Let libraries set text to display when OpacMaintenance = on Added new systempreference OpacMaintenanceNotice. When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will be displayed. Enabling OpacMaintenance is all that is required to enable this preference. If OpacMaintenanceNotice is undefined, the default (original) notice will appear when OpacMaintenance is enabled. To test: - Enable OpacMaintenance systempreference - Observe the default maintenance message when OPAC is viewed - Edit OpacMaintenanceNotice systempreference, adding custom HTML - Observe the custom HTML appear on the opac - Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.) - Observe the default opac notice appears in the opac - Disable OpacMaintenance - Observce opac is back online Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 45712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45712 Bug 15311 - Let libraries set text to display when OpacMaintenance = on Review of attachment 45712: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15311&attachment=45712) ----------------------------------------------------------------- It would have been great to use the new table localization and create a new area in the admin module to let libraries define several values for this text, depending on the language used. ::: installer/data/mysql/updatedatabase.pl @@ +11393,5 @@
+$DBversion = "3.23.00.XXX"; +if(CheckVersion($DBversion)) { + $dbh->do(q{ + INSERT IGNORE INTO systempreferences (variable,value,explanation,options,type) + VALUES ('OpacMaintenanceNotice','','70|10','A user-defined block of HTML to appear on screen when OpacMaintenace is enabled','Textarea')
what is 70|10? explanation and options don't seem in the correct order. ::: opac/maintenance.pl @@ +33,5 @@
$koha_db_version =~ s/\.//g if defined $koha_db_version; +my $maintenance_notice = C4::Context->preference('OpacMaintenanceNotice'); + +$template->param( + maintenance_notice => $maintenance_notice
Don't pass it to the template, use the Koha template plugin to access syspref values (Koha.Preference) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |bc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45711|0 |1 is obsolete| | Attachment #45712|0 |1 is obsolete| | --- Comment #5 from Barry Cannon <bc@interleaf.ie> --- Created attachment 45719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45719&action=edit Patch to enable OpacMaintenanceNotice systempreference Added new systempreference OpacMaintenanceNotice. When OpacMaintenance is ON the HTML contents of OpacMaintenanceNotice will be displayed. Enabling OpacMaintenance is all that is required to enable this preference. If OpacMaintenanceNotice is undefined, the default (original) notice will appear when OpacMaintenance is enabled. To test: - Enable OpacMaintenance systempreference - Observe the default maintenance message when OPAC is viewed - Edit OpacMaintenanceNotice systempreference, adding custom HTML - Observe the custom HTML appear on the opac - Remove OpacMaintenanceNotice (mindful of orphaned spaces etc.) - Observe the default opac notice appears in the opac - Disable OpacMaintenance - Observce opac is back online -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Should this be set back to Needs signoff or Signed off? Thanks to everyone contributing to realising my little idea! :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Barry Cannon <bc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #8 from Marc Véron <veron@veron.ch> --- (In reply to Aleisha Amohia from comment #7)
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
I think that the part in /installer/data/mysql/updatedatabase.pl should go to an atomic update, see: http://wiki.koha-community.org/wiki/Database_updates#updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15311 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Will set to Failed QA until the move to an atomic update is made. Set back to Needs Signoff when that's done so I can come test it again :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org