https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com, | |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just because they're required for operation doesn't mean we should hide them. We should have encouraged best practice which is to inform the user what the required cookies are used for.. That way then can then choose to opt out of using your service if they believe the required cookies are over the top. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |aude.charillon@ptfs-europe. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35347 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35347 [Bug 35347] 'More information' should always display in cookie consent bar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|35346 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35346 [Bug 35346] 'Accept essential cookies' should always appear if CookieConsent is enabled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34792 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34792 [Bug 34792] CookieConsentBar content feels mis-aligned -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159090&action=edit Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' The modal is not always about consent, but rather about displaying the libraries cookie policy. It makes sense to update the heading to reflect that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159089|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159094&action=edit Bug 34793: Add default HTML Customisations for cookie information This patch adds some default html customisation content for the cookie consent feature. Test plan 1) Run through the installer and pick to import the sample news items 2) Confirm that after enabling the CookieConsent preference that the default content appears in the cookie bar at the bottom of the page and in the modal that appears after clicking 'More information' Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Quick typo fix applied ;P -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #10 from David Nind <david@davidnind.com> --- I've tested and am happy to sign off. Comments/suggestions: 1. Should the cookie bar link to the cookie policy? I only see this in the OPAC by going to Your account > Consents > under Cookies policy is "View your cookie consents" button > pop up window has "Accept all cookies" irrespective of whether you have clicked on the "Accept all cookies" in the cookie bar. 2. The table in the Consent policy page in the OPAC. It looks fine when you preview in Tools. However, in the OPAC it has hard to read as the rows are aligned to the center, with no alternate row colours or border between rows. Can the table rows be aligned to the top, and formatted similar to the staff interface tools preview? 3. I'm not sure that I understand the normal workflow for this from a patron perspective, even after reading through bug 27378, and how it works with the privacy policy. Testing notes: 1. Starting the web installer in KTD: https://gitlab.com/-/snippets/1893788#user-content-starting-the-web-installe... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 159132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159132&action=edit Bug 34793: (follow-up) Add table classes to popup This patch adds the appropriate table classes to the Popup html customisation block. This ensure we have proper table display formatting in the modal on the OPAC. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159095|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 159134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159134&action=edit Bug 34793: (follow-up) Rename 'Cookie consents' to 'Cookies policy' The modal is not always about consent, but rather about displaying the libraries cookie policy. It makes sense to update the heading to reflect that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #17 from David Nind <david@davidnind.com> --- (In reply to Martin Renvoize from comment #13)

PS, I set up a sandboxes with the full set of bugs applied if, it includes the follow-up I just added here too.

http://opac-cookies.sandboxes.ptfs-europe.co.uk

Thanks Martin! I had missed the other bugs. I can see the bigger picture now... Thanks also for fixing the CSS for the OPAC display. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Considering this series is a set that really aught to have been included in 23.11.00.. I'm a little disappointed they're still stuck waiting for QA :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

The online catalog uses functional cookies: these are essential to make the site work.

It says the same on the staff interface >_< Nothing that would work for both comes to my mind, any ideas? Or do we still call it online catalog in the staff interface and whatever. And like if for some libraries there is really a difference in cookies in the staff and OPAC because of some staff plugin or additional tracking of librarians (boooo!). Then they would submit/order a patch to have two different additional content entries for staff and OPAC and that will also solve this. Anyway, most important is if there would be a nice phrasing instead of "online catalog" that would also work for the staff. Maybe not something as generic as "this web application". Before that stuff is half set in stone when it's shipped and in the DB of instances. --- There doesn't seem to be other relevant occurrences after searching "Cookie consent" and "consent" (case unsensitively). Some stuff is still user facing but it's for the librarians managing html_customizations and that would require changing existing data so not worth it. --- Maybe a follow-up ticket is needed: to have these ticked by default in the installer. Because "sample news items" looks like demo stuff and not something that every library in EU and Australia (at least) needs to have. So they would miss it. If it's by default, when enabling the syspref, the English default text would immediately pop so they can directly use it or translate it without having to search for the list of cookies Koha use for example. Oh wait, shouldn't it even be in a database upgrade instead of installer's optional sample data? (then it's a matter for this ticket) For existing instances that enabled the consent but don't have the additional content entries related to cookies policy. Like due to not immediately knowing what to put there (cookie list and explanation what are cookies). It's also a way to address the above paragraph. --- I though I was close to having finished reviewing without having found issues

_<

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 --- Comment #22 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Thank you for looking into our cookie recipes Victor! ;-) Yes, we are fully aware the default text for CookieConsentBar specifically references the catalog... even though it will also be seen on the staff interface. Ideally, there should be separate HTML customizations for the Opac cookies and the Intranet cookies. As you pointed out, the cookies used on the two sites could be different. We discussed this with Martin back in September and we agreed the separate HTML customizations would be logged as follow-up bugs. Right now, we want to focus on making the Opac cookies work in a more logical way and on helping the library team get a head start when using the feature. We assume the public-facing side is more of a priority for library teams. I don't think the wording "the online catalog" needs to be changed. Here's why: 1. When creating a new HTML customization and selecting a display location, CookieConsentBar and CookieConsentPopup are under the Opac section. This makes it clear to library staff the default text is aimed at the Opac. 2. It's default text: by definition, it's meant to be built on. I expect library teams to amend the wording to their liking. 3. The essential cookies described in CookieConsentPopup are only those used on the Opac. According to the wiki (https://wiki.koha-community.org/wiki/Use_of_Cookies) there are more in the intranet. Having both sets in the HTML customizations would make it messy and confusing, which completely undermines the concept of proposing a clear and simple default cookie text - that we're trying to achieve here. Sorry it turned into a long reply! I think Martin covered the more technical questions :-) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159133|0 |1 is obsolete| | --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162039&action=edit Bug 34793: Add default HTML Customisations for cookie information This patch adds some default html customisation content for the cookie consent feature. Test plan 1) Run through the installer and pick to import the sample news items 2) Confirm that after enabling the CookieConsent preference that the default content appears in the cookie bar at the bottom of the page and in the modal that appears after clicking 'More information' Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159135|0 |1 is obsolete| | --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 162041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162041&action=edit Bug 34793: (follow-up) Add table classes to popup This patch adds the appropriate table classes to the Popup html customisation block. This ensure we have proper table display formatting in the modal on the OPAC. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |QUICK NOTE: only for new release notes| |installs that select | |"sample news items" in the | |installer Status|Signed Off |Passed QA --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Bug 34793 depends on bug 27378, which changed state. Bug 27378 Summary: Enable compliance with EU Cookie Legislation via cookie consent https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34793 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|QUICK NOTE: only for new |This only applies to new release notes|installs that select |installations that select |"sample news items" in the |"sample news items" in the |installer |web installer. -- You are receiving this mail because: You are watching all bug changes.