[Bug 18684] New: Get rid of %%] in translation for currency.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Bug ID: 18684 Summary: Get rid of %%] in translation for currency.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 63753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63753&action=edit Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |18665 Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 [Bug 18665] Translatability: Add tt filter to allow html tags inside tt directives -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18662 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 [Bug 18662] Can not delete currencies -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Get rid of %%] in |Translatability: Get rid of |translation for currency.tt |%%] in translation for | |currency.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63753|0 |1 is obsolete| | --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63769&action=edit Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before Followed test plan and it worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Bug 18684 depends on bug 18662, which changed state. Bug 18662 Summary: Can not delete currencies https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18662 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63769|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 64418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64418&action=edit Bug 18684 - Get rid of %%] in translation for currency.tt File add koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt exposes parts of template directives due to html tags inide directives. Fix it using the HtmlTags filter. To verify: - Create a translation for a language 'aa-AA - po file aa-AA-staff-prog.po / translate.koha-community.org for 17.05 contains a line '%%]'%sCurrencies %s To test: - Apply patch on top of Bug 18665 - Recreate translation - Verify that line above is gone - Verify that in staff client currencies administration wors as before Followed test plan and it worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why the closing h3 tags is on a new line? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #4)
Why the closing h3 tags is on a new line?
Seems to be a mistake? How do you want it fixed? Amend patch or a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- follow-up please, I will squash them. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 64442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64442&action=edit Bug 18684: (followup) Move 2 closing h3 tags to end of previous lines See comment #4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Bug 18684 depends on bug 18665, which changed state. Bug 18665 Summary: Translatability: Add tt filter to allow html tags inside tt directives https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18665 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x Depends on Bug 18665 which is not pushed into 17.05.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18684 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org