[Bug 33806] New: Overridden checkin date not retained when CircConfirmItemParts enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Bug ID: 33806 Summary: Overridden checkin date not retained when CircConfirmItemParts enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 151563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151563&action=edit Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151563|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 151570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151570&action=edit Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33811 [Bug 33811] Overridden checkin dates are not respected at all when CircConfirmItemParts enabled and item has parts note -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151570|0 |1 is obsolete| | --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 151578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151578&action=edit Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151578|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 152275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152275&action=edit Bug 33806: Retain specified date when confirming item parts at checkin This patch simply adds hidden inputs to the item parts confirm form to ensure specified checkin date is retained To test: 1 - Find or add an item with subfield 3 - materials specified 2 - Enable system preference CircConfirmItemParts 3 - Go to Circulation->Checkin 4 - Click the settings button in the input box and enter a checkin date and select the remeber check box 5 - Check in some items, confirm date retained 6 - Checkin the item with the materials specified 7 - Confirm checkin 8 - Note that checkin date is cleared 9 - Apply patch 10 - Repeat 3-7 11 - Confirm date is retained Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33806 Mike Barrette <mbarrette@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbarrette@oslri.net -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org