[Bug 29480] New: Add email address as a method for generating the userid when self registering in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Bug ID: 29480 Summary: Add email address as a method for generating the userid when self registering in OPAC Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andreas.jonsson@kreablo.se QA Contact: testopia@bugs.koha-community.org - Add a system preference for selecting a method for generating the userid when self registering - Fall back to the default method (firstname.surname[uniqueness identifier when needed]) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 127636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127636&action=edit Bug 29480: Add new systempreference PatronSelfRegistrationUseridGenerationMethod and add email as option. Test plan - Install patch and run koha-upgrade-schema <instance> - The systempreference PatronSelfRegistrationUseridGenerationMethod should be found in the adminstrative interface under OPAC -> Self registration and modification - Also make sure - Make sure that PatronSelfRegistration is set to Allow and PatronSelfRegistrationDefaultCategory is set to an existing borrower category - Make sure that PatronSelfModificationBorrowerUnwantedField doesn't prevent the input of an email address in the self registration form. (I.e., make sure "email" is NOT selected for exclusion.) - Go to opac and self register a patron and verify that the userid is on the form firstname.surname. - Change systempreference to 'email' - Go to OPAC and self register a patron and make sure to add a valid email address. - Verify the that the userid is the email adress. - Go to OPAC and self register a patron using the SAME valid email adress as above (to provoke a conflicting userid). - Verify that the userid is on the form firstname.surname. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Andreas, can you set yourself as assignee? I might be wrong but I think sysprefs.sql needs updating too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127636|0 |1 is obsolete| | --- Comment #3 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 127679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127679&action=edit Bug 29480: Add new systempreference PatronSelfRegistrationUseridGenerationMethod and add email as option. Test plan - Install patch and run koha-upgrade-schema <instance> - The systempreference PatronSelfRegistrationUseridGenerationMethod should be found in the adminstrative interface under OPAC -> Self registration and modification - Also make sure - Make sure that PatronSelfRegistration is set to Allow and PatronSelfRegistrationDefaultCategory is set to an existing borrower category - Make sure that PatronSelfModificationBorrowerUnwantedField doesn't prevent the input of an email address in the self registration form. (I.e., make sure "email" is NOT selected for exclusion.) - Go to opac and self register a patron and verify that the userid is on the form firstname.surname. - Change systempreference to 'email' - Go to OPAC and self register a patron and make sure to add a valid email address. - Verify the that the userid is the email adress. - Go to OPAC and self register a patron using the SAME valid email adress as above (to provoke a conflicting userid). - Verify that the userid is on the form firstname.surname. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |andreas.jonsson@kreablo.se --- Comment #4 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Yes, I had missed to add the system preference to sysprefs.sql. Thank you David for pointing this out! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please provide tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- You also need to rename 'borrower' with 'patron'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no --- Comment #7 from Magnus Enger <magnus@libriotech.no> --- The POD for generate_userid() should be updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127679|0 |1 is obsolete| | --- Comment #8 from Magnus Enger <magnus@libriotech.no> --- Created attachment 142133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142133&action=edit Bug 29480: Add new systempreference PatronSelfRegistrationUseridGenerationMethod and add email as option. Test plan - Install patch and run koha-upgrade-schema <instance> - The systempreference PatronSelfRegistrationUseridGenerationMethod should be found in the adminstrative interface under OPAC -> Self registration and modification - Also make sure - Make sure that PatronSelfRegistration is set to Allow and PatronSelfRegistrationDefaultCategory is set to an existing borrower category - Make sure that PatronSelfModificationBorrowerUnwantedField doesn't prevent the input of an email address in the self registration form. (I.e., make sure "email" is NOT selected for exclusion.) - Go to opac and self register a patron and verify that the userid is on the form firstname.surname. - Change systempreference to 'email' - Go to OPAC and self register a patron and make sure to add a valid email address. - Verify the that the userid is the email adress. - Go to OPAC and self register a patron using the SAME valid email adress as above (to provoke a conflicting userid). - Verify that the userid is on the form firstname.surname. Signed-off-by: Magnus Enger <magnus@libriotech.no> Works as advertised. I will provide followups for the issues that have been pointed out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #9 from Magnus Enger <magnus@libriotech.no> --- Created attachment 142134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142134&action=edit Bug 29480: (follow up) Use "patron", not "borrower" Also changes "user name" to "userid". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #10 from Magnus Enger <magnus@libriotech.no> --- Created attachment 142135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142135&action=edit Bug 29480: (follow up) Add tests to subtest generate_userid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #11 from Magnus Enger <magnus@libriotech.no> --- Created attachment 142136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142136&action=edit Bug 29480: (follow up) Update POD for generate_userid() Add an explanation of how PatronSelfRegistrationUseridGenerationMethod will affect behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please use the new style for an atomic update: use Modern::Perl; return { bug_number => "BUG_NUMBER", description => "A single line description", up => sub { my ($args) = @_; my ($dbh, $out) = @$args{qw(dbh out)}; # Do you stuffs here $dbh->do(q{}); # Print useful stuff here say $out "Update is going well so far"; }, }; See skeleton file in the atomicupdate folder. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Functional question about: +If PatronSelfRegistrationUseridGenerationMethod is set to 'email', the email +address will be used as the userid. If the patron being created has no email, +or the patron has an email address that is already in use by another patron, +the default way of creating the userid ($firstname.$surname) will be used. Is that really what you want? If my email address is already in the database, I probably dont want another account. One of the issues we face is actually that impatient people register 2 or 3 accounts. There is a security aspect too. You do not want to offer a way to check if an email address is present. So it might be safer to send a verification mail to the email address specified that either gives you a link to proceed or tells you that there is an account already. The OPAC could just say: check your mail, and not reveal the information. What do you think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #13)
Functional question about:
+If PatronSelfRegistrationUseridGenerationMethod is set to 'email', the email +address will be used as the userid. If the patron being created has no email, +or the patron has an email address that is already in use by another patron, +the default way of creating the userid ($firstname.$surname) will be used.
Is that really what you want? If my email address is already in the database, I probably dont want another account. One of the issues we face is actually that impatient people register 2 or 3 accounts.
We see this for families where the email address of the parents is used in the children's accounts as well. Also sometimes for internal accounts where a library address might be used several times. Some academic libraries also do separate accounts for 'permanent loans'. Maybe display a warning or so instead of not allowing it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #14)
(In reply to Marcel de Rooy from comment #13)
Functional question about:
+If PatronSelfRegistrationUseridGenerationMethod is set to 'email', the email +address will be used as the userid. If the patron being created has no email, +or the patron has an email address that is already in use by another patron, +the default way of creating the userid ($firstname.$surname) will be used.
Is that really what you want? If my email address is already in the database, I probably dont want another account. One of the issues we face is actually that impatient people register 2 or 3 accounts.
We see this for families where the email address of the parents is used in the children's accounts as well. Also sometimes for internal accounts where a library address might be used several times. Some academic libraries also do separate accounts for 'permanent loans'.
Maybe display a warning or so instead of not allowing it?
Maybe a lax or strict mode or so? Obviously you dont need to use email as userid, but if you do, it might be nice to choose between fallback to name based userid or not allowing it.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** Bug 2237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32426 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- On bug 32426 I will give the plugin approach a try in getting this long standing enh req further. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #17)
On bug 32426 I will give the plugin approach a try in getting this long standing enh req further.
Submitted some patches on that report now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29480 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Please note that the plugin approach on bug 32426 has been pushed now. This allows you to move your code to a Koha plugin. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org