https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #430 from Lisette Scheer <lisette@bywatersolutions.com> --- Jake, thanks for all your hard work! Here are my testing notes: Following the test plan: https://docs.google.com/document/d/1EeDN9d787zJyN17-86v_owGkbFEn4fyM6iqb3Cz_... At 5.2 step 3, if you create with your non-super librarian, there's a link to the background job, but the status doesn't update. Also the sidebar on the displays module page is smaller than the header of the sidebar. At 7.1 & 7.2 step 3, if it's set to 'enabled' it shows the changed values, even if there's a start date in the future or an end date in the past 7.3 works as expected I can't consistently remove the last item from a display. It will look like it did, but then if I open the display again it's still there. This happened both as superlibrarian and more limited staff. Save and continue editing spits you back to the displays page instead of reloading the edit page. Duration seems to autofill on creation to 14 if you leave it empty, even if you set a longer start and end date. It looks like if you remove it on subsequent edits it works as expected. It also fills the dates for today+2 weeks if all the fields are blank. If they aren't required, I'd expect that you could have a date-less display. A number of the columns that have active_display are set: columnname: active_display cannot_be_toggled: 1 cannot_be_modified: 1 is_hidden: 1 It seems odd to me that it's hidden, can't be toggled, and is off. Is that just because it needs to be present for the code to grab it when active? There are a few coding guidelines that need to be met: JS19: Avoid Template::Toolkit tags in script tags JS21: Avoid jQuery for new or refactored code in Koha core ACTN1: New additions to actions logs should use the JSON Diff format https://wiki.koha-community.org/wiki/Coding_Guidelines Additionally some tests fail: [FAIL] t/cypress/integration/Display/Displays_spec.ts FAIL forbidden_patterns forbidden pattern: .only detected (line 443) [SKIP] debian/templates/apache-shared-intranet.conf SKIP new_line_at_the_end_of_file [PASS] display/display-home.pl [SKIP] etc/koha-httpd.conf SKIP new_line_at_the_end_of_file [WARN] installer/data/mysql/atomicupdate/bug_14962-temporary_shelves.pl WARN spelling permenant ==> permanent [SKIP] installer/data/mysql/mandatory/auth_val_cat.sql SKIP new_line_at_the_end_of_file [SKIP] installer/data/mysql/mandatory/userflags.sql SKIP new_line_at_the_end_of_file [SKIP] installer/data/mysql/mandatory/userpermissions.sql SKIP new_line_at_the_end_of_file [SKIP] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref SKIP new_line_at_the_end_of_file [SKIP] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref SKIP new_line_at_the_end_of_file [WARN] koha-tmpl/intranet-tmpl/prog/js/vue/components/Display/DisplaysResource.vue WARN spelling permenant ==> permanent * Proving /kohadevbox/koha/t/db_dependent/api/v1/displayitems.t FAIL # Failed test '200 OK' # at /kohadevbox/koha/t/db_dependent/api/v1/displayitems.t line 193. # got: '404' # expected: '200' # Failed test 'exact match for JSON Pointer ""' # at /kohadevbox/koha/t/db_dependent/api/v1/displayitems.t line 193. # Structures begin differing at: # $got->{active} = Does not exist # $expected->{active} = 0 # Looks like you failed 2 tests of 11. # Failed test 'get() tests' # at /kohadevbox/koha/t/db_dependent/api/v1/displayitems.t line 228. # Looks like you failed 1 test of 6. /kohadevbox/koha/t/db_dependent/api/v1/displayitems.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/6 subtests Have you considered sharing the new syspref to HEA? (see bug 23849 and C4/UsageStats.pm) -- You are receiving this mail because: You are watching all bug changes.