[Bug 32774] New: Add information about patron type to suggestion management tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Bug ID: 32774 Summary: Add information about patron type to suggestion management tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some librarians would find it useful if the suggestion management tables on suggestion.tt included some information about the patron type in the Suggested by column. This could help staff make rapid decisions regarding suggestions based on the patron type. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145917&action=edit Bug 32774: Add patron category to suggestion managment tables To test: 1. Apply patch 2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the 'Suggested by' column now included the patron category. 6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add information about |Add patron category to |patron type to suggestion |suggestion management |management tables |tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145917|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145927&action=edit Bug 32774: Add patron category to suggestion managment tables To test: 1. Apply patch 2. Regenrate the staff CSS ( https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... ) 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the 'Suggested by' column now included the patron category. 6. Put some suggestions in different statuses and make sure you see the patron category in each of the tables. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Felicity Brown <felicity.brown@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicity.brown@montgomeryco | |untymd.gov --- Comment #3 from Felicity Brown <felicity.brown@montgomerycountymd.gov> --- Having the patron type included in customer suggestions would be super helpful for our Acquisitions staff. It would be great if this were it's own separate column, so that purchase suggestions could be sorted by customer type (I'm thinking about sorting out staff requests for collection redevelopment versus new title suggestions from customers). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Felicity Brown from comment #3)
Having the patron type included in customer suggestions would be super helpful for our Acquisitions staff. It would be great if this were it's own separate column, so that purchase suggestions could be sorted by customer type (I'm thinking about sorting out staff requests for collection redevelopment versus new title suggestions from customers).
Failing this based on Felicity's comment. New patch incoming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145927|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145967&action=edit Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145967|0 |1 is obsolete| | --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 145975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145975&action=edit Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe that Felicity meant the patron category by 'customer's type'. So instead of 'Staff (S)', we should display the usual 'Staff' without the added type. I'll provide a patch to remove the patron category's type from display for consistency and because those single letters don't work well with translations and have been causing a lot of confusion in the past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145975|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146197&action=edit Bug 32774: Add suggester category column to suggestion tables To test: 1. Apply patch 2. Restart_all 3. Make some suggestions 4. Go to Acquisitions > Suggestions management 5. Notice the new 'Suggester category' column which included the patron category of the suggester. 6. Put some suggestions in different statuses and make sure you see the new column on each of the tables. 7. Go to Table settings and make sure you can properly hide the new column and any other column in the table. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146198&action=edit Bug 32774: (QA follow-up) Remove patron category type from display This is for consistency and because those single letters don't translate well and are more prone to cause confusion than being helpful. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #10 from Felicity Brown <felicity.brown@montgomerycountymd.gov> --- Correct. The full word "Staff" is much more helpful than the abbreviation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Felicity Brown from comment #10)
Correct. The full word "Staff" is much more helpful than the abbreviation.
Thx Felicity! The full description will display. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |tomascohen@gmail.com --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase. It colllides with bug 32603 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32774 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- This is a duplicate of 32603. *** This bug has been marked as a duplicate of bug 32603 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org