[Bug 26245] New: Remove unused functions from members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Bug ID: 26245 Summary: Remove unused functions from members.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 26244 There are several functions in members.js which are obsolete and unused. Rather than change them in the process of fixing Bug 26244 they should be removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26244 [Bug 26244] Move translatable strings out of memberentrygen.tt and into JavaScript -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 108565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108565&action=edit Bug 26245: Remove unused functions from members.js This patch removes some code from members.js which was unused. To test, apply the patch and test that the process of adding or editing a patron is unaffected. Check the Koha codebase for references to these functions in JavaScript: CheckDate unique (note: Not the jQuery function) check_manip_date check_password There should be none. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch probably should have included changes to memberentrygen.tt, since some related strings are defined there. But they will be removed by Bug 26244. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Brandon J <brandon.jimenez@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Brandon J <brandon.jimenez@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #108565|0 |1 is obsolete| | --- Comment #3 from Brandon J <brandon.jimenez@inlibro.com> --- Created attachment 110111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110111&action=edit Bug 26245: Remove unused functions from members.js This patch removes some code from members.js which was unused. To test, apply the patch and test that the process of adding or editing a patron is unaffected. Check the Koha codebase for references to these functions in JavaScript: CheckDate unique (note: Not the jQuery function) check_manip_date check_password There should be none. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110111|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110116&action=edit Bug 26245: Remove unused functions from members.js This patch removes some code from members.js which was unused. To test, apply the patch and test that the process of adding or editing a patron is unaffected. Check the Koha codebase for references to these functions in JavaScript: CheckDate unique (note: Not the jQuery function) check_manip_date check_password There should be none. Signed-off-by: Brandon J <brandon.jimenez@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26245 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org